From: Richard Kettlewell <rjk@greenend.org.uk>
Date: Wed, 11 Jun 2008 10:21:38 +0000 (+0100)
Subject: Leave a comment about iffy icon sensivity; it's definitely setting the
X-Git-Tag: 4.1~15^2~54
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~mdw/git/disorder/commitdiff_plain/7392b131424322234159283e35fcccefa31f5ff2

Leave a comment about iffy icon sensivity; it's definitely setting the
right thing so I think this is a GTK+ bug.
---

diff --git a/disobedience/control.c b/disobedience/control.c
index 0b22b88..c41673a 100644
--- a/disobedience/control.c
+++ b/disobedience/control.c
@@ -384,6 +384,11 @@ static void icon_changed(const char attribute((unused)) *event,
     gtk_container_add(GTK_CONTAINER(icon->button), newchild);
     gtk_widget_show(newchild);
   }
+  /* If you disable play or random play NOT via the icon (for instance, via the
+   * edit menu or via a completely separate command line invocation) then the
+   * icon shows up as insensitive.  Hover the mouse over it and the corrcet
+   * state is immediately displayed.  sensitive and GTK_WIDGET_SENSITIVE show
+   * it to be in the correct state, so I think this is may be a GTK+ bug. */
   if(icon->tip_on)
     gtk_tooltips_set_tip(tips, icon->button,
                            on ? icon->tip_on : icon->tip_off, "");
diff --git a/disobedience/queue-generic.c b/disobedience/queue-generic.c
index 5759915..5196995 100644
--- a/disobedience/queue-generic.c
+++ b/disobedience/queue-generic.c
@@ -37,7 +37,6 @@
  * status to everything else found in that list.
  *
  * To do:
- * - random play icon sensitivity is wrong (onl) if changed from edit menu
  * - drag and drop queue rearrangement
  * - display playing row in a different color?
  */