From: espen <espen>
Date: Thu, 6 Mar 2008 22:02:08 +0000 (+0000)
Subject: Removed the need for dummy container-child classes.
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~mdw/git/clg/commitdiff_plain/5bf6c64b10f4594f89fb4c7cf5a6338280d68482

Removed the need for dummy container-child classes.
---

diff --git a/gtk/gtkcontainer.lisp b/gtk/gtkcontainer.lisp
index 128cd67..ac0a836 100644
--- a/gtk/gtkcontainer.lisp
+++ b/gtk/gtkcontainer.lisp
@@ -20,7 +20,7 @@
 ;; TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
 ;; SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-;; $Id: gtkcontainer.lisp,v 1.24 2007-07-04 14:24:54 espen Exp $
+;; $Id: gtkcontainer.lisp,v 1.25 2008-03-06 22:02:08 espen Exp $
 
 (in-package "GTK")
 
@@ -79,13 +79,21 @@ (defbinding %container-add () nil
   (container container)
   (widget widget))
 
+(defun find-child-class (container-class)
+  (or
+   (gethash container-class *container-to-child-class-mappings*)
+   (setf (gethash container-class *container-to-child-class-mappings*)
+    (or
+     (when (eq container-class (find-class 'container))
+       (find-class 'container-child))
+     (find-child-class (find-class (supertype container-class)))))))
+
 (defun init-child-slots (container child args)
   (when args
     (setf
      (slot-value child 'child-properties)
      (apply
-      #'make-instance
-      (gethash (class-of container) *container-to-child-class-mappings*)
+      #'make-instance (find-child-class (class-of container))
       :parent container :child child args))))
 
 (defmethod container-add ((container container) (widget widget) &rest args)
diff --git a/gtk/gtkobject.lisp b/gtk/gtkobject.lisp
index 7d57bfd..c098921 100644
--- a/gtk/gtkobject.lisp
+++ b/gtk/gtkobject.lisp
@@ -20,7 +20,7 @@
 ;; TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
 ;; SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-;; $Id: gtkobject.lisp,v 1.46 2008-03-04 16:03:38 espen Exp $
+;; $Id: gtkobject.lisp,v 1.47 2008-03-06 22:02:08 espen Exp $
 
 
 (in-package "GTK")
@@ -226,12 +226,18 @@ (defbinding %container-class-list-child-properties () pointer
   (class pointer)
   (n-properties unsigned-int :out))
 
-(defun query-container-class-child-properties (type-number)
+(defun query-container-class-child-properties (type-number &optional owner-only-p)
   (let ((class (type-class-ref type-number)))
     (multiple-value-bind (array length)
 	(%container-class-list-child-properties class)
       (unwind-protect
-	  (map-c-vector 'list #'identity array 'param length)
+	  (let ((properties (map-c-vector 'list #'identity array 'param length)))
+	    (if owner-only-p
+		(delete-if 
+		  #'(lambda (property)
+		      (not (eql (slot-value property 'glib::owner-type) type-number)))
+		  properties)
+	      properties))
 	(deallocate-memory array)))))
 
 (defun default-container-child-name (container-class)
@@ -245,11 +251,12 @@ (defun expand-container-type (type forward-p options)
 	(expand-gobject-type type t options)
       `(progn
 	 ,(expand-gobject-type type nil options)
-	 (defclass ,child-class (,(default-container-child-name super))
-	   ,(slot-definitions child-class 
-	     (query-container-class-child-properties type) nil)
-	   (:metaclass container-child-class)
-	   (:container ,class))))))
+	 ,(let ((child-properties (query-container-class-child-properties type t)))
+	    (when child-properties
+	      `(defclass ,child-class (,(default-container-child-name super))
+	         ,(slot-definitions child-class child-properties nil)
+		 (:metaclass container-child-class)
+		 (:container ,class))))))))
 
 (defun container-child-class (container-class)
   (gethash container-class *container-to-child-class-mappings*))