From: Mark Wooding Date: Wed, 18 May 2016 09:29:03 +0000 (+0100) Subject: base/dispatch.c: Missing parens on call to `get_hwcaps'. X-Git-Tag: 2.2.3~1^2~20 X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~mdw/git/catacomb/commitdiff_plain/0aec06589cca20e77119fd4a6c7fd69999c8ce1f?ds=inline base/dispatch.c: Missing parens on call to `get_hwcaps'. This is only a problem on ARM hosts, but it breaks the build for them (unsurprisingly). For some reason, the test machinery I used before committing the broken code came up with a slightly different host-platform name which the configure script didn't recognize, so the test environment didn't try to compile the broken code. --- diff --git a/base/dispatch.c b/base/dispatch.c index f5a25c8d..b2a032e5 100644 --- a/base/dispatch.c +++ b/base/dispatch.c @@ -519,7 +519,7 @@ int cpu_feature_p(int feat) #endif #ifdef CAPMAP # define FEATP__CASE(feat, tok) \ - CASE_CPUFEAT(feat, tok, get_hwcaps & HF_##feat) + CASE_CPUFEAT(feat, tok, get_hwcaps() & HF_##feat) CAPMAP(FEATP__CASE) #undef FEATP__CASE #endif