From: Mark Wooding <mdw@distorted.org.uk>
Date: Wed, 1 Jan 2014 17:31:02 +0000 (+0000)
Subject: key.c (key_pynew): Fix stupid error-checking sense bug.
X-Git-Tag: 1.0.6~3
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~mdw/git/catacomb-python/commitdiff_plain/f72dbe4cf57bcf84dd85b685f514b37bff3c8001

key.c (key_pynew): Fix stupid error-checking sense bug.

This code can never have worked.
---

diff --git a/key.c b/key.c
index 7deb382..7820f1d 100644
--- a/key.c
+++ b/key.c
@@ -1394,7 +1394,7 @@ static PyObject *key_pynew(PyTypeObject *ty, PyObject *arg, PyObject *kw)
 				   keyfile_pytype, &kfobj, convu32, &id,
 				   &type, &exptime))
     goto end;
-  if ((err = key_new(KEYFILE_KF(kfobj), id, type, exptime, &k)) == 0)
+  if ((err = key_new(KEYFILE_KF(kfobj), id, type, exptime, &k)) != 0)
     KEYERR(err);
   return (key_dowrap(ty, kfobj, k));
 end: