chiark / gitweb /
key.c (key_pynew): Fix stupid error-checking sense bug.
authorMark Wooding <mdw@distorted.org.uk>
Wed, 1 Jan 2014 17:31:02 +0000 (17:31 +0000)
committerMark Wooding <mdw@distorted.org.uk>
Sat, 4 Jan 2014 01:40:12 +0000 (01:40 +0000)
This code can never have worked.

key.c

diff --git a/key.c b/key.c
index 7deb3825e71deda4b2a4f307ef218a4d491042e0..7820f1d4db62a3f4252c8306a85d3de39aba73ae 100644 (file)
--- a/key.c
+++ b/key.c
@@ -1394,7 +1394,7 @@ static PyObject *key_pynew(PyTypeObject *ty, PyObject *arg, PyObject *kw)
                                   keyfile_pytype, &kfobj, convu32, &id,
                                   &type, &exptime))
     goto end;
                                   keyfile_pytype, &kfobj, convu32, &id,
                                   &type, &exptime))
     goto end;
-  if ((err = key_new(KEYFILE_KF(kfobj), id, type, exptime, &k)) == 0)
+  if ((err = key_new(KEYFILE_KF(kfobj), id, type, exptime, &k)) != 0)
     KEYERR(err);
   return (key_dowrap(ty, kfobj, k));
 end:
     KEYERR(err);
   return (key_dowrap(ty, kfobj, k));
 end: