chiark / gitweb /
possible security fix: do not call slilog with intended message as format string
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Sun, 12 Jun 2011 19:00:10 +0000 (20:00 +0100)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Sat, 10 Dec 2011 21:43:29 +0000 (21:43 +0000)
commitee963828ff8a7352437f3950f895e25361afb52c
tree2d6fba04566ab901ad4ad9fcc17829a3d76fd548
parent3f5f7b9ae51fcd4d8e47d68a5d45a0e2851f0f30
possible security fix: do not call slilog with intended message as format string

vMessage would call slilog with part of the intended log message as
the format string.  This is a potential format string vulnerability,
detected by -Wformat-security.

I have not analysed the code in detail to determine in exactly which
circumstances a secnet installation will be vulnerable, but in general
a vulnerability (at least for DOS) will exist in any situation where
an attacker can cause a log message to contain things which look like
printf directives.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
(cherry picked from commit 7908f2c6b5be419f8f4031876139953d4ee8340d)
log.c