From f9713158cbee03f37bc288a41ea6ca83c4968021 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Fri, 10 Apr 2015 12:16:54 +0200 Subject: [PATCH] util: mark unquote() static, so that new code doesn't use this anymore --- src/shared/util.c | 9 +++++---- src/shared/util.h | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/shared/util.c b/src/shared/util.c index 3561573e1..a82ac25f6 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -3676,14 +3676,15 @@ int touch(const char *path) { return touch_file(path, false, USEC_INFINITY, UID_INVALID, GID_INVALID, 0); } -char *unquote(const char *s, const char* quotes) { +static char *unquote(const char *s, const char* quotes) { size_t l; assert(s); /* This is rather stupid, simply removes the heading and * trailing quotes if there is one. Doesn't care about - * escaping or anything. We should make this smarter one - * day... */ + * escaping or anything. + * + * DON'T USE THIS FOR NEW CODE ANYMORE!*/ l = strlen(s); if (l < 2) @@ -3872,7 +3873,7 @@ static char *tag_to_udev_node(const char *tagvalue, const char *by) { _cleanup_free_ char *t = NULL, *u = NULL; size_t enc_len; - u = unquote(tagvalue, "\"\'"); + u = unquote(tagvalue, QUOTES); if (!u) return NULL; diff --git a/src/shared/util.h b/src/shared/util.h index 1026070f2..9368e84d5 100644 --- a/src/shared/util.h +++ b/src/shared/util.h @@ -523,7 +523,6 @@ char *ellipsize_mem(const char *s, size_t old_length, size_t new_length, unsigne int touch_file(const char *path, bool parents, usec_t stamp, uid_t uid, gid_t gid, mode_t mode); int touch(const char *path); -char *unquote(const char *s, const char *quotes); char *normalize_env_assignment(const char *s); int wait_for_terminate(pid_t pid, siginfo_t *status); -- 2.30.2