From e736cf3582c03273f95bc6f97245b04783fd626b Mon Sep 17 00:00:00 2001 From: Dave Reisner Date: Mon, 29 Jul 2013 18:18:43 -0400 Subject: [PATCH] udev-rules: report rule parsing errors from get_key --- src/udev/udev-rules.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/udev/udev-rules.c b/src/udev/udev-rules.c index 769b670b2..e4facd7bd 100644 --- a/src/udev/udev-rules.c +++ b/src/udev/udev-rules.c @@ -1066,8 +1066,15 @@ static int add_rule(struct udev_rules *rules, char *line, char *value; enum operation_type op; - if (get_key(rules->udev, &linepos, &key, &op, &value) != 0) + if (get_key(rules->udev, &linepos, &key, &op, &value) != 0) { + /* If we aren't at the end of the line, this is a parsing error. + * Make a best effort to describe where the problem is. */ + if (*linepos != '\n') + log_error("invalid key/value pair in file %s on line %u," + "starting at character %lu\n", + filename, lineno, linepos - line + 1); break; + } if (streq(key, "ACTION")) { if (op > OP_MATCH_MAX) { -- 2.30.2