From c4731d1135d54609e33df1569fefbb0c96824896 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 5 Jan 2011 16:17:26 +0100 Subject: [PATCH] util: don't pass invalid fd to fdopendir() on error to avoid corruption of errno --- src/util.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/util.c b/src/util.c index 21afdceb8..aa1f19ed6 100644 --- a/src/util.c +++ b/src/util.c @@ -3436,7 +3436,18 @@ bool null_or_empty(struct stat *st) { } DIR *xopendirat(int fd, const char *name, int flags) { - return fdopendir(openat(fd, name, O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC|flags)); + int nfd; + DIR *d; + + if ((nfd = openat(fd, name, O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC|flags)) < 0) + return NULL; + + if (!(d = fdopendir(nfd))) { + close_nointr_nofail(nfd); + return NULL; + } + + return d; } int signal_from_string_try_harder(const char *s) { -- 2.30.2