From 8e64fd110d85de45929cefcbf83aa506d60f8795 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 19 Nov 2013 01:12:03 +0100 Subject: [PATCH] hwclock: modernizations --- src/shared/hwclock.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/shared/hwclock.c b/src/shared/hwclock.c index 60292a015..7059d9c75 100644 --- a/src/shared/hwclock.c +++ b/src/shared/hwclock.c @@ -44,8 +44,7 @@ #include "fileio.h" int hwclock_get_time(struct tm *tm) { - int fd; - int err = 0; + _cleanup_close_ int fd = -1; assert(tm); @@ -56,20 +55,17 @@ int hwclock_get_time(struct tm *tm) { /* This leaves the timezone fields of struct tm * uninitialized! */ if (ioctl(fd, RTC_RD_TIME, tm) < 0) - err = -errno; + return -errno; /* We don't know daylight saving, so we reset this in order not * to confuse mktime(). */ tm->tm_isdst = -1; - close_nointr_nofail(fd); - - return err; + return 0; } int hwclock_set_time(const struct tm *tm) { - int fd; - int err = 0; + _cleanup_close_ int fd = -1; assert(tm); @@ -78,11 +74,9 @@ int hwclock_set_time(const struct tm *tm) { return -errno; if (ioctl(fd, RTC_SET_TIME, tm) < 0) - err = -errno; - - close_nointr_nofail(fd); + return -errno; - return err; + return 0; } int hwclock_is_localtime(void) { -- 2.30.2