From 7e2668c6fd5720ae4d2d55eb8a062739687516af Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Thu, 3 May 2012 14:42:49 +0200 Subject: [PATCH] service: warn if a dbus name is specified but the service type is not dbus --- TODO | 4 ++++ src/core/service.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/TODO b/TODO index 22bcb3f93..0810f3770 100644 --- a/TODO +++ b/TODO @@ -23,6 +23,10 @@ Bugfixes: Features: +* don't delete /tmp/systemd-namespace-* before a process is gone down + +* don't delete /run/users/lennart if lennart is still logged in even if aging is used + * automount: implement expire * vconsole: implement setterm -store -foreground xxx --background zzz diff --git a/src/core/service.c b/src/core/service.c index 4358a948d..a99e1c377 100644 --- a/src/core/service.c +++ b/src/core/service.c @@ -1135,6 +1135,9 @@ static int service_verify(Service *s) { return -EINVAL; } + if (s->bus_name && s->type != SERVICE_DBUS) + log_warning("%s has a D-Bus service name specified, but is not of type dbus. Ignoring.", UNIT(s)->id); + if (s->exec_context.pam_name && s->exec_context.kill_mode != KILL_CONTROL_GROUP) { log_error("%s has PAM enabled. Kill mode must be set to 'control-group'. Refusing.", UNIT(s)->id); return -EINVAL; -- 2.30.2