From 5e071f200c4cc86443af07a876ee0e1c2901fda1 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Fri, 31 Oct 2014 09:31:02 -0400 Subject: [PATCH] bus: do not segfault on zeros in errno mapping table Depending on the link order, holes might appear in the body of the sd_bus_errnomap section. Ignore them. Adds a simple test to print the table to help with debugging such issues in the future. --- src/libsystemd/sd-bus/bus-error.c | 2 +- src/libsystemd/sd-bus/test-bus-error.c | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/libsystemd/sd-bus/bus-error.c b/src/libsystemd/sd-bus/bus-error.c index 2e64b925f..ad1a66da7 100644 --- a/src/libsystemd/sd-bus/bus-error.c +++ b/src/libsystemd/sd-bus/bus-error.c @@ -80,7 +80,7 @@ static int bus_error_mapping_lookup(const char *name, size_t len) { const sd_bus_name_error_mapping *m; for (m = __start_sd_bus_errnomap; m < __stop_sd_bus_errnomap; m++) - if (strneq(m->name, name, len)) + if (m->name && strneq(m->name, name, len)) return m->code; return EIO; diff --git a/src/libsystemd/sd-bus/test-bus-error.c b/src/libsystemd/sd-bus/test-bus-error.c index dd0cca4ab..aff34a90c 100644 --- a/src/libsystemd/sd-bus/test-bus-error.c +++ b/src/libsystemd/sd-bus/test-bus-error.c @@ -111,6 +111,18 @@ static void test_error(void) { assert_se(sd_bus_error_is_set(&error)); } +extern const sd_bus_name_error_mapping __start_sd_bus_errnomap[]; +extern const sd_bus_name_error_mapping __stop_sd_bus_errnomap[]; + +static void dump_mapping_table(void) { + const sd_bus_name_error_mapping *m; + + printf("----- errno mappings ------\n"); + for (m = __start_sd_bus_errnomap; m < __stop_sd_bus_errnomap; m++) + printf("%s -> %d\n", m->name, m->code); + printf("---------------------------\n"); +} + static void test_errno_mapping_standard(void) { assert_se(sd_bus_error_set(NULL, "System.Error.EUCLEAN", NULL) == -EUCLEAN); assert_se(sd_bus_error_set(NULL, "System.Error.EBUSY", NULL) == -EBUSY); @@ -130,6 +142,7 @@ static void test_errno_mapping_custom(void) { } int main(int argc, char *argv[]) { + dump_mapping_table(); test_error(); test_errno_mapping_standard(); -- 2.30.2