From 4d229b318af339c7a4711f3812335cb3ae6fb5aa Mon Sep 17 00:00:00 2001 From: Umut Tezduyar Lindskog Date: Tue, 8 Jul 2014 16:16:14 +0200 Subject: [PATCH] coredump: display libdw fail string on stack trace fail - systemd[1]: hello.service: main process exited, code= dumped, status=3/QUIT - systemd-coredump[2541]: Failed to generate stack trace: Unwinding not supported for this architecture - systemd-coredump[2541]: Process 1024 (hello) of user 154 dumped core. --- src/journal/coredump.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/journal/coredump.c b/src/journal/coredump.c index db51098d9..79f51d159 100644 --- a/src/journal/coredump.c +++ b/src/journal/coredump.c @@ -26,6 +26,11 @@ #include #include +#ifdef HAVE_ELFUTILS +# include +# include +#endif + #include "systemd/sd-journal.h" #include "systemd/sd-login.h" @@ -686,6 +691,8 @@ int main(int argc, char* argv[]) { r = coredump_make_stack_trace(coredump_fd, exe, &stacktrace); if (r >= 0) core_message = strjoin("MESSAGE=Process ", info[INFO_PID], " (", comm, ") of user ", info[INFO_UID], " dumped core.\n\n", stacktrace, NULL); + else if (r == -EINVAL) + log_warning("Failed to generate stack trace: %s", dwfl_errmsg(dwfl_errno())); else log_warning("Failed to generate stack trace: %s", strerror(-r)); } -- 2.30.2