From 2e6534a9a5ad5f02a37e7dca878c521f38df8456 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Mon, 16 Mar 2015 11:34:39 -0400 Subject: [PATCH] shared/mkdir: do not set errno in addition to return value All callers look at the return value anyway. --- src/shared/mkdir.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/shared/mkdir.c b/src/shared/mkdir.c index b280618a9..7ee454698 100644 --- a/src/shared/mkdir.c +++ b/src/shared/mkdir.c @@ -41,10 +41,8 @@ int mkdir_safe_internal(const char *path, mode_t mode, uid_t uid, gid_t gid, mkd (st.st_mode & 0700) > (mode & 0700) || (uid != UID_INVALID && st.st_uid != uid) || (gid != GID_INVALID && st.st_gid != gid) || - !S_ISDIR(st.st_mode)) { - errno = EEXIST; - return -errno; - } + !S_ISDIR(st.st_mode)) + return -EEXIST; return 0; } -- 2.30.2