From 226b735a745c1e9bbab24b47460d7304def9d38f Mon Sep 17 00:00:00 2001 From: Stefan Beller Date: Mon, 30 Dec 2013 00:09:56 +0100 Subject: [PATCH] bootchart: Remove unneeded check for NULL Directly before the changed line there is: while ((parent->next_ps && parent->pid != ps->ppid)) parent = parent->next_ps; which looks one element ahead of the list, hence we can rely on parent being non null here. If 'parent' were NULL at that while loop already, it would crash as we're dereferencing 'parent' when checking for next_ps already. Signed-off-by: Stefan Beller --- src/bootchart/store.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bootchart/store.c b/src/bootchart/store.c index 7f86cfe97..b6ba11356 100644 --- a/src/bootchart/store.c +++ b/src/bootchart/store.c @@ -345,7 +345,7 @@ schedstat_next: while ((parent->next_ps && parent->pid != ps->ppid)) parent = parent->next_ps; - if ((!parent) || (parent->pid != ps->ppid)) { + if (parent->pid != ps->ppid) { /* orphan */ ps->ppid = 1; parent = ps_first->next_ps; -- 2.30.2