From 0d95178e49eaf70fce9882d2a1277a9cd3555f34 Mon Sep 17 00:00:00 2001 From: Kay Sievers Date: Fri, 8 Nov 2013 18:50:58 +0100 Subject: [PATCH] systemctl: rename 'listen' MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit src/systemctl/systemctl.c: In function ‘get_listening’: src/systemctl/systemctl.c:535:25: warning: declaration of ‘listen’ shadows a global declaration [-Wshadow] src/systemctl/systemctl.c: In function ‘list_sockets’: src/systemctl/systemctl.c:690:44: warning: declaration of ‘listen’ shadows a global declaration [-Wshadow] --- .gitignore | 2 ++ src/systemctl/systemctl.c | 18 +++++++++--------- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/.gitignore b/.gitignore index dd6432c97..00d81ed3d 100644 --- a/.gitignore +++ b/.gitignore @@ -1,4 +1,6 @@ /Makefile +/defined +/undefined /TAGS /accelerometer /ata_id diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index c2f7836a5..7e9b6eacf 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -532,7 +532,7 @@ static int get_triggered_units( static int get_listening( sd_bus *bus, const char* unit_path, - char*** listen, + char*** listening, unsigned *c) { _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; @@ -560,11 +560,11 @@ static int get_listening( while ((r = sd_bus_message_read(reply, "(ss)", &type, &path)) > 0) { - r = strv_extend(listen, type); + r = strv_extend(listening, type); if (r < 0) return log_oom(); - r = strv_extend(listen, path); + r = strv_extend(listening, path); if (r < 0) return log_oom(); @@ -687,7 +687,7 @@ static int list_sockets(sd_bus *bus, char **args) { cu = (unsigned) r; for (u = unit_infos; u < unit_infos + cu; u++) { - _cleanup_strv_free_ char **listen = NULL, **triggered = NULL; + _cleanup_strv_free_ char **listening = NULL, **triggered = NULL; unsigned c = 0, i; if (!output_show_unit(u)) @@ -700,7 +700,7 @@ static int list_sockets(sd_bus *bus, char **args) { if (r < 0) goto cleanup; - r = get_listening(bus, u->unit_path, &listen, &c); + r = get_listening(bus, u->unit_path, &listening, &c); if (r < 0) goto cleanup; @@ -712,16 +712,16 @@ static int list_sockets(sd_bus *bus, char **args) { for (i = 0; i < c; i++) socket_infos[cs + i] = (struct socket_info) { .id = u->id, - .type = listen[i*2], - .path = listen[i*2 + 1], + .type = listening[i*2], + .path = listening[i*2 + 1], .triggered = triggered, .own_triggered = i==0, }; /* from this point on we will cleanup those socket_infos */ cs += c; - free(listen); - listen = triggered = NULL; /* avoid cleanup */ + free(listening); + listening = triggered = NULL; /* avoid cleanup */ } qsort_safe(socket_infos, cs, sizeof(struct socket_info), -- 2.30.2