From 04ade7d215ce05f1ac2bd33a8d6126f6994168fa Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Mon, 9 Aug 2010 17:02:09 +0200 Subject: [PATCH] dbus: don't call bus_path_escape() with NULL unit name Fixes an assertion triggerable via D-Bus. https://bugzilla.redhat.com/show_bug.cgi?id=622008 --- src/dbus-unit.c | 6 ++++++ src/unit.c | 3 +++ 2 files changed, 9 insertions(+) diff --git a/src/dbus-unit.c b/src/dbus-unit.c index d25f32501..c9ccac147 100644 --- a/src/dbus-unit.c +++ b/src/dbus-unit.c @@ -434,6 +434,9 @@ void bus_unit_send_change_signal(Unit *u) { u->meta.in_dbus_queue = false; } + if (!u->meta.id) + return; + if (!bus_has_subscriber(u->meta.manager)) { u->meta.sent_dbus_new_signal = true; return; @@ -491,6 +494,9 @@ void bus_unit_send_removed_signal(Unit *u) { if (!u->meta.sent_dbus_new_signal) bus_unit_send_change_signal(u); + if (!u->meta.id) + return; + if (!(p = unit_dbus_path(u))) goto oom; diff --git a/src/unit.c b/src/unit.c index 840c1d1fc..dd665e2d5 100644 --- a/src/unit.c +++ b/src/unit.c @@ -1551,6 +1551,9 @@ char *unit_dbus_path(Unit *u) { assert(u); + if (!u->meta.id) + return NULL; + if (!(e = bus_path_escape(u->meta.id))) return NULL; -- 2.30.2