chiark / gitweb /
6 years agoAdd language fallback map
Naveen Kumar [Sat, 31 Jan 2015 17:50:49 +0000 (12:50 -0500)]
Add language fallback map

This map will be used to provide a fallback for translations.
For example, a Niederdeutsch (nds) speaker prefers to fall back to
German (de) translations rather then the English (C) ones.

6 years agobuild-sys: remove reference to long gone file
Zbigniew Jędrzejewski-Szmek [Fri, 6 Feb 2015 14:12:27 +0000 (09:12 -0500)]
build-sys: remove reference to long gone file

Interesting that automake doesn't complain about this at all.
That file was removed in 3fb97a58fa3f233.

6 years agounits: networkd - fix busname to work on kdbus
Tom Gundersen [Fri, 6 Feb 2015 11:09:36 +0000 (12:09 +0100)]
units: networkd - fix busname to work on kdbus

6 years agosd-rtnl: don't fall over when receiving 0 bytes from the socket
Tom Gundersen [Fri, 6 Feb 2015 10:54:30 +0000 (11:54 +0100)]
sd-rtnl: don't fall over when receiving 0 bytes from the socket

causes EOF. Seems like a kernel bug. Ignoring it seems to work be the best we
can do for now...


6 years agosd-rtnl: fix creation of synthetic error replies
Tom Gundersen [Fri, 6 Feb 2015 10:49:07 +0000 (11:49 +0100)]
sd-rtnl: fix creation of synthetic error replies

6 years agoudev: net_setup - clarify reason for failure of persistent mac address policy
Tom Gundersen [Fri, 6 Feb 2015 07:36:17 +0000 (08:36 +0100)]
udev: net_setup - clarify reason for failure of persistent mac address policy

6 years agoshared/log: read /proc/cmdline only in daemons
Zbigniew Jędrzejewski-Szmek [Fri, 6 Feb 2015 00:44:13 +0000 (19:44 -0500)]
shared/log: read /proc/cmdline only in daemons

6 years agoupdate TODO
Lukas Nykryn [Thu, 5 Feb 2015 17:07:54 +0000 (18:07 +0100)]
update TODO

6 years agonetworkd: move the connection to the bus out of manager_new (again)
Tom Gundersen [Thu, 5 Feb 2015 17:00:16 +0000 (18:00 +0100)]
networkd: move the connection to the bus out of manager_new (again)

This would otherwise make the tests fail as we cannot grab the bus name.

6 years agonetworkd: gracefully handle failure to emit signals when dbus is not connected
Tom Gundersen [Thu, 5 Feb 2015 16:59:40 +0000 (17:59 +0100)]
networkd: gracefully handle failure to emit signals when dbus is not connected

When we get kdbus we don't need these hackse.

6 years agobus: sync with kdbus (ABI break)
David Herrmann [Wed, 4 Feb 2015 15:21:27 +0000 (16:21 +0100)]
bus: sync with kdbus (ABI break)

6 years agonetworkd: exit on idle
Tom Gundersen [Wed, 4 Feb 2015 14:00:20 +0000 (15:00 +0100)]
networkd: exit on idle

We will be woken up on rtnl or dbus activity, so let's just quit if some time has passed and that is the only thing that can happen.

Note that we will always stay around if we expect network activity (e.g. DHCP is enabled), as we are not restarted on that.

6 years agonetworkd: don't unlink state files on exit
Tom Gundersen [Wed, 4 Feb 2015 14:16:40 +0000 (15:16 +0100)]
networkd: don't unlink state files on exit

Only unlink state files on DELLINK. This allows sd-network to be used even when networkd is not running.

6 years agonetworkd: add basic dbus API
Tom Gundersen [Wed, 4 Feb 2015 10:44:37 +0000 (11:44 +0100)]
networkd: add basic dbus API

Only the very basics, more to come.

For now:

$ busctl tree org.freedesktop.network1

$ busctl introspect org.freedesktop.network1 /org/freedesktop/network1
NAME                                TYPE      SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.network1.Manager    interface -         -            -
.OperationalState                   property  s         "carrier" emits-change

$ busctl introspect org.freedesktop.network1 /org/freedesktop/network1/link/1
NAME                                TYPE      SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.network1.Link       interface -         -            -
.AdministrativeState                property  s         "unmanaged" emits-change
.OperationalState                   property  s         "carrier" emits-change

6 years agonetworkd: don't warn about missing links unnecessarily
Tom Gundersen [Wed, 4 Feb 2015 09:08:12 +0000 (10:08 +0100)]
networkd: don't warn about missing links unnecessarily

If we get a NEWLINK + NEWADDR between enumerating the links and enumerating the addresses, we
would get a warning that the link corresponding to the address does not exist. This is a false
warning as both the NEWLINK and NEWADDR would be processed after enumerating completed, so drop

6 years agonetworkd: log when finished enumerating links and addresses
Tom Gundersen [Wed, 4 Feb 2015 08:47:50 +0000 (09:47 +0100)]
networkd: log when finished enumerating links and addresses

6 years agosystemctl: unit_find_paths(): unify error handling in two code pathes
Ivan Shapovalov [Wed, 4 Feb 2015 22:57:00 +0000 (01:57 +0300)]
systemctl: unit_find_paths(): unify error handling in two code pathes

6 years agosystemctl: cat, edit: further polish error messages
Ivan Shapovalov [Wed, 4 Feb 2015 22:56:59 +0000 (01:56 +0300)]
systemctl: cat, edit: further polish error messages

6 years agosystemctl: cat: fix error handling
Ivan Shapovalov [Wed, 4 Feb 2015 22:56:58 +0000 (01:56 +0300)]
systemctl: cat: fix error handling

- correctly check for local vs. remote transport
- return after receiving error from expand_names()

6 years agosystemctl: cat, edit: improve unit load error reporting
Ivan Shapovalov [Wed, 4 Feb 2015 22:56:57 +0000 (01:56 +0300)]
systemctl: cat, edit: improve unit load error reporting

- report actual load error for units which could not be loaded
- make unit_find_paths() report all kinds of errors it encounters
  (for consistency)
- consistently handle not-found errors in cat() and edit()

6 years agohwdb: Bind "toolbox" buttons to the Windows key
Bastien Nocera [Wed, 4 Feb 2015 17:46:10 +0000 (18:46 +0100)]
hwdb: Bind "toolbox" buttons to the Windows key

One would expect pressing the button to go to an overview / show
applications mode, we thus map it to leftmeta, the Windows key.


6 years agobuild-sys: mark systemd-firstboot man page as conditional
Michael Biebl [Wed, 4 Feb 2015 20:31:26 +0000 (21:31 +0100)]
build-sys: mark systemd-firstboot man page as conditional

Rebuild accordingly.

6 years agotimesyncd: downgrade more log messages from LOG_INFO to LOG_DEBUG
Lennart Poettering [Wed, 4 Feb 2015 16:00:23 +0000 (17:00 +0100)]
timesyncd: downgrade more log messages from LOG_INFO to LOG_DEBUG

Let's make timesyncd less chatty.

6 years agoshared/capabilities: simplify assertions about bits
Zbigniew Jędrzejewski-Szmek [Wed, 4 Feb 2015 15:24:02 +0000 (10:24 -0500)]
shared/capabilities: simplify assertions about bits

The assert added in 7d328b5446 was wrong. Also update the comments
and make sure we don't try to shift by type size.

6 years agoshared/util: drop duplicate log2u64 function
Zbigniew Jędrzejewski-Szmek [Wed, 4 Feb 2015 14:39:36 +0000 (09:39 -0500)]
shared/util: drop duplicate log2u64 function

6 years agoman: fix diagrams in bootup(7)
Zbigniew Jędrzejewski-Szmek [Wed, 4 Feb 2015 14:35:37 +0000 (09:35 -0500)]
man: fix diagrams in bootup(7)

Fallout from 798d3a524e.

6 years agotimesyncd: reduce log chattiness a bit
Lennart Poettering [Wed, 4 Feb 2015 13:46:40 +0000 (14:46 +0100)]
timesyncd: reduce log chattiness a bit

Let's downgrade the statistics output from LOG_INFO to LOG_DEBUG.

6 years agonspawn: Allow module loading if CAP_SYS_MODULE is requested
Jay Faulkner [Wed, 4 Feb 2015 01:45:50 +0000 (17:45 -0800)]
nspawn: Allow module loading if CAP_SYS_MODULE is requested

nspawn containers currently block module loading in all cases, with
no option to disable it. This allows an admin, specifically setting
capability=CAP_SYS_MODULE or capability=all to load modules.

6 years agoshared/capability: don't be too frugal on space for caps
Tom Gundersen [Wed, 4 Feb 2015 08:23:24 +0000 (09:23 +0100)]
shared/capability: don't be too frugal on space for caps

We were dropping the most significant bit. Add an assert to make sure it does not happen again.

Fixes a bug introduced in 7d328b544621d4b1bec936dec612947ad8bfb65a.

6 years agoReindent man pages to 2ch
Zbigniew Jędrzejewski-Szmek [Wed, 4 Feb 2015 02:14:13 +0000 (21:14 -0500)]
Reindent man pages to 2ch

6 years agotmpfiles: fix compilation without acl support
Zbigniew Jędrzejewski-Szmek [Tue, 3 Feb 2015 01:28:39 +0000 (20:28 -0500)]
tmpfiles: fix compilation without acl support

6 years agocg_path_get_user_unit(): Did not correctly parse user-unit templates.
Luke Shumaker [Wed, 4 Feb 2015 01:07:37 +0000 (20:07 -0500)]
cg_path_get_user_unit(): Did not correctly parse user-unit templates.

It ran either skip_session() or skip_user_manager(), then ran skip_slices()
iff skip_session() ran.  It needs to run skip_slices() in either case.

Included is a test case demonstrating why.

6 years agocore: don't reset log level to NOTICE if we get quiet on the kernel cmdline
Lennart Poettering [Wed, 4 Feb 2015 00:42:49 +0000 (01:42 +0100)]
core: don't reset log level to NOTICE if we get quiet on the kernel cmdline

quiet should really just have an effect on the stuff we dump on the
console, not what we log elsewhere.


        debug on kernel cmdline → interpreted by every tool, turns up
        log levels to "debug" everywhere.

        quiet on kernel cmdline → interpreted only by PID 1 (and
        obviously the kernel) no alteration of the max log level, but
        turns off status output.

6 years agoupdate TODO
Lennart Poettering [Wed, 4 Feb 2015 00:42:46 +0000 (01:42 +0100)]
update TODO

6 years agovirt: add detect_vm_devicetree for powerpc arches
Chris J Arges [Tue, 3 Feb 2015 23:56:06 +0000 (17:56 -0600)]
virt: add detect_vm_devicetree for powerpc arches

Check sysfs devicetree values in order to detect if we are running on a KVM
hypervisor on a powerpc architecture.

6 years agonetworkd: refactor socket activation a bit
Tom Gundersen [Tue, 3 Feb 2015 14:44:50 +0000 (15:44 +0100)]
networkd: refactor socket activation a bit

6 years agosd-rtnl: allow sd_rtnl_open_fd() to be used on bound sockets
Tom Gundersen [Tue, 3 Feb 2015 20:33:04 +0000 (21:33 +0100)]
sd-rtnl: allow sd_rtnl_open_fd() to be used on bound sockets

6 years agonetworkd: handle suspend events
Tom Gundersen [Tue, 3 Feb 2015 14:44:12 +0000 (15:44 +0100)]
networkd: handle suspend events

6 years agopartial revert of fed6df8
Thomas Hindoe Paaboel Andersen [Tue, 3 Feb 2015 20:35:14 +0000 (21:35 +0100)]
partial revert of fed6df8

This one was acutally used to free xattr

6 years agocore: open up DefaultDependencies= property for transient units
Lennart Poettering [Tue, 3 Feb 2015 18:07:40 +0000 (19:07 +0100)]
core: open up DefaultDependencies= property for transient units

6 years agocore: busname_supported() should cache what it detects
Johannes Hölzl [Tue, 3 Feb 2015 17:53:31 +0000 (18:53 +0100)]
core: busname_supported() should cache what it detects

Add the missing "static" to actually make this a cache.

6 years agojournald: fix some xsprrintf() buffer size fallout
Lennart Poettering [Tue, 3 Feb 2015 17:17:00 +0000 (18:17 +0100)]
journald: fix some xsprrintf() buffer size fallout

6 years agocore: use some nice macros where appropriate
Lennart Poettering [Tue, 3 Feb 2015 17:16:35 +0000 (18:16 +0100)]
core: use some nice macros where appropriate

6 years agoupdate TODO
Lennart Poettering [Tue, 3 Feb 2015 17:16:17 +0000 (18:16 +0100)]
update TODO

6 years agoupdate TODO
Lennart Poettering [Tue, 3 Feb 2015 13:08:56 +0000 (14:08 +0100)]
update TODO

6 years agoloopback-setup: simplify code a bit
Lennart Poettering [Tue, 3 Feb 2015 12:53:01 +0000 (13:53 +0100)]
loopback-setup: simplify code a bit

6 years agoloopback-setup: no need to redefine LOOPBACK_IFINDEX, we already have it in missing.h
Lennart Poettering [Tue, 3 Feb 2015 12:48:15 +0000 (13:48 +0100)]
loopback-setup: no need to redefine LOOPBACK_IFINDEX, we already have it in missing.h

6 years agoupdate TODO
Lennart Poettering [Tue, 3 Feb 2015 10:46:25 +0000 (11:46 +0100)]
update TODO

6 years agotest-functions: search for the initrd and kernel according to the BLS
Harald Hoyer [Tue, 3 Feb 2015 09:43:24 +0000 (10:43 +0100)]
test-functions: search for the initrd and kernel according to the BLS

Also search for the initrd and kernel according to the boot loader

6 years agotest-functions: use sfdisk without cyl,head,sectors
Harald Hoyer [Tue, 3 Feb 2015 09:44:27 +0000 (10:44 +0100)]
test-functions: use sfdisk without cyl,head,sectors

newer sfdisk implementations do not work with these anymore

6 years agotest-functions:install_libnss() call dracut_install with all $NSS_LIBS
Harald Hoyer [Tue, 3 Feb 2015 09:45:25 +0000 (10:45 +0100)]
test-functions:install_libnss() call dracut_install with all $NSS_LIBS

dracut_install() can cope with more than one file

6 years agotests: install ldconfig.real for Debian based distros
Martin Pitt [Sun, 1 Feb 2015 23:19:33 +0000 (00:19 +0100)]
tests: install ldconfig.real for Debian based distros

In Debian based distributions ldconfig is just a shell wrapper around
ldconfig.real, for deferring it during package installation.

6 years agotests: install hostname debug tool
Martin Pitt [Sun, 1 Feb 2015 23:19:32 +0000 (00:19 +0100)]
tests: install hostname debug tool

This is mostly a vehicle to pull in which gets dlopen()ed by NSS
under certain NSS configurations.

6 years agotests: install all required libnss modules
Martin Pitt [Sun, 1 Feb 2015 23:19:31 +0000 (00:19 +0100)]
tests: install all required libnss modules

Don't assume "files" for everything in nsswitch. Instead, ask "getent passwd"
about which libnss modules it dlopen()s, and install these.

6 years agotests: don't hardcode systemctl path
Martin Pitt [Sun, 1 Feb 2015 23:19:30 +0000 (00:19 +0100)]
tests: don't hardcode systemctl path

Get it from type -P instead, to support --enable-split-usr.

6 years agotests: determine rootlibdir from pkg-config
Martin Pitt [Sun, 1 Feb 2015 23:19:29 +0000 (00:19 +0100)]
tests: determine rootlibdir from pkg-config

Prefer asking pkg-config for the rootlibdir, to also support systems with
--enable-split-usr. Fall back to the hardcoded /usr/lib/systemd if that fails.

6 years agotests: Make sushell optional in image creation
Martin Pitt [Sun, 1 Feb 2015 23:19:28 +0000 (00:19 +0100)]
tests: Make sushell optional in image creation

sushell does not exist in all distributions, and it can be changed with
configure --with-debug-shell, so make installation of it optional.

6 years agobuild-sys: distribute systemd-networkd.socket
Zbigniew Jędrzejewski-Szmek [Tue, 3 Feb 2015 03:59:22 +0000 (22:59 -0500)]
build-sys: distribute systemd-networkd.socket

6 years agonetwork-address,test-network: avoid undefined behaviour
Zbigniew Jędrzejewski-Szmek [Tue, 3 Feb 2015 02:32:28 +0000 (21:32 -0500)]
network-address,test-network: avoid undefined behaviour

6 years agoshared/async: simplify asynchronous_job a bit
Zbigniew Jędrzejewski-Szmek [Mon, 2 Feb 2015 19:51:31 +0000 (14:51 -0500)]
shared/async: simplify asynchronous_job a bit

6 years agotest-dhcp-client: add a kludge to make valgrind happy
Zbigniew Jędrzejewski-Szmek [Mon, 2 Feb 2015 19:50:56 +0000 (14:50 -0500)]
test-dhcp-client: add a kludge to make valgrind happy

6 years agotest-dhcp-client: open a real udp socket for test execution
Zbigniew Jędrzejewski-Szmek [Mon, 2 Feb 2015 19:46:40 +0000 (14:46 -0500)]
test-dhcp-client: open a real udp socket for test execution

./test-dhcp-client would attempt to operate fd 0, i.e. stdin.
For example, './test-dhcp-client </dev/null' would fail with EPERM
because /dev/null cannot be used with epoll.

6 years agoupdate TODO
Lennart Poettering [Tue, 3 Feb 2015 01:07:59 +0000 (02:07 +0100)]
update TODO

6 years agoutil: rework strappenda(), and rename it strjoina()
Lennart Poettering [Tue, 3 Feb 2015 01:05:59 +0000 (02:05 +0100)]
util: rework strappenda(), and rename it strjoina()

After all it is now much more like strjoin() than strappend(). At the
same time, add support for NULL sentinels, even if they are normally not

6 years agonetworkd: minor simplification
Lennart Poettering [Mon, 2 Feb 2015 22:21:20 +0000 (23:21 +0100)]
networkd: minor simplification

Let's return the fd we found as return value in systemd_netlink_fd(),
instead of using call-by-reference.

6 years agoremove unused variables
Thomas Hindoe Paaboel Andersen [Mon, 2 Feb 2015 21:56:44 +0000 (22:56 +0100)]
remove unused variables

6 years agoupdate TODO
Lennart Poettering [Mon, 2 Feb 2015 20:54:23 +0000 (21:54 +0100)]
update TODO

6 years agounits: so far we defaulted to 90s as default timeout for most things, let's do so...
Lennart Poettering [Mon, 2 Feb 2015 20:34:32 +0000 (21:34 +0100)]
units: so far we defaulted to 90s as default timeout for most things, let's do so for our oneshot services too

Fewer surprises, and stuff...

6 years agotmpfiles: let's always use DEFINE_PRIVATE_STRING_TABLE_LOOKUP_TO_STRING() instead...
Lennart Poettering [Mon, 2 Feb 2015 20:34:09 +0000 (21:34 +0100)]
tmpfiles: let's always use DEFINE_PRIVATE_STRING_TABLE_LOOKUP_TO_STRING() instead of defining our own string tables

6 years agotime-util: let's make xstrftime() useful for everybody, even if we only have a single...
Lennart Poettering [Mon, 2 Feb 2015 20:28:33 +0000 (21:28 +0100)]
time-util: let's make xstrftime() useful for everybody, even if we only have a single user so far.

6 years agomacro: document that DECIMAL_STR_MAX contains space for the trailing NUL byte
Lennart Poettering [Mon, 2 Feb 2015 20:28:19 +0000 (21:28 +0100)]
macro: document that DECIMAL_STR_MAX contains space for the trailing NUL byte

6 years agobootchart: Ensure that systemd is the init called after using bootchart
Sebastien Bacher [Mon, 2 Feb 2015 14:48:40 +0000 (15:48 +0100)]
bootchart: Ensure that systemd is the init called after using bootchart

When booting with systemd-bootchart, default to call the systemd binary
rather than the init binary on disk, which might be another init system.
Collecting data only works with booting systemd.

6 years agobacklight: let udev properties override clamping
Topi Miettinen [Sun, 1 Feb 2015 06:49:02 +0000 (08:49 +0200)]
backlight: let udev properties override clamping

On my computer, the minimum brightness enforced by clamping in
backlight is too bright.

Let udev property ID_BACKLIGHT_CLAMP control whether the brightness
is clamped or not.

6 years agocryptsetup: only warn on real key files
Martin Pitt [Mon, 2 Feb 2015 15:53:39 +0000 (16:53 +0100)]
cryptsetup: only warn on real key files

Simplify the check from commit 05f73ad to only apply the warning to regular
files instead of enumerating device nodes.

6 years agotmpfiles: Remove unnecessary blank line when configured with "--disable-resolved"
Sangjung Woo [Mon, 2 Feb 2015 11:25:02 +0000 (20:25 +0900)]
tmpfiles: Remove unnecessary blank line when configured with "--disable-resolved"

This patch removes unnecessary blank line in
/usr/lib/tmpfiles.d/etc.conf when configured with "--disable-resolved".
(i.e. ENABLE_RESOLVED is not defined)

6 years agoupdate TODO
Lennart Poettering [Mon, 2 Feb 2015 15:43:00 +0000 (16:43 +0100)]
update TODO

6 years agocryptsetup: Do not warn If the key is /dev/*random
Cristian Rodríguez [Mon, 2 Feb 2015 15:06:05 +0000 (12:06 -0300)]
cryptsetup: Do not warn If the key is /dev/*random

Using /dev/urandom as a key is valid for swap, do not
warn if this devices are world readable.

6 years agonetworkd: support socket activation
Tom Gundersen [Sun, 1 Feb 2015 21:13:26 +0000 (22:13 +0100)]
networkd: support socket activation

Still keep the non-socket activation code around for starting from the commandline, but
will likely drop that too in the future.

6 years agosd-rtnl: introduce sd_rtnl_new_from_netlink
Tom Gundersen [Sun, 1 Feb 2015 21:12:33 +0000 (22:12 +0100)]
sd-rtnl: introduce sd_rtnl_new_from_netlink

6 years agonetworkd-wait-online: add timeout
Tom Gundersen [Sun, 1 Feb 2015 20:04:35 +0000 (21:04 +0100)]
networkd-wait-online: add timeout

Default to timing out after 120 seconds without a network connection. Setting a
timeout of 0 disables the timeout.

6 years agosd-event: treat NULL callback for timer events like sig events
Tom Gundersen [Sun, 1 Feb 2015 17:06:40 +0000 (18:06 +0100)]
sd-event: treat NULL callback for timer events like sig events

In both cases exit the event loop.

6 years agonetworkd-wait-online: support globbing for ignored devices
Tom Gundersen [Sun, 1 Feb 2015 14:13:17 +0000 (15:13 +0100)]
networkd-wait-online: support globbing for ignored devices

6 years agohwdb: Update database of Bluetooth company identifiers
Marcel Holtmann [Mon, 2 Feb 2015 08:18:28 +0000 (09:18 +0100)]
hwdb: Update database of Bluetooth company identifiers

6 years agoman: switch yum to dnf for Fedora
Zbigniew Jędrzejewski-Szmek [Sun, 1 Feb 2015 21:05:56 +0000 (16:05 -0500)]
man: switch yum to dnf for Fedora

The dnf name is here to stay, we might as well adjust.

6 years agoshared/capability: go frugal on space for caps
Zbigniew Jędrzejewski-Szmek [Sun, 1 Feb 2015 20:26:46 +0000 (15:26 -0500)]
shared/capability: go frugal on space for caps

6 years agoFix dropping of all capabilities
Zbigniew Jędrzejewski-Szmek [Sun, 1 Feb 2015 19:33:10 +0000 (14:33 -0500)]
Fix dropping of all capabilities

From fd.o bug 88898:

systemd-resolved fails to start:
Failed to drop capabilities: Operation not permitted

Broken in f11943c53ec181829a821c6b27acf828bab71caa.

Drop all capabilities:
1. prctl(PR_SET_KEEPCAPS, keep_capabilities != 0) // 0 when we drop all
2. setresuid() // bye bye capabilities
3. Add CAP_SETPCAP // fails because we have no capabilities
4. Reduce capability bounding set
5. Drop capabilities
6. prctl(PR_SET_KEEPCAPS, 0)

Capabilites should always be kept after setresuid() so that the capability
bounding set can be reduced.


We must be careful not to leave PR_SET_KEEPCAPS on. We could use the
setresuid() call to drop capabilities, but the rules when capabilities
are dropped are fairly complex, since a transition to non-zero uid must
happen. Let's instead keep the capabilities during setresuid(), and drop
them later.

6 years agoconfig_parse_set_status: put signals in the correct set
Michael Olbrich [Fri, 30 Jan 2015 08:49:55 +0000 (09:49 +0100)]
config_parse_set_status: put signals in the correct set

This was broken when the code was rearranged in "1e2fd62d70ff
core/load-fragment.c: correct argument sign and split up long lines"

6 years agoAdd a snprinf wrapper which checks that the buffer was big enough
Zbigniew Jędrzejewski-Szmek [Tue, 27 Jan 2015 13:00:11 +0000 (08:00 -0500)]
Add a snprinf wrapper which checks that the buffer was big enough

If we scale our buffer to be wide enough for the format string, we
should expect that the calculation was correct.

char_array_0() invocations are removed, since snprintf nul-terminates
the output in any case.

A similar wrapper is used for strftime calls, but only in timedatectl.c.

6 years agotmpfiles: accurately report creation results
Zbigniew Jędrzejewski-Szmek [Sun, 1 Feb 2015 17:29:27 +0000 (12:29 -0500)]
tmpfiles: accurately report creation results

6 years agotmpfiles: remove dead branch
Zbigniew Jędrzejewski-Szmek [Sat, 31 Jan 2015 06:03:09 +0000 (01:03 -0500)]
tmpfiles: remove dead branch

In the test, p is a path to a directory, always absolute. dent->d_name
is a single path component, so they cannot be equal. The comparison
was wrong also for other reasons: D type supports globs, so direct
comparisons using streq are not enough.

6 years agounits: set TimeoutSec on some oneshot services
Zbigniew Jędrzejewski-Szmek [Sat, 31 Jan 2015 04:54:21 +0000 (23:54 -0500)]
units: set TimeoutSec on some oneshot services

Services which are not crucial to system bootup, and have Type=oneshot
can effectively "hang" the system if they fail to complete for whatever
reason. To allow the boot to continue, kill them after a timeout.

In case of systemd-journal-flush the flush will continue in the background,
and in the other two cases the job will be aborted, but this should not
result in any permanent problem.

6 years agocore/cgroup: fix embarrassing typo
Zbigniew Jędrzejewski-Szmek [Sun, 1 Feb 2015 04:03:25 +0000 (23:03 -0500)]
core/cgroup: fix embarrassing typo

6 years agotest-dhcp-client: remove linebreak
Zbigniew Jędrzejewski-Szmek [Sat, 31 Jan 2015 17:25:12 +0000 (12:25 -0500)]
test-dhcp-client: remove linebreak

6 years agoTODO
Tom Gundersen [Sat, 31 Jan 2015 14:27:49 +0000 (15:27 +0100)]

6 years agonetworkd: dhcp-server - start as soon as addresses have been set
Tom Gundersen [Fri, 30 Jan 2015 18:54:01 +0000 (19:54 +0100)]
networkd: dhcp-server - start as soon as addresses have been set

We would otherwise wait for the interface to be completely configured, which
could take considerable time with IPv4LL. As a result nspawn was very slow
at obtaining IP addresses.

6 years agonetworkd-wait-online: allow specific devices to be ignored
Tom Gundersen [Thu, 29 Jan 2015 06:34:34 +0000 (07:34 +0100)]
networkd-wait-online: allow specific devices to be ignored

In addition to the loopback device, also explicitly configured devices to be ignored.

Suggested by Charles Devereaux <>.

6 years agosd-rtnl: don't fail event handler when callback fails
Tom Gundersen [Thu, 29 Jan 2015 06:26:58 +0000 (07:26 +0100)]
sd-rtnl: don't fail event handler when callback fails

As in sd-bus, simply log at debug level when a callback fails, but don't fail the event handler.
Otherwise any error returned by any callback will disable the rtnl event handler. We should
only do that on serious internal errors in sd-rtnl that we know cannot be recovered from.

6 years agocore: make setting the shutdown watchdog configuration via dbus work
Maxim Mikityanskiy [Thu, 29 Jan 2015 00:23:07 +0000 (01:23 +0100)]
core: make setting the shutdown watchdog configuration via dbus work

6 years agoRevert "sd-bus: change serialization of kdbus messages to qualify in their entirety...
Kay Sievers [Fri, 30 Jan 2015 12:53:45 +0000 (13:53 +0100)]
Revert "sd-bus: change serialization of kdbus messages to qualify in their entirety as gvariant objects"

This breaks booting with kdbus.

This reverts commit b381de4197157748ed96e469fcc372c23f842ae1.

6 years agoRevert "core: make setting the shutdown watchdog configuration via dbus work"
Kay Sievers [Fri, 30 Jan 2015 09:59:47 +0000 (10:59 +0100)]
Revert "core: make setting the shutdown watchdog configuration via dbus work"

This reverts commit df6e44c4affced590b0d19c594d9301ffd436591.

systemd --version segfaults.

Starting program: /usr/lib/systemd/systemd --version
Missing separate debuginfos, use: debuginfo-install systemd-216-16.fc21.x86_64
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/".
systemd 218

Program received signal SIGSEGV, Segmentation fault.
0x000055555557c9be in main (argc=2, argv=0x7fffffffe4d8) at src/core/main.c:1832
1832            arg_shutdown_watchdog = m->shutdown_watchdog;
(gdb) bt
(gdb) bt full
        m = 0x0