chiark / gitweb /
6 years agopo: update Polish translation
Piotr Drąg [Fri, 26 Dec 2014 00:05:29 +0000 (01:05 +0100)]
po: update Polish translation

6 years agomachined: fix grammar in
Piotr Drąg [Thu, 25 Dec 2014 23:55:26 +0000 (00:55 +0100)]
machined: fix grammar in

[zj: change "in into" to "into".]

6 years agobuild-sys: fix build issue with
Philippe De Swert [Wed, 31 Dec 2014 16:02:12 +0000 (18:02 +0200)]
build-sys: fix build issue with

When doing "make clean" the unit/ file gets deleted.
This causes a build error later on when trying to rebuild systemd.

V2: The file probably belongs to dist_systemunit_DATA

6 years agoman: Clarify effect when both calendar day and date are listed in timer
Chris Atkinson [Thu, 1 Jan 2015 02:59:16 +0000 (21:59 -0500)]
man: Clarify effect when both calendar day and date are listed in timer

See bug 87859 ( Bug
reporter found the language describing the effect of specifying both a
day and date unclear; hopefully the attached patch will clarify and
allow the bug to be closed.

6 years agolldp: fix sd_lldp_save()
David Herrmann [Wed, 31 Dec 2014 15:28:48 +0000 (16:28 +0100)]
lldp: fix sd_lldp_save()

Fix a bunch of needless memzero() calls, a bunch of use-after-free
regarding _cleanup_free_ and drop unused variables.

Hint: Do NOT use _cleanup_free_ for temporary strappend() helpers that are
freed multiple times. All you safe is the last free() call, which is
really not worth the trouble resetting it to NULL all the time.

6 years agolldp: fix uninitialized cleanup var #2
David Herrmann [Wed, 31 Dec 2014 15:07:17 +0000 (16:07 +0100)]
lldp: fix uninitialized cleanup var #2

Another uninitialized variable marked as _cleanup_. Set it to NULL to
avoid accessing uninitialized memory.

6 years agolldp: fix uninitialized cleanup var
David Herrmann [Wed, 31 Dec 2014 15:04:55 +0000 (16:04 +0100)]
lldp: fix uninitialized cleanup var

Make sure to set _cleanup_ variables to NULL. Otherwise, we free
uninitialized objects.

6 years agoimport: fix mem-leak in CurlGlue
David Herrmann [Wed, 31 Dec 2014 15:01:37 +0000 (16:01 +0100)]
import: fix mem-leak in CurlGlue

Make sure to actually free the underlying object in CurlGlue unref.

6 years agolldp: fix double free
David Herrmann [Wed, 31 Dec 2014 14:58:27 +0000 (15:58 +0100)]
lldp: fix double free

'k' is marked as _cleanup_free_ so reset it to NULL if we free it

6 years agonetworkctl: fix strappend() error checking
David Herrmann [Wed, 31 Dec 2014 14:56:11 +0000 (15:56 +0100)]
networkctl: fix strappend() error checking

Make sure to test the right variable for NULL.

6 years agonetwork: add malloc-assertion in test
David Herrmann [Wed, 31 Dec 2014 14:54:20 +0000 (15:54 +0100)]
network: add malloc-assertion in test

Make sure malloc() really returns non-NULL in lldp test.

6 years agomachinectl: remove dead code
David Herrmann [Wed, 31 Dec 2014 14:52:23 +0000 (15:52 +0100)]
machinectl: remove dead code

'r' is not touched after the previous error-checking 100 lines above. Drop
that code.

6 years agohwdb: mouse DPI data, Logitech USB Laser Mouse M-U0011-O
Christoph Brill [Wed, 31 Dec 2014 13:28:52 +0000 (08:28 -0500)]
hwdb: mouse DPI data, Logitech USB Laser Mouse M-U0011-O

6 years agoRevert commit f131770b "tree-wide: spelling fixes"
David Herrmann [Wed, 31 Dec 2014 12:34:21 +0000 (13:34 +0100)]
Revert commit f131770b "tree-wide: spelling fixes"

This partially reverts:

    commit f131770b1465fbf423881f16ba85523a05f846fe
    Author: Veres Lajos <>
    Date:   Mon Dec 29 09:45:58 2014 +0000

        tree-wide: spelling fixes

The commit in question changed a binary file. I didn't look at the diff in
particular, so I have no idea what exactly was changed. However, the file
is generated and it looked highly suspiciuous. Therefore, I reverted that

Note that this is generated by "make update-unifont" so really no reason
to touch at all.

6 years agotree-wide: spelling fixes
Veres Lajos [Mon, 29 Dec 2014 09:45:58 +0000 (09:45 +0000)]
tree-wide: spelling fixes
Thanks to Torstein Husebo <>.

6 years agoaccelerometer: display short options too
Robert Milasan [Tue, 30 Dec 2014 17:58:29 +0000 (18:58 +0100)]
accelerometer: display short options too

6 years agohwdb: mouse DPI data, Logitech M-UAS144
Christoph Brill [Wed, 31 Dec 2014 00:07:28 +0000 (19:07 -0500)]
hwdb: mouse DPI data, Logitech M-UAS144

6 years agohwdb: mouse DPI data, Fujitsu Siemens OEM
Christoph Brill [Wed, 31 Dec 2014 00:03:39 +0000 (19:03 -0500)]
hwdb: mouse DPI data, Fujitsu Siemens OEM

6 years agohwdb: mouse DPI data, Logitech MK260 aka M-R0011
Christoph Brill [Tue, 30 Dec 2014 23:56:16 +0000 (18:56 -0500)]
hwdb: mouse DPI data, Logitech MK260 aka M-R0011

6 years agohwdb: mouse DPI data, Chicony 2.4G Multimedia Wireless Kit
Christoph Brill [Tue, 30 Dec 2014 23:54:24 +0000 (18:54 -0500)]
hwdb: mouse DPI data, Chicony 2.4G Multimedia Wireless Kit

6 years agosystemctl: do not repeat hibernate/sleep attempts
Zbigniew Jędrzejewski-Szmek [Tue, 30 Dec 2014 23:38:21 +0000 (18:38 -0500)]
systemctl: do not repeat hibernate/sleep attempts

If some sleep operation was not possible (e.g. because swap is missing),
we would try twice: once through logind, which would result in a clean error:
  Failed to execute operation: Sleep verb not supported
and then second time by starting the appropriate unit directly, which is
more messy. If logind tells us that something is not possible (or already
in progress), report that to the user and quit. If logind is present and working
we should not try to work around it.

Loosely based on

6 years agobus: replace ENOSYS return codes with EBADR/ENOTSUP
Zbigniew Jędrzejewski-Szmek [Tue, 30 Dec 2014 23:22:53 +0000 (18:22 -0500)]
bus: replace ENOSYS return codes with EBADR/ENOTSUP

ENOSYS is used to signify compiled-out functionality. Using it for
different kinds of error is misleading.

already, so changing it to ENOTSUP makes the dbus and action paths
behave the same.

Zbigniew Jędrzejewski-Szmek [Tue, 30 Dec 2014 14:57:01 +0000 (09:57 -0500)]

6 years agoaccelerometer: drop unused -x option
Robert Milasan [Tue, 30 Dec 2014 17:58:05 +0000 (18:58 +0100)]
accelerometer: drop unused -x option

6 years agoman: Fix spelling
Susant Sahani [Tue, 30 Dec 2014 16:41:38 +0000 (22:11 +0530)]
man: Fix spelling

6 years agobus: add sd_bus_emit_object_{added/removed}()
David Herrmann [Tue, 30 Dec 2014 10:37:35 +0000 (11:37 +0100)]
bus: add sd_bus_emit_object_{added/removed}()

This implements two new helpers, discussed on systemd-devel about 1 year

Both calls are equivalent to their respective counterpart
sd_bus_emit_interfaces_{added/removed}(), but can figure out the list of
interfaces themselves, instead of requiring the caller to provide them.
Furthermore, both calls properly deal with builtin interfaces provided via
org.freedesktop.DBus.* and alike.

Both calls simply traverse a node and all its parent nodes to figure out a
list of all interfaces registered as vtable or fallback. It then appends
each of them, similar to the interfaces_{added/removed}() helpers.

Note that interfaces_{added/removed}() runs a parent traversal for *each*
passed interface. Therefore, it can simply bail out, once it found a
parent node that implements a given interface.
With object_{added/removed}() we cannot know the registered interfaces in
advance, thus, we cannot run one traversal per node. Instead, we run a
single traversal and remember all interfaces that we added. Therefore, a
child-interface overrides all conflicting parent-interfaces. We keep a
"Set *s" context to track those while climbing up the tree.

6 years agobus: fix capabilities on big-endian
David Herrmann [Tue, 30 Dec 2014 08:09:41 +0000 (09:09 +0100)]
bus: fix capabilities on big-endian

The kernel provides capabilities as a u32 array, sd-bus uses an u8 array.
This works fine on little-endian as both are encoded the same way.
However, this fails on big-endian if we do not perform sufficient
byte-swapping on each u32 entry.

This patch makes sd-bus use u32, too. We avoid changing any kernel
provided data so we can keep pointing into kdbus pool buffers which
contain u32 arrays.

6 years agobus: drop creds->capability_size
David Herrmann [Tue, 30 Dec 2014 07:42:53 +0000 (08:42 +0100)]
bus: drop creds->capability_size

The number of available caps can be read from
/proc/sys/kernel/cap_last_cap during runtime. Our helper cap_last_cap()
does that, so there's no reason to remember the size of any capability
cache. We can just pre-allocate arrays with a suitable size for all
available caps and reject any higher caps.

The kernel capability API uses u32 as base so make sure we do the same.
Note that this is specified by POSIX, so it's unlikely to change.

6 years agomacro: add DIV_ROUND_UP()
David Herrmann [Mon, 29 Dec 2014 16:51:36 +0000 (17:51 +0100)]
macro: add DIV_ROUND_UP()

This macro calculates A / B but rounds up instead of down. We explicitly
do *NOT* use:
        (A + B - 1) / A
as it suffers from an integer overflow, even though the passed values are
properly tested against overflow. Our test-cases show this behavior.

Instead, we use:
        A / B + !!(A % B)

Note that on "Real CPUs" this does *NOT* result in two divisions. Instead,
instructions like idivl@x86 provide both, the quotient and the remainder.
Therefore, both algorithms should perform equally well (I didn't verify
this, though).

6 years agohwdb: Update database of Bluetooth company identifiers
Marcel Holtmann [Mon, 29 Dec 2014 19:47:04 +0000 (20:47 +0100)]
hwdb: Update database of Bluetooth company identifiers

6 years agoupdate TODO
Lennart Poettering [Mon, 29 Dec 2014 19:18:04 +0000 (20:18 +0100)]
update TODO

6 years agoRevert "machined: don't force terminate registered machines"
Lennart Poettering [Mon, 29 Dec 2014 19:00:01 +0000 (20:00 +0100)]
Revert "machined: don't force terminate registered machines"

This reverts commit 206e7a5f7b55ac61188efd895e65ab26e478cbb2.

We actually want to allow shutting down containers that use
RegisterMachine() rather than CreateMachine() to register their own
unit. It should be safe to do so, since the primary usecase for
RegisterMachine() are container managers that run only a single
container within their own unit, such as systemd-nspawn.

6 years agomachined: ignore spurious error
Lennart Poettering [Mon, 29 Dec 2014 18:08:50 +0000 (19:08 +0100)]
machined: ignore spurious error

6 years agonspawn: report back to systemd only very late whether we are OK
Lennart Poettering [Mon, 29 Dec 2014 16:54:04 +0000 (17:54 +0100)]
nspawn: report back to systemd only very late whether we are OK

That way, systemd can actually figure out if everything is OK with

6 years agopreset: enable by default
Lennart Poettering [Mon, 29 Dec 2014 16:36:57 +0000 (17:36 +0100)]
preset: enable by default

6 years agoUpdate TODO
Lennart Poettering [Mon, 29 Dec 2014 13:06:25 +0000 (14:06 +0100)]
Update TODO

6 years agomachinectl: add "enable" and "disable" verbs for enabling/disabling systemd-nspawn...
Lennart Poettering [Mon, 29 Dec 2014 13:05:17 +0000 (14:05 +0100)]
machinectl: add "enable" and "disable" verbs for enabling/disabling systemd-nspawn for containers

This is basically just a shortcut for "systemctl enable
systemd-nspawn@<foobar>.service", but does escaping.

6 years agomachinectl: add new "start" verb to start a container as a service in nspawn
Lennart Poettering [Mon, 29 Dec 2014 11:41:26 +0000 (12:41 +0100)]
machinectl: add new "start" verb to start a container as a service in nspawn

6 years agounits: rework systemd-nspawn@.service unit
Lennart Poettering [Mon, 29 Dec 2014 11:38:26 +0000 (12:38 +0100)]
units: rework systemd-nspawn@.service unit

- Unescape instance name so that we can take almost anything as instance

- Introduce "" which consists of all enabled nspawns and
  can be used to start/stop them altogether

- Look for container directory using -M instead of harcoding the path in

6 years agounits: make dependencies more complete and similar to those of multi...
Lennart Poettering [Mon, 29 Dec 2014 11:34:50 +0000 (12:34 +0100)]
units: make dependencies more complete and similar to those of

6 years agobus-proxy: fix sd_bus_reply_*() usage
David Herrmann [Mon, 29 Dec 2014 14:43:57 +0000 (15:43 +0100)]
bus-proxy: fix sd_bus_reply_*() usage

We *must* not use sd_bus_reply_*() as it does not set the sender field
correctly. Use the synthetic_reply_*() helpers instead!

6 years agocapability: use /proc/sys/kernel/cap_last_cap
David Herrmann [Mon, 29 Dec 2014 12:24:35 +0000 (13:24 +0100)]
capability: use /proc/sys/kernel/cap_last_cap

This file was introduced with linux-3.2, use it instead of probing for it
via prctl(PR_CAPBSET_READ).

For now, keep the old code for backwards compat. We can drop it once 3.2
is our lowest requirement.

The test-cap-list code is extended to verify cap_last_cap() is the same as
we'd get via prctl probing and /proc.

6 years agocore: loopback - correctly fail the loopback_check if somehow the rtnl calls fail
Tom Gundersen [Mon, 29 Dec 2014 12:05:45 +0000 (13:05 +0100)]
core: loopback - correctly fail the loopback_check if somehow the rtnl calls fail

6 years agobus: fix typo
David Herrmann [Tue, 23 Dec 2014 16:10:54 +0000 (17:10 +0100)]
bus: fix typo

Drop spurious 'we'.

6 years agortnl: recv_message - don't enforce sender uid
Tom Gundersen [Mon, 29 Dec 2014 01:18:21 +0000 (02:18 +0100)]
rtnl: recv_message - don't enforce sender uid

All we care about is that the kernel (pid==0) sent the message. Verifying the sender uid
seems to break when using userns.

Reported by Stéphane Graber.

6 years agotest: loopback - parse logging env var
Tom Gundersen [Mon, 29 Dec 2014 00:58:25 +0000 (01:58 +0100)]
test: loopback - parse logging env var

6 years agosd-rtnl: rtnl_call - don't dispatch wqueue after timeout has passed
Tom Gundersen [Mon, 29 Dec 2014 00:54:04 +0000 (01:54 +0100)]
sd-rtnl: rtnl_call - don't dispatch wqueue after timeout has passed

Only a minor change as the timeout would be hit soon thereafetr at the next loop.

6 years agosd-rtnl: rtnl_poll - fix typo
Tom Gundersen [Mon, 29 Dec 2014 00:50:07 +0000 (01:50 +0100)]
sd-rtnl: rtnl_poll - fix typo

This caused rtnl_poll to always return true immediately in sd_rtnl_call().

6 years agosd-rtnl: recv_message - drop message when peeking fails
Tom Gundersen [Sun, 28 Dec 2014 23:24:00 +0000 (00:24 +0100)]
sd-rtnl: recv_message - drop message when peeking fails

Read the message form the socket or we will loop trying to read the
same message repeatedly.

6 years agosd-rtnl: recv_message - don't fail on interrupt
Tom Gundersen [Mon, 29 Dec 2014 00:49:06 +0000 (01:49 +0100)]
sd-rtnl: recv_message - don't fail on interrupt

We should just try again instead.

6 years agosd-rtnl: recv_message - log when dropping message
Tom Gundersen [Sun, 28 Dec 2014 23:19:36 +0000 (00:19 +0100)]
sd-rtnl: recv_message - log when dropping message

We drop messages received from the wrong uid/pid, log this at debug level.

6 years agocore: loopback - simplify check_loopback()
Tom Gundersen [Sun, 28 Dec 2014 12:38:23 +0000 (13:38 +0100)]
core: loopback - simplify check_loopback()

We no longer configure the addresses on the loopback interface, but simply bring it up
and let the kernel do the rest. Also change the check to only check if the interface
is up, rather than checking for the IPv4 loopback address.

6 years agomachined: Fix MarkReadOnly method's name on bus
Sylvain Plantefève [Sun, 28 Dec 2014 11:52:15 +0000 (12:52 +0100)]
machined: Fix MarkReadOnly method's name on bus

6 years agolibsystemd: Fix minor typo in comment
Sylvain Plantefève [Sun, 28 Dec 2014 11:52:14 +0000 (12:52 +0100)]
libsystemd: Fix minor typo in comment

6 years agomachined: don't look for images on each property get, but cache the image object...
Lennart Poettering [Sun, 28 Dec 2014 01:44:37 +0000 (02:44 +0100)]
machined: don't look for images on each property get, but cache the image object inbetween

6 years agoupdate TODO
Lennart Poettering [Sat, 27 Dec 2014 16:45:30 +0000 (17:45 +0100)]
update TODO

6 years agoutil: treat -1 as special size in format_bytes()
Lennart Poettering [Sun, 28 Dec 2014 01:07:32 +0000 (02:07 +0100)]
util: treat -1 as special size in format_bytes()

6 years agomachined: add support for reporting image size via btrfs quota
Lennart Poettering [Sun, 28 Dec 2014 01:05:28 +0000 (02:05 +0100)]
machined: add support for reporting image size via btrfs quota

6 years agotmpfiles.d: upgrade a couple of directories we create at boot to subvolumes
Lennart Poettering [Sat, 27 Dec 2014 17:47:17 +0000 (18:47 +0100)]
tmpfiles.d: upgrade a couple of directories we create at boot to subvolumes

In particular we upgrade /var/lib/container, /var/tmp and /tmp to

6 years agotmpfiles: add new line type 'v' for creating btrfs subvolumes
Lennart Poettering [Sat, 27 Dec 2014 17:46:36 +0000 (18:46 +0100)]
tmpfiles: add new line type 'v' for creating btrfs subvolumes

6 years agomachinectl/machined: implement "rename", "clone", "read-only" verbs for machine images
Lennart Poettering [Sat, 27 Dec 2014 16:44:04 +0000 (17:44 +0100)]
machinectl/machined: implement "rename", "clone", "read-only" verbs for machine images

6 years agomachined: add "machinectl remove" for removing images
Lennart Poettering [Sat, 27 Dec 2014 01:35:47 +0000 (02:35 +0100)]
machined: add "machinectl remove" for removing images

6 years agonspawn: use the same image discovery logic in nspawn as in machined
Lennart Poettering [Sat, 27 Dec 2014 01:07:29 +0000 (02:07 +0100)]
nspawn: use the same image discovery logic in nspawn as in machined

6 years agomachined: Move image discovery logic into src/shared, so that we can make use of...
Lennart Poettering [Sat, 27 Dec 2014 00:57:03 +0000 (01:57 +0100)]
machined: Move image discovery logic into src/shared, so that we can make use of it from nspawn

6 years agoFix check_loopback()
Stéphane Graber [Sat, 27 Dec 2014 18:17:39 +0000 (19:17 +0100)]
Fix check_loopback()

Add missing htonl() so that check_loopback() actually tests for
instead of on little-endian machines.

6 years agologinctl: reindent --help text
Lennart Poettering [Fri, 26 Dec 2014 19:10:01 +0000 (20:10 +0100)]
loginctl: reindent --help text

6 years agologinctl: add more --help sections
Lennart Poettering [Fri, 26 Dec 2014 19:09:21 +0000 (20:09 +0100)]
loginctl: add more --help sections

6 years agomachinectl: add status commands
Lennart Poettering [Fri, 26 Dec 2014 19:09:04 +0000 (20:09 +0100)]
machinectl: add status commands

6 years agomachined: fix search patch magic for '.host' image
Lennart Poettering [Fri, 26 Dec 2014 19:05:11 +0000 (20:05 +0100)]
machined: fix search patch magic for '.host' image

6 years agomachined: make image read-only check indepenednt on own privs
Lennart Poettering [Fri, 26 Dec 2014 18:36:25 +0000 (19:36 +0100)]
machined: make image read-only check indepenednt on own privs

6 years agomachinectl: mark read-only images when listing in red
Lennart Poettering [Fri, 26 Dec 2014 18:32:55 +0000 (19:32 +0100)]
machinectl: mark read-only images when listing in red

6 years agoupdate TODO
Lennart Poettering [Fri, 26 Dec 2014 16:11:03 +0000 (17:11 +0100)]
update TODO

6 years agoimport: make image root directory configurable, instead of hardcoding /var/lib/container
Lennart Poettering [Fri, 26 Dec 2014 18:21:09 +0000 (19:21 +0100)]
import: make image root directory configurable, instead of hardcoding /var/lib/container

6 years agomachined: when discovering images, implicitly add ".host" as pseudo image referring...
Lennart Poettering [Fri, 26 Dec 2014 17:59:26 +0000 (18:59 +0100)]
machined: when discovering images, implicitly add ".host" as pseudo image referring to the host's own directory tree

6 years agomachined: fix image search path iteration
Lennart Poettering [Fri, 26 Dec 2014 17:19:47 +0000 (18:19 +0100)]
machined: fix image search path iteration

6 years agomachined: let's also check machine directories in /usr and /usr/local
Lennart Poettering [Fri, 26 Dec 2014 17:19:22 +0000 (18:19 +0100)]
machined: let's also check machine directories in /usr and /usr/local

6 years agoimport: properly remove pre-existing images if --force is used
Lennart Poettering [Fri, 26 Dec 2014 17:18:47 +0000 (18:18 +0100)]
import: properly remove pre-existing images if --force is used

6 years agoimport: beef up gpt importer to optionally make writable copy of read-only vendor...
Lennart Poettering [Fri, 26 Dec 2014 16:10:31 +0000 (17:10 +0100)]
import: beef up gpt importer to optionally make writable copy of read-only vendor image

6 years agoimport: minor improvements to dkr importer
Lennart Poettering [Fri, 26 Dec 2014 16:10:05 +0000 (17:10 +0100)]
import: minor improvements to dkr importer

6 years agoutil: always override crtime xattr
Lennart Poettering [Fri, 26 Dec 2014 16:03:01 +0000 (17:03 +0100)]
util: always override crtime xattr

6 years agomachinectl: left-align times
Lennart Poettering [Fri, 26 Dec 2014 16:01:00 +0000 (17:01 +0100)]
machinectl: left-align times

6 years agocopy: try top copy atime/time/xattrs when copying files
Lennart Poettering [Fri, 26 Dec 2014 16:00:39 +0000 (17:00 +0100)]
copy: try top copy atime/time/xattrs when copying files

6 years agotest: improve btrfs test case
Lennart Poettering [Fri, 26 Dec 2014 15:59:53 +0000 (16:59 +0100)]
test: improve btrfs test case

6 years agomachined: be more thorough when checking whether an image is writable or not
Lennart Poettering [Fri, 26 Dec 2014 15:44:15 +0000 (16:44 +0100)]
machined: be more thorough when checking whether an image is writable or not

6 years agojournald: always allocate space for object fields
Zbigniew Jędrzejewski-Szmek [Fri, 26 Dec 2014 14:02:01 +0000 (09:02 -0500)]
journald: always allocate space for object fields

If OBJECT_PID= came as the last field, we would not reallocate the iovec to bigger size,
and fail the assertion later on in dispatch_message_real().

6 years agojournald: fix off by one in native transport
Zbigniew Jędrzejewski-Szmek [Fri, 26 Dec 2014 13:34:18 +0000 (08:34 -0500)]
journald: fix off by one in native transport

6 years agohwdb: mouse - add Razer Abyssus
Tom Gundersen [Thu, 25 Dec 2014 23:20:48 +0000 (00:20 +0100)]
hwdb: mouse - add Razer Abyssus

6 years agoman: mark hwdb related man pages as conditional
Michael Biebl [Thu, 25 Dec 2014 23:04:19 +0000 (00:04 +0100)]
man: mark hwdb related man pages as conditional

Follow-up fix for commit fe659612e40e6a0cf91a73b10aa45eea958b747e.

6 years agoman: typo in sd_watchdog_enabled notes
Manuel Mendez [Thu, 25 Dec 2014 16:59:08 +0000 (11:59 -0500)]
man: typo in sd_watchdog_enabled notes

6 years agotest: wait for cloned thread to exit
Filipe Brandenburger [Thu, 25 Dec 2014 16:40:46 +0000 (11:40 -0500)]
test: wait for cloned thread to exit

In test_raw_clone, make sure the cloned thread calls _exit() and in the parent
thread call waitpid(..., __WCLONE) to wait for the child thread to terminate,
otherwise there is a race condition where the child thread will log to the
console after the test process has already exited and the assertion from the
child thread might not be enforced.

The absence of this patch might also create problems for other tests that would
be added after this one, since potentially both parent and child would run
those tests as the child would continue running.

Tested by confirming that the logs from the child are printed before the test
terminates and that a false assertion in the child aborts the test with a core

[zj: also add check for the return value.]

6 years agotest: only use assert_se in test_raw_clone
Filipe Brandenburger [Tue, 23 Dec 2014 18:14:46 +0000 (10:14 -0800)]
test: only use assert_se in test_raw_clone

The asserts used in the tests should never be allowed to be optimized away.

6 years keep posix compat for string tests
Dave Reisner [Thu, 25 Dec 2014 16:41:06 +0000 (11:41 -0500)] keep posix compat for string tests

'==' and '=' are equivalent in /bin/bash, but POSIX compliant shells do
not understand '==.'

6 years agoman: add a note why %U,%h,%s are mostly useless
Zbigniew Jędrzejewski-Szmek [Thu, 25 Dec 2014 16:12:54 +0000 (11:12 -0500)]
man: add a note why %U,%h,%s are mostly useless

The reasons were already given in the description of %U, but the
are easy to overlook, and it's better to be explicit to avoid

6 years agorun: uninitialized variable
Zbigniew Jędrzejewski-Szmek [Thu, 25 Dec 2014 15:52:38 +0000 (10:52 -0500)]
run: uninitialized variable

6 years agoata_id: remove temp variable to kill warning
Zbigniew Jędrzejewski-Szmek [Thu, 25 Dec 2014 15:44:34 +0000 (10:44 -0500)]
ata_id: remove temp variable to kill warning

src/udev/ata_id/ata_id.c:503:24: warning: assignment from incompatible pointer type
         identify_words = &identify.wyde;

6 years agoata_id: modernize
Zbigniew Jędrzejewski-Szmek [Thu, 25 Dec 2014 15:42:23 +0000 (10:42 -0500)]
ata_id: modernize

6 years agopam_systemd: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:48 +0000 (10:38 -0800)]
pam_systemd: remove spurious include of <sys/capability.h>

It does not use any functions or constants from libcap directly.

Tested that "" builds cleanly and works after this change.

6 years agotimedated: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:47 +0000 (10:38 -0800)]
timedated: remove spurious include of <sys/capability.h>

It does not use any functions from libcap directly. The CAP_SYS_TIME constant
in use by this file comes from <linux/capability.h> imported through "missing.h".

Tested that "systemd-timedated" builds cleanly and works after this change.

6 years agolocaled: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:46 +0000 (10:38 -0800)]
localed: remove spurious include of <sys/capability.h>

It does not use any functions from libcap directly. The CAP_SYS_ADMIN constant
in use by this file comes from <linux/capability.h> imported through "missing.h".

Tested that "systemd-localed" builds cleanly and works after this change.

6 years agobus: remove spurious include of <sys/capability.h>
Filipe Brandenburger [Tue, 23 Dec 2014 18:38:50 +0000 (10:38 -0800)]
bus: remove spurious include of <sys/capability.h>

They do not use any functions from libcap directly. The CAP_SYS_ADMIN constant
in use by bus-objects.c comes from <linux/capability.h> imported through
"missing.h". The "missing.h" header is imported through "util.h" which gets
imported in "bus-util.h".

Tested that everything builds cleanly after this change.