chiark / gitweb /
7 years agounits: improve Description= for systemd's own busname unit
Lennart Poettering [Wed, 7 Jan 2015 20:54:31 +0000 (21:54 +0100)]
units: improve Description= for systemd's own busname unit

7 years agohwdb: mouse DPI data, Logitech Gaming Mouse G400
Jonas Ådahl [Wed, 7 Jan 2015 08:23:37 +0000 (16:23 +0800)]
hwdb: mouse DPI data, Logitech Gaming Mouse G400

7 years agobusctl: exit cleanly when the bus connection is severed
Lennart Poettering [Wed, 7 Jan 2015 19:42:14 +0000 (20:42 +0100)]
busctl: exit cleanly when the bus connection is severed

7 years agosd-bus: when we synthesize messages, initialize timestamps ourselves
Lennart Poettering [Wed, 7 Jan 2015 19:36:23 +0000 (20:36 +0100)]
sd-bus: when we synthesize messages, initialize timestamps ourselves

7 years agosd-bus: unify how we set the sender of synthetic messages
Lennart Poettering [Wed, 7 Jan 2015 19:25:30 +0000 (20:25 +0100)]
sd-bus: unify how we set the sender of synthetic messages

7 years agosd-bus: make use of the newly added timestamps on kdbus kernel messages
Lennart Poettering [Wed, 7 Jan 2015 18:53:39 +0000 (19:53 +0100)]
sd-bus: make use of the newly added timestamps on kdbus kernel messages

7 years agosd-bus: always catch name requests for the special names "org.freedesktop.DBus" and...
Lennart Poettering [Wed, 7 Jan 2015 18:29:14 +0000 (19:29 +0100)]
sd-bus: always catch name requests for the special names "org.freedesktop.DBus" and "org.freedesktop.DBus.Local" and refuse them

7 years agoupdate TODO
Lennart Poettering [Wed, 7 Jan 2015 18:18:04 +0000 (19:18 +0100)]
update TODO

7 years agomachinectl: prettify "machinectl list" output
Lennart Poettering [Wed, 7 Jan 2015 18:13:48 +0000 (19:13 +0100)]
machinectl: prettify "machinectl list" output

7 years agosysv-generator: initialize units before use to ensure correct ordering
Michael Biebl [Fri, 28 Nov 2014 05:04:48 +0000 (06:04 +0100)]
sysv-generator: initialize units before use to ensure correct ordering

The original loop called fix_order() on each service immediately after
loading it, but fix_order() would reference other units which were not
loaded yet.
This resulted in bogus and unnecessary orderings based on the static
start priorities.

Therefore call load_sysv() for every init script when traversing them in
enumerate_sysv(). This ensures that all units are loaded when
fix_order() is called.


7 years agoupdate TODO
Lennart Poettering [Wed, 7 Jan 2015 17:00:38 +0000 (18:00 +0100)]
update TODO

7 years agoman: document nss-mymachines
Lennart Poettering [Wed, 7 Jan 2015 16:40:10 +0000 (17:40 +0100)]
man: document nss-mymachines

7 years agoman: add an alias to libnss_myhostname.so2 for nss-myhostname
Lennart Poettering [Wed, 7 Jan 2015 16:19:46 +0000 (17:19 +0100)]
man: add an alias to libnss_myhostname.so2 for nss-myhostname

The module appears under the name "" in the file
system, hence let's link it up under that name.

7 years agoman: rework nss-myhostname man page
Lennart Poettering [Wed, 7 Jan 2015 16:14:04 +0000 (17:14 +0100)]
man: rework nss-myhostname man page

Remove a number of incorrect links, and explain that "localhost" and
"gateway" are now resolved by it, too.

7 years agoUpdate TODO
Lennart Poettering [Wed, 7 Jan 2015 13:49:27 +0000 (14:49 +0100)]
Update TODO

7 years agoptyfwd: simplify how we handle vhangups a bit
Lennart Poettering [Wed, 7 Jan 2015 13:46:45 +0000 (14:46 +0100)]
ptyfwd: simplify how we handle vhangups a bit

7 years agobtrfs-util: rework how we iterate through the results of the TREE_SEARCH results
Lennart Poettering [Wed, 7 Jan 2015 13:43:10 +0000 (14:43 +0100)]
btrfs-util: rework how we iterate through the results of the TREE_SEARCH results

Let's introduce some syntactic sugar with iteration macros, and add
correct key increment calls.

7 years agosysv-generator: handle Provides: for non-virtual facility names
Michael Biebl [Mon, 5 Jan 2015 08:49:44 +0000 (09:49 +0100)]
sysv-generator: handle Provides: for non-virtual facility names

The list of provided facility names as specified via Provides: in the
LSB header was originally implemented by adding those facilities to the
Names= property via unit_add_name().

In commit 95ed3294c632f5606327149f10cef1eb34422862 the internal SysV
support was replaced by a generator and support for parsing the Names=
option had been removed from the unit file parsing in v186.
As a result, Provides: for non-virtual facility was dropped when
introducing the sysv-generator.

Since quite a few SysV init scripts still use that functionality (at
least in distros like Debian which have a large body of SysV init
scripts), add back support by making those facility names available via
symlinks to the unit filename to ensure correct orderings between
SysV init scripts which use those facility names.


7 years agoupdate TODO
Lennart Poettering [Wed, 7 Jan 2015 02:08:29 +0000 (03:08 +0100)]
update TODO

7 years agomachinectl: make sure that "machinectl login" exits immediately when the machine...
Lennart Poettering [Wed, 7 Jan 2015 02:08:00 +0000 (03:08 +0100)]
machinectl: make sure that "machinectl login" exits immediately when the machine it is connected to dies

7 years agoutil: make use of kcmp() to compare fds, if it is available
Lennart Poettering [Wed, 7 Jan 2015 01:14:14 +0000 (02:14 +0100)]
util: make use of kcmp() to compare fds, if it is available

7 years agoutil: don't fail recursive bind mounting if we cannot read the mount flags from an...
Lennart Poettering [Wed, 7 Jan 2015 00:32:13 +0000 (01:32 +0100)]
util: don't fail recursive bind mounting if we cannot read the mount flags from an obstructed mounted

7 years agocore: implement serialization/deserialization of fd store elements
Lennart Poettering [Wed, 7 Jan 2015 00:18:13 +0000 (01:18 +0100)]
core: implement serialization/deserialization of fd store elements

7 years agotmpfiles: make gcc shut up
Lennart Poettering [Tue, 6 Jan 2015 19:33:46 +0000 (20:33 +0100)]
tmpfiles: make gcc shut up

7 years agojournal: consider file deletion errors a reason for rotation
Lennart Poettering [Tue, 6 Jan 2015 19:27:29 +0000 (20:27 +0100)]
journal: consider file deletion errors a reason for rotation

7 years agojournald: whenever we rotate a file, btrfs defrag it
Lennart Poettering [Tue, 6 Jan 2015 18:51:03 +0000 (19:51 +0100)]
journald: whenever we rotate a file, btrfs defrag it

Our write pattern is quite awful for CoW file systems (btrfs...), as we
keep updating file parts in the beginning of the file. This results in
fragmented journal files. Hence: when rotating files, defragment them,
since at that point we know that no further write accesses will be made.

7 years agoUpdate TODO
Lennart Poettering [Tue, 6 Jan 2015 18:50:52 +0000 (19:50 +0100)]
Update TODO

7 years agotmpfiles: finish with EXIT_FAILURE if anything failed
Zbigniew Jędrzejewski-Szmek [Tue, 6 Jan 2015 14:53:12 +0000 (09:53 -0500)]
tmpfiles: finish with EXIT_FAILURE if anything failed

Return value is successful only if everything succeeded.

7 years agotree-wide: remove unnecessary LOG_PRI
Zbigniew Jędrzejewski-Szmek [Tue, 6 Jan 2015 05:29:40 +0000 (00:29 -0500)]
tree-wide: remove unnecessary LOG_PRI

LOG_DEBUG is already a log level, there is no need to use LOG_PRI which
is for filtering out the facility.

7 years agojournal-upload: enable curl debug output conditionally
Zbigniew Jędrzejewski-Szmek [Tue, 6 Jan 2015 05:26:26 +0000 (00:26 -0500)]
journal-upload: enable curl debug output conditionally

7 years agopo: Initial Hungarian translation
Gabor Kelemen [Fri, 2 Jan 2015 22:02:16 +0000 (23:02 +0100)]
po: Initial Hungarian translation

7 years agoman: clarify path escaping and reference systemd-escape
Chris Atkinson [Thu, 1 Jan 2015 21:35:34 +0000 (16:35 -0500)]
man: clarify path escaping and reference systemd-escape

This patch adds more detail to the description of how path escaping
operates and provides a pointer to the systemd-escape program. Either
would serve to answer the question raised in the bug report, so
hopefully this will allow it to be closed.

7 years agobuild-sys: add two more missing makefile links
Lennart Poettering [Tue, 6 Jan 2015 02:16:07 +0000 (03:16 +0100)]
build-sys: add two more missing makefile links

7 years agomachined: simplification
Lennart Poettering [Mon, 5 Jan 2015 23:31:38 +0000 (00:31 +0100)]
machined: simplification

7 years agojournald: allow restarting journald without losing stream connections
Lennart Poettering [Mon, 5 Jan 2015 23:30:25 +0000 (00:30 +0100)]
journald: allow restarting journald without losing stream connections

Making use of the fd storage capability of the previous commit, allow
restarting journald by serilizing stream state to /run, and pushing open
fds to PID 1.

7 years agocore: add new logic for services to store file descriptors in PID 1
Lennart Poettering [Mon, 5 Jan 2015 23:26:25 +0000 (00:26 +0100)]
core: add new logic for services to store file descriptors in PID 1

With this change it is possible to send file descriptors to PID 1, via
sd_pid_notify_with_fds() which PID 1 will store individually for each
service, and pass via the usual fd passing logic on next invocation.
This is useful for enable daemon reload schemes where daemons serialize
their state to /run, push their fds into PID 1 and terminate, restoring
their state on next start from the data in /run and passed in from PID

The fds are kept by PID 1 as long as no POLLHUP or POLLERR is seen on
them, and the service they belong to are either not dead or failed, or
have a job queued.

7 years agocgroup: memory limits on / are not supported
Zbigniew Jędrzejewski-Szmek [Tue, 6 Jan 2015 00:03:08 +0000 (19:03 -0500)]
cgroup: memory limits on / are not supported

7 years agocgroup: fix error message
Zbigniew Jędrzejewski-Szmek [Tue, 6 Jan 2015 00:03:23 +0000 (19:03 -0500)]
cgroup: fix error message

systemd[1]: Failed to set memory.limit_in_bytes on : Invalid argument

7 years agojournal: call connect() with dropped privileges
Zbigniew Jędrzejewski-Szmek [Thu, 1 Jan 2015 03:40:41 +0000 (04:40 +0100)]
journal: call connect() with dropped privileges

When systemd starts a service, it first opened /run/systemd/journal/stdout
socket, and only later switched to the right (if they are
specified). Later on, journald looked at the credentials, and saw
root.root, because credentials are stored at the time the socket is
opened. As a result, all messages passed over _TRANSPORT=stdout were
logged with _UID=0, _GID=0.

Drop real uid and gid temporarily to fix the issue.

7 years agocore: rework counting of running jobs
Lennart Poettering [Mon, 5 Jan 2015 16:22:10 +0000 (17:22 +0100)]
core: rework counting of running jobs

Let's unify the code that counts the running jobs a bit, in order to
make sure we are less likely to miss one.

This is related to this bug:

However, it probably won't fix it fully, and I cannot reproduce the issue.

The change also adds an explicit assert change when the counter is off.

7 years agopo: add Swedish translation
Josef Andersson [Mon, 5 Jan 2015 16:38:54 +0000 (11:38 -0500)]
po: add Swedish translation

7 years agopath-lookup, systemctl: export lookup_paths_init_from_scope() from shared/install...
Ivan Shapovalov [Fri, 19 Dec 2014 14:08:07 +0000 (17:08 +0300)]
path-lookup, systemctl: export lookup_paths_init_from_scope() from shared/install.c and use it

7 years agomachine: add reference to machine-dbus.h to
Filipe Brandenburger [Mon, 29 Dec 2014 23:22:33 +0000 (15:22 -0800)]
machine: add reference to machine-dbus.h to

Commit 003dffde2c1b93 ("machined: Move image discovery logic into src/shared,
so that we can make use of it from nspawn") moved some definitions from
machine.h to a new machine-dbus.h, but did not include it in

Tested that `make distcheck` works after this fix.

7 years agotmpfiles: fix 'D' lines
Lennart Poettering [Mon, 5 Jan 2015 15:32:59 +0000 (16:32 +0100)]
tmpfiles: fix 'D' lines

7 years agonss-myhostname: always will in canonical hostname field when resolving addresses...
Lennart Poettering [Mon, 5 Jan 2015 15:23:21 +0000 (16:23 +0100)]
nss-myhostname: always will in canonical hostname field when resolving addresses to hostnames

7 years agobus-proxyd: don't allow to acquire org.freedesktop.DBus name
Lukasz Skalski [Mon, 5 Jan 2015 13:45:55 +0000 (14:45 +0100)]
bus-proxyd: don't allow to acquire org.freedesktop.DBus name

7 years agocore: fix typo in log message
Michael Biebl [Mon, 5 Jan 2015 13:12:47 +0000 (14:12 +0100)]
core: fix typo in log message

7 years agomachinectl: remove spurious newline
Lennart Poettering [Mon, 5 Jan 2015 12:46:36 +0000 (13:46 +0100)]
machinectl: remove spurious newline

7 years agopo: update Italian translation
Daniele Medri [Mon, 5 Jan 2015 12:46:18 +0000 (13:46 +0100)]
po: update Italian translation

7 years agosd-bus: sync kdbus.h
Daniel Mack [Mon, 5 Jan 2015 12:41:30 +0000 (13:41 +0100)]
sd-bus: sync kdbus.h

Catch up with latest changes in kdbus.ko:

 * Signals can be sent as unicast now, hence they need to be marked as
   such with the KDBUS_MSG_SIGNAL in the message flags.

 * Follow ioctl number change for KDBUS_CMD_FREE

7 years agoutil: Do not clear parent mount flags when setting up namespaces
Topi Miettinen [Sun, 4 Jan 2015 18:51:17 +0000 (20:51 +0200)]
util: Do not clear parent mount flags when setting up namespaces

When setting up a namespace, mount flags like noexec, nosuid and
nodev are cleared, so the mounts always have exec, suid and dev
flags enabled.

Copy source directory mount flags to target mount when remounting
the bind mounts.

7 years agoudevadm,..: make --help output of udev tools more like the output of the various...
Lennart Poettering [Mon, 5 Jan 2015 12:19:55 +0000 (13:19 +0100)]
udevadm,..: make --help output of udev tools more like the output of the various other tools

7 years agofstab-generator: use more appropriate checks for swap and device availability
Lennart Poettering [Mon, 5 Jan 2015 11:35:08 +0000 (12:35 +0100)]
fstab-generator: use more appropriate checks for swap and device availability

We always should use the same checks when deciding whether swap support
and mounting of devices is supported. Hence, let's make
fstab-generator's logic more similar to the usual logic we follow:

a) Look for /proc/swaps and no container support before activating

b) Look for /sys being writable befire supporting device mounts.

7 years agolibsystemd-network: fix typo in lldp
Torstein Husebø [Mon, 5 Jan 2015 08:55:11 +0000 (09:55 +0100)]
libsystemd-network: fix typo in lldp

7 years agoutil: Fix signedness error in lines(), match implementations
Colin Walters [Thu, 1 Jan 2015 19:57:08 +0000 (14:57 -0500)]
util: Fix signedness error in lines(), match implementations

Regression introduced by ed757c0cb03eef50e8d9aeb4682401c3e9486f0b

Mirror the implementation of columns(), since the fd_columns()
functions returns a negative integer for errors.

Also fix columns() to return the unsigned variable instead of the
signed intermediary (they're the same, but better to be explicit).

7 years agoupdate TODO
Lennart Poettering [Mon, 5 Jan 2015 01:58:04 +0000 (02:58 +0100)]
update TODO

7 years agojournald: reuse IOVEC_TOTAL_SIZE() macros where possible
Lennart Poettering [Mon, 5 Jan 2015 01:48:50 +0000 (02:48 +0100)]
journald: reuse IOVEC_TOTAL_SIZE() macros where possible

7 years agojournald: when we detect the journal file we are about to write to has been deleted...
Lennart Poettering [Mon, 5 Jan 2015 01:09:01 +0000 (02:09 +0100)]
journald: when we detect the journal file we are about to write to has been deleted, rotate

7 years agosystemctl: properly iterate through service array when dispatching to sysv
Lennart Poettering [Mon, 5 Jan 2015 00:56:47 +0000 (01:56 +0100)]
systemctl: properly iterate through service array when dispatching to sysv

7 years agojournald: add some additional checks before we divide by values read from journal...
Lennart Poettering [Mon, 5 Jan 2015 00:20:44 +0000 (01:20 +0100)]
journald: add some additional checks before we divide by values read from journal file headers

Since the file headers might be replaced by zeroed pages now due to
sigbus we should make sure we don't end up dividing by zero because we
don't check values read from journal file headers for changes.

7 years agojournalctl: static variables immediately configured via command line arguments should...
Lennart Poettering [Mon, 5 Jan 2015 00:08:51 +0000 (01:08 +0100)]
journalctl: static variables immediately configured via command line arguments should be prefixed with "arg_"

7 years agojournal: install sigbus handler for journal tools too
Lennart Poettering [Sun, 4 Jan 2015 23:52:47 +0000 (00:52 +0100)]
journal: install sigbus handler for journal tools too

This makes them robust regarding truncation. Ideally, we'd export this
as an API, but given how messy SIGBUS handling is, and the uncertain
ownership logic of signal handlers we should not do this (unless libc
one day invents a scheme how to sanely install SIGBUS handlers for
specific memory areas only). However, for now we can still make all our
own tools robust.

Note that external tools will only have read-access to the journal
anyway, where SIGBUS is much more unlikely, given that only writes are
subject to disk full problems.

7 years agosystemctl: fix waiting for jobs when using direct connections to PID 1 for dbus
Lennart Poettering [Sun, 4 Jan 2015 23:38:31 +0000 (00:38 +0100)]
systemctl: fix waiting for jobs when using direct connections to PID 1 for dbus

7 years agojournald: constify all things
Lennart Poettering [Sun, 4 Jan 2015 23:13:26 +0000 (00:13 +0100)]
journald: constify all things

7 years agomachined,bus-proxy: fix connecting to containers
Lennart Poettering [Sun, 4 Jan 2015 21:20:22 +0000 (22:20 +0100)]
machined,bus-proxy: fix connecting to containers

7 years agojournald: prefix exported calls with "server_", unexport unnecessary calls
Lennart Poettering [Sun, 4 Jan 2015 21:09:07 +0000 (22:09 +0100)]
journald: prefix exported calls with "server_", unexport unnecessary calls

7 years agojournald: process SIGBUS for the memory maps we set up
Lennart Poettering [Tue, 30 Dec 2014 19:57:53 +0000 (20:57 +0100)]
journald: process SIGBUS for the memory maps we set up

Even though we use fallocate() it appears that file systems like btrfs
will trigger SIGBUS on certain low-disk-space situation. We should
handle that, hence catch the signal, add it to a list of invalidated
pages, and replace the page with an empty memory area. After each write
check if SIGBUS was triggered, and consider the write invalid if it was.

This should make journald a lot more robust with file systems where
fallocate() is not reliable, for example all CoW file systems
(btrfs...), where changing written data can fail with disk full errors.

7 years agoupdate TODO
Lennart Poettering [Tue, 30 Dec 2014 01:19:04 +0000 (02:19 +0100)]
update TODO

7 years agonspawn: mount most of the cgroup tree read-only in nspawn containers except for the...
Lennart Poettering [Tue, 30 Dec 2014 00:57:23 +0000 (01:57 +0100)]
nspawn: mount most of the cgroup tree read-only in nspawn containers except for the container's own subtree in the name=systemd hierarchy

More specifically mount all other hierarchies in their entirety and the
name=systemd above the container's subtree read-only.

7 years agocgroup: downgrade log messages when we cannot write to cgroup trees that are mounted...
Lennart Poettering [Tue, 30 Dec 2014 00:56:42 +0000 (01:56 +0100)]
cgroup: downgrade log messages when we cannot write to cgroup trees that are mounted read-only

7 years agohwdb: fix a typo
Peter Hutterer [Sun, 4 Jan 2015 21:41:03 +0000 (07:41 +1000)]
hwdb: fix a typo

7 years agohwdb: revert Logitech Optical USB Mouse
Peter Hutterer [Sun, 4 Jan 2015 21:26:18 +0000 (07:26 +1000)]
hwdb: revert Logitech Optical USB Mouse

Reporter says he incorrectly measured the data but the device is not available
anymore to correct it. We'll have to wait for someone else to submit the data.

7 years agomachinectl: Check type instead of path before printing the type
Thomas Hindoe Paaboel Andersen [Fri, 2 Jan 2015 19:29:04 +0000 (20:29 +0100)]
machinectl: Check type instead of path before printing the type

Looks like a typo when introduced in fefdc04b38725457a91651218feb7000f6ccc1f4

7 years agopo: update Russian translation
Sergey Ptashnick [Thu, 1 Jan 2015 18:42:47 +0000 (21:42 +0300)]
po: update Russian translation

By analogy with commit 4038d7502f.

7 years agopo: update French translation
Sylvain Plantefève [Thu, 1 Jan 2015 17:02:54 +0000 (18:02 +0100)]
po: update French translation

7 years agomount: do not use -n when running in --user mode
Zbigniew Jędrzejewski-Szmek [Thu, 1 Jan 2015 19:25:18 +0000 (14:25 -0500)]
mount: do not use -n when running in --user mode

-n is only allowed for root. /etc/mtab is nowadays almost always a link to /proc/,
so in practice this does not really matter too much, but should allow .mount units
to work in --user mode.

7 years agoType of mount(2) flags is unsigned long
Topi Miettinen [Thu, 1 Jan 2015 17:40:07 +0000 (19:40 +0200)]
Type of mount(2) flags is unsigned long

7 years agoudev: improve help/usage for some more programs
Robert Milasan [Thu, 1 Jan 2015 17:11:22 +0000 (18:11 +0100)]
udev: improve help/usage for some more programs

7 years agonetworkctl: avoid potential use of unitialized variables
Zbigniew Jędrzejewski-Szmek [Thu, 1 Jan 2015 17:00:59 +0000 (12:00 -0500)]
networkctl: avoid potential use of unitialized variables

Those values are based on a file we read from disk, so we should
verify everything we receive, and make sure everything we print
is sensible.

Also, print fractional seconds for TTL.

7 years agonetworkctl: remove unused variable
Zbigniew Jędrzejewski-Szmek [Thu, 1 Jan 2015 16:53:25 +0000 (11:53 -0500)]
networkctl: remove unused variable

7 years agonetwork: fix scanf/printf format
Zbigniew Jędrzejewski-Szmek [Thu, 1 Jan 2015 16:15:50 +0000 (11:15 -0500)]
network: fix scanf/printf format

usec_t is defined as 64 bit wide, but long is 32 bit on many archs.

7 years agomissing: add __NR_renameat2
Zbigniew Jędrzejewski-Szmek [Thu, 1 Jan 2015 15:55:19 +0000 (10:55 -0500)]
missing: add __NR_renameat2

7 years agobuild-sys: Fix install location of systemd.pc
Martin Pitt [Sun, 28 Dec 2014 11:14:25 +0000 (12:14 +0100)]
build-sys: Fix install location of systemd.pc

systemd.pc contains "libdir" which can be architecture specific. Thus it needs
to be installed into libdir/pkgconfig/ instead of datadir/pkgconfig.

As nothing else is using pkgconfigdata any more, remove it entirely.

Note that udev.pc does not contain architecture specific values and thus can be
kept in /usr/share/pkgconfig/.

7 years agoRemove "to allow" from policy messages
Zbigniew Jędrzejewski-Szmek [Thu, 1 Jan 2015 14:44:43 +0000 (09:44 -0500)]
Remove "to allow" from policy messages

It carries no additional information and forces a passive sentence
structure which is longer and harder to parse.

7 years agopo: update Polish translation
Piotr Drąg [Fri, 26 Dec 2014 00:05:29 +0000 (01:05 +0100)]
po: update Polish translation

7 years agomachined: fix grammar in
Piotr Drąg [Thu, 25 Dec 2014 23:55:26 +0000 (00:55 +0100)]
machined: fix grammar in

[zj: change "in into" to "into".]

7 years agobuild-sys: fix build issue with
Philippe De Swert [Wed, 31 Dec 2014 16:02:12 +0000 (18:02 +0200)]
build-sys: fix build issue with

When doing "make clean" the unit/ file gets deleted.
This causes a build error later on when trying to rebuild systemd.

V2: The file probably belongs to dist_systemunit_DATA

7 years agoman: Clarify effect when both calendar day and date are listed in timer
Chris Atkinson [Thu, 1 Jan 2015 02:59:16 +0000 (21:59 -0500)]
man: Clarify effect when both calendar day and date are listed in timer

See bug 87859 ( Bug
reporter found the language describing the effect of specifying both a
day and date unclear; hopefully the attached patch will clarify and
allow the bug to be closed.

7 years agolldp: fix sd_lldp_save()
David Herrmann [Wed, 31 Dec 2014 15:28:48 +0000 (16:28 +0100)]
lldp: fix sd_lldp_save()

Fix a bunch of needless memzero() calls, a bunch of use-after-free
regarding _cleanup_free_ and drop unused variables.

Hint: Do NOT use _cleanup_free_ for temporary strappend() helpers that are
freed multiple times. All you safe is the last free() call, which is
really not worth the trouble resetting it to NULL all the time.

7 years agolldp: fix uninitialized cleanup var #2
David Herrmann [Wed, 31 Dec 2014 15:07:17 +0000 (16:07 +0100)]
lldp: fix uninitialized cleanup var #2

Another uninitialized variable marked as _cleanup_. Set it to NULL to
avoid accessing uninitialized memory.

7 years agolldp: fix uninitialized cleanup var
David Herrmann [Wed, 31 Dec 2014 15:04:55 +0000 (16:04 +0100)]
lldp: fix uninitialized cleanup var

Make sure to set _cleanup_ variables to NULL. Otherwise, we free
uninitialized objects.

7 years agoimport: fix mem-leak in CurlGlue
David Herrmann [Wed, 31 Dec 2014 15:01:37 +0000 (16:01 +0100)]
import: fix mem-leak in CurlGlue

Make sure to actually free the underlying object in CurlGlue unref.

7 years agolldp: fix double free
David Herrmann [Wed, 31 Dec 2014 14:58:27 +0000 (15:58 +0100)]
lldp: fix double free

'k' is marked as _cleanup_free_ so reset it to NULL if we free it

7 years agonetworkctl: fix strappend() error checking
David Herrmann [Wed, 31 Dec 2014 14:56:11 +0000 (15:56 +0100)]
networkctl: fix strappend() error checking

Make sure to test the right variable for NULL.

7 years agonetwork: add malloc-assertion in test
David Herrmann [Wed, 31 Dec 2014 14:54:20 +0000 (15:54 +0100)]
network: add malloc-assertion in test

Make sure malloc() really returns non-NULL in lldp test.

7 years agomachinectl: remove dead code
David Herrmann [Wed, 31 Dec 2014 14:52:23 +0000 (15:52 +0100)]
machinectl: remove dead code

'r' is not touched after the previous error-checking 100 lines above. Drop
that code.

7 years agohwdb: mouse DPI data, Logitech USB Laser Mouse M-U0011-O
Christoph Brill [Wed, 31 Dec 2014 13:28:52 +0000 (08:28 -0500)]
hwdb: mouse DPI data, Logitech USB Laser Mouse M-U0011-O

7 years agoRevert commit f131770b "tree-wide: spelling fixes"
David Herrmann [Wed, 31 Dec 2014 12:34:21 +0000 (13:34 +0100)]
Revert commit f131770b "tree-wide: spelling fixes"

This partially reverts:

    commit f131770b1465fbf423881f16ba85523a05f846fe
    Author: Veres Lajos <>
    Date:   Mon Dec 29 09:45:58 2014 +0000

        tree-wide: spelling fixes

The commit in question changed a binary file. I didn't look at the diff in
particular, so I have no idea what exactly was changed. However, the file
is generated and it looked highly suspiciuous. Therefore, I reverted that

Note that this is generated by "make update-unifont" so really no reason
to touch at all.

7 years agotree-wide: spelling fixes
Veres Lajos [Mon, 29 Dec 2014 09:45:58 +0000 (09:45 +0000)]
tree-wide: spelling fixes
Thanks to Torstein Husebo <>.

7 years agoaccelerometer: display short options too
Robert Milasan [Tue, 30 Dec 2014 17:58:29 +0000 (18:58 +0100)]
accelerometer: display short options too