chiark / gitweb /
8 years agosystemd-python: refuse path and flags together in __init__
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 16:28:44 +0000 (11:28 -0500)]
systemd-python: refuse path and flags together in __init__

It's better to explictly check, instead of just documenting it.

The return value from init is changed from 1 to -1 on error.
Python seems to ignore 1 every second time. Looks like a bug
in Python, but the return value doesn't seem to be documented
anywhere, and -1 works as expected... so let's just use that.

8 years agobuild-sys: force creation of symlink
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 15:15:20 +0000 (10:15 -0500)]
build-sys: force creation of symlink

For some reason make sometimes wants to rerun this, and
ln would refuse to recreate the link.

8 years agologind: don't hit an assert if an close() on an input device fd fails with ENODEV...
Lennart Poettering [Thu, 7 Mar 2013 15:48:14 +0000 (16:48 +0100)]
logind: don't hit an assert if an close() on an input device fd fails with ENODEV because the device is gone

8 years agosystemctl: mangle unit name in is-enabled
Lukas Nykryn [Thu, 7 Mar 2013 15:09:20 +0000 (16:09 +0100)]
systemctl: mangle unit name in is-enabled

8 years agobootchart: document -C, --cmdline parameter
Harald Hoyer [Thu, 7 Mar 2013 15:19:38 +0000 (16:19 +0100)]
bootchart: document -C, --cmdline parameter

8 years agobootchart: use _cleanup_fclose_
Harald Hoyer [Thu, 7 Mar 2013 07:52:56 +0000 (08:52 +0100)]
bootchart: use _cleanup_fclose_

8 years agobootchart: rename global len to samples_len
Harald Hoyer [Thu, 7 Mar 2013 07:52:55 +0000 (08:52 +0100)]
bootchart: rename global len to samples_len

8 years agobootchart: add parameter "-C" to expand process names to the full cmdline
Harald Hoyer [Thu, 7 Mar 2013 07:52:54 +0000 (08:52 +0100)]
bootchart: add parameter "-C" to expand process names to the full cmdline

8 years agoutil: Fix grammar in comment
Jan Janssen [Thu, 7 Mar 2013 14:12:46 +0000 (15:12 +0100)]
util: Fix grammar in comment

8 years agoman: Unify title for configuration files
Jan Janssen [Thu, 7 Mar 2013 14:12:45 +0000 (15:12 +0100)]
man: Unify title for configuration files

8 years agoman: Fix id attributes
Jan Janssen [Thu, 7 Mar 2013 14:12:44 +0000 (15:12 +0100)]
man: Fix id attributes

8 years agovirt: check for /sys/hypervisor/type for detecting xen PV
Lennart Poettering [Thu, 7 Mar 2013 14:59:26 +0000 (15:59 +0100)]
virt: check for /sys/hypervisor/type for detecting xen PV

8 years agonspawn: create a separate devpts namespace for nspawn containers
Lennart Poettering [Thu, 7 Mar 2013 12:34:07 +0000 (13:34 +0100)]
nspawn: create a separate devpts namespace for nspawn containers

8 years agoman/kernel-install.xml: fix paths to reflect actual behaviour
Harald Hoyer [Thu, 7 Mar 2013 08:27:59 +0000 (09:27 +0100)]
man/kernel-install.xml: fix paths to reflect actual behaviour

8 years agolibsystemd-journal: return 0 on success in get_data()
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 05:40:30 +0000 (00:40 -0500)]
libsystemd-journal: return 0 on success in get_data()

The man page says so. Right now 0 would be returned if the data was encrypted,
1 otherwise.

8 years agosystemd-python: export sd_j_get_fd, sd_j_reliable_fd, sd_j_close
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 05:35:28 +0000 (00:35 -0500)]
systemd-python: export sd_j_get_fd, sd_j_reliable_fd, sd_j_close

sd_journal_get_fd(j) is called j.fileno(), for compatiblity with
Python conventions for file-like objects.

More importantly, those new .seek_head() and .seek_tail() do not
call .get_next(). This is better, if one wants to skip before
retrieving an entry.

8 years agosystemd-python: split .seek() into .seek_head() and .seek_tail()
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 05:26:24 +0000 (00:26 -0500)]
systemd-python: split .seek() into .seek_head() and .seek_tail()

This way python code follows the original interface more closely.
Also, .seek(0, journal.SEEK_END) was just to much to type.

8 years agosystemd-python: catch only ValueErrors in conversion code
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 03:15:46 +0000 (22:15 -0500)]
systemd-python: catch only ValueErrors in conversion code

First of all, 'try: ... except: ...' (with no exception specified) is
always a no-no, since it catches all BaseExceptions, which includes ^C
and other stuff which should almost never be caught.

Now the conversion is stricter, and only one conversion is attempted,
and only a ValueEror is caught. It seems reasonable to catch ValueErrors,
since the entries in the journal are not verified, and any erroneous
application might log a field which cannot be converted. The consumer
of events must only check if a field is an instance of bytes and can
otherwise assume that the conversion was performed correctly.

Order of arguments in Reader.__init__ has been changed to match order
in _Reader.__init__.

Conversions have been updated to work under Python 2 and 3.

8 years agoman: fix compilation of example
Zbigniew Jędrzejewski-Szmek [Wed, 6 Mar 2013 22:07:42 +0000 (17:07 -0500)]
man: fix compilation of example

8 years agoservice: sysv - properly handle init scripts with .sh suffix
Michael Biebl [Wed, 6 Mar 2013 22:24:31 +0000 (23:24 +0100)]
service: sysv - properly handle init scripts with .sh suffix

Dropping the distribution specific #ifdefs in
88516c0c952b9502e8ef1d6a1481af61b0fb422d broke the .sh suffix stripping
since we now always used the else clause of the rc. check.

We eventually want to drop the rc. prefix stripping, but for now we
assume that no sysv init script uses both an rc. prefix and .sh suffix,
so make the check for the .sh suffix and rc. prefix mutually exclusive.

8 years agolibsystemd-journal: export new function, increase library version
Zbigniew Jędrzejewski-Szmek [Wed, 6 Mar 2013 18:19:45 +0000 (13:19 -0500)]
libsystemd-journal: export new function, increase library version

Since sd_journal_reliable_fd wasn't exported before, it is as if
it was added now. Library "current" number must be bumped.

michich> Someone links with the fixed version and produces a RPM with
         his program. The RPM will happily install on a system with an
         old systemd version (the deps will appear fine), but the
         program will fail to run.

8 years agoREADME: more CONFIG_* updates
Kay Sievers [Wed, 6 Mar 2013 19:01:45 +0000 (20:01 +0100)]
README: more CONFIG_* updates

8 years agoREADME: remove CONFIG_HOTPLUG, add CONFIG_NET
Kay Sievers [Wed, 6 Mar 2013 18:51:52 +0000 (19:51 +0100)]

8 years agoREADME: add kernel config options
Kay Sievers [Wed, 6 Mar 2013 18:36:39 +0000 (19:36 +0100)]
README: add kernel config options

8 years agojournal: properly advertise sd_journal_reliable_fd
Zbigniew Jędrzejewski-Szmek [Wed, 6 Mar 2013 17:17:37 +0000 (12:17 -0500)]
journal: properly advertise sd_journal_reliable_fd

sd_journal_reliable_fd was added in 85210bffd836, but it was
exported under the wrong name. Not too many users I guess.

8 years agobuild-sys: add missing $
Zbigniew Jędrzejewski-Szmek [Wed, 6 Mar 2013 17:01:59 +0000 (12:01 -0500)]
build-sys: add missing $

Fixup for 25ee45f99.

8 years agocore: add missing comma for NonewPrivileges=
Lennart Poettering [Wed, 6 Mar 2013 16:48:42 +0000 (17:48 +0100)]
core: add missing comma for NonewPrivileges=

8 years agobus: Escape environment-based D-Bus addresses properly
Simon McVittie [Thu, 7 Feb 2013 21:14:56 +0000 (21:14 +0000)]
bus: Escape environment-based D-Bus addresses properly

If XDG_RUNTIME_DIR contains a character like ":" (for instance if it's
formed from an X11 display name), then it isn't valid to substitute
it into a D-Bus address without escaping.

8 years agomanager: remove timer fd explicitly from epoll
Enrico Scholz [Sat, 2 Mar 2013 16:31:53 +0000 (17:31 +0100)]
manager: remove timer fd explicitly from epoll

Forked processes can keep the old fd alive triggering epoll over and
over again else.

8 years agomain: ISOLATE rather than REPLACE
Tom Gundersen [Tue, 5 Mar 2013 06:56:47 +0000 (15:56 +0900)]
main: ISOLATE rather than REPLACE

This allows switch-root to work correctly if a unit is active both before and
after the switch-root, but its dependencies change. Before the patch, any
dependencies added to active units by switch-root will not be pulled, in
particular filesystems configured in /etc/fstab would not be activated if was active in the initrd.

It is not clear to me if there is a bug in the REPLACE handling, or if it is
working as expected and that we really want to use ISOLATE instead as this patch

8 years agoupdate TODO
Lennart Poettering [Wed, 6 Mar 2013 14:39:27 +0000 (15:39 +0100)]
update TODO

8 years agotimedated: add CanNTP property
Ryan Lortie [Mon, 4 Mar 2013 21:35:02 +0000 (16:35 -0500)]
timedated: add CanNTP property

If we can't successfully query any ntpd units, set CanNTP to false.

GNOME wants to use this to grey out the NTP switch in the UI.

8 years agounits: run systemd-ask-password-console.service after systemd-vconsole-setup.service
Harald Hoyer [Thu, 14 Feb 2013 11:52:24 +0000 (12:52 +0100)]
units: run systemd-ask-password-console.service after systemd-vconsole-setup.service

8 years agoinitrd-parse-etc.servic: force start
Harald Hoyer [Wed, 6 Mar 2013 10:02:35 +0000 (11:02 +0100)]
initrd-parse-etc.servic: force start

8 years agoRevert "add and"
Harald Hoyer [Tue, 5 Mar 2013 07:16:15 +0000 (08:16 +0100)]
Revert "add and"

This reverts commit 39b83cdab37623a546344622db9bbbc784c15df5.

8 years agoRevert "units/initrd-*: require rather than"
Harald Hoyer [Tue, 5 Mar 2013 07:16:06 +0000 (08:16 +0100)]
Revert "units/initrd-*: require rather than"

This reverts commit 7d89ce303fb59743a4392eeb3110c00f100172ca.

8 years agosystemd-python: fix error check in _Reader.wait()
Zbigniew Jędrzejewski-Szmek [Wed, 6 Mar 2013 04:23:09 +0000 (23:23 -0500)]
systemd-python: fix error check in _Reader.wait()

8 years agojournal/tests: free allocated memory in test
Zbigniew Jędrzejewski-Szmek [Wed, 6 Mar 2013 02:43:06 +0000 (21:43 -0500)]
journal/tests: free allocated memory in test

8 years agozsh-completion: journalctl query by binary and device
Daniel Wallace [Tue, 5 Mar 2013 19:32:09 +0000 (14:32 -0500)]
zsh-completion: journalctl query by binary and device

implement 1883552c3d8 from bash completion in zsh-completion

8 years agohostnamed: allow more special characters in pretty hostname
Nathaniel Chen [Tue, 5 Mar 2013 19:46:34 +0000 (11:46 -0800)]
hostnamed: allow more special characters in pretty hostname

this addresses the bug at:

hostnamectl is supposed to allow a range of special characters for
the 'pretty' hostname:
  $ hostnamectl set-hostname --pretty "Nathaniels Desktop !@#$%"
..however, it rejects apostrophes, double quotes, and backslashes.
The manual for hostnamectl suggests that this should be allowed.

It makes sense to reject \0, \n, etc. pretty_string_is_safe() is
the same as string_is_safe(), but allows more special characters.

8 years agoutil: properly escape corner cases in bus_path_escape(), too
Lennart Poettering [Tue, 5 Mar 2013 18:58:32 +0000 (19:58 +0100)]
util: properly escape corner cases in bus_path_escape(), too

This follows the suggestions from:

8 years agoinhibit: print --list if no argument is given
Kay Sievers [Tue, 5 Mar 2013 18:32:36 +0000 (19:32 +0100)]
inhibit: print --list if no argument is given

8 years agoFix typos
Michael Biebl [Tue, 5 Mar 2013 18:19:26 +0000 (19:19 +0100)]
Fix typos

8 years agojournal: make gatewayd run under its own user ID
Lennart Poettering [Tue, 5 Mar 2013 18:15:31 +0000 (19:15 +0100)]
journal: make gatewayd run under its own user ID

8 years agoREADME: add udev goups
Kay Sievers [Tue, 5 Mar 2013 18:04:48 +0000 (19:04 +0100)]
README: add udev goups

8 years agoupdate TODO
Lennart Poettering [Tue, 5 Mar 2013 17:59:14 +0000 (18:59 +0100)]
update TODO

8 years agojournald: introduce new "systemd-journal" group and make it own the journal files
Lennart Poettering [Tue, 5 Mar 2013 17:53:21 +0000 (18:53 +0100)]
journald: introduce new "systemd-journal" group and make it own the journal files

Previously all journal files were owned by "adm". In order to allow
specific users to read the journal files without granting it access to
the full "adm" powers, introduce a new specific group for this.

"systemd-journal" has to be created by the packaging scripts manually at
installation time. It's a good idea to assign a static UID/GID to this
group, since /var/log/journal might be shared across machines via NFS.

This commit also grants read access to the journal files by default to
members of the "wheel" and "adm" groups via file system ACLs, since
these "almost-root" groups should be able to see what's going on on the
system. These ACLs are created by "make install". Packagers probably
need to duplicate this logic in their postinst scripts.

This also adds documentation how to grant access to the journal to
additional users or groups via fs ACLs.

8 years agojournald: stpcpy() + mempcpy() are awesome
Lennart Poettering [Tue, 5 Mar 2013 14:02:38 +0000 (15:02 +0100)]
journald: stpcpy() + mempcpy() are awesome

8 years agojournald: drop splitting-by-audit entirely
Lennart Poettering [Tue, 5 Mar 2013 13:36:57 +0000 (14:36 +0100)]
journald: drop splitting-by-audit entirely

Thinking about it we should probably not hide bugs by falling back to
audit when we have our own session information anyway.

8 years agojournald: be a bit more careful when spitting up journals by user id
Lennart Poettering [Tue, 5 Mar 2013 13:27:34 +0000 (14:27 +0100)]
journald: be a bit more careful when spitting up journals by user id

8 years agojournald: check session owner UID rather then audit ID when splitting up journal...
Lennart Poettering [Tue, 5 Mar 2013 13:23:22 +0000 (14:23 +0100)]
journald: check session owner UID rather then audit ID when splitting up journal files

We should always go by our own cgroup hierarchy before using foreign
schemes such as audit, so let's do that for the split out logic too.

8 years agoRevert "fstab-generator: place initrd /sysroot mounts in"
Harald Hoyer [Tue, 5 Mar 2013 05:45:06 +0000 (06:45 +0100)]
Revert "fstab-generator: place initrd /sysroot mounts in"

This reverts commit 8330847e949fc0c26b16910e5240eef1fe2c330a.


8 years agoupdate TODO
Lennart Poettering [Tue, 5 Mar 2013 03:10:19 +0000 (04:10 +0100)]
update TODO

8 years agologind: when registering a new session always use previous session info from cgroup...
Lennart Poettering [Tue, 5 Mar 2013 02:29:54 +0000 (03:29 +0100)]
logind: when registering a new session always use previous session info from cgroup path rather than audit

Previously for cases like "su" or "sudo" where a session is attempted to
be created from within an existing one we used the audit session ID to
detect this and in such a case we simple returned the session data of
the original session a second time.

With this change we will now use the cgroup path of the calling path to
determine the old session, i.e. we only rely on our own session
identification scheme, instead of audits.

We will continue to keep the audit session ID and ours in sync however,
to avoid unnecessary confusion.

8 years agobuild-sys: build and install systemd-coredumpctl conditionally
Michael Biebl [Mon, 4 Mar 2013 22:20:16 +0000 (23:20 +0100)]
build-sys: build and install systemd-coredumpctl conditionally

If coredump support is disabled via --disable-coredump, do not build and
install the systemd-coredumpctl binary and man page.

8 years agofstab-generator: only handle block devices with root= kernel command line parameter
Harald Hoyer [Mon, 4 Mar 2013 20:00:56 +0000 (21:00 +0100)]
fstab-generator: only handle block devices with root= kernel command line parameter

skip like root=nfs:... root=iscsi:... root=nbd:...

8 years agofstab-generator: place initrd /sysroot mounts in
Harald Hoyer [Mon, 4 Mar 2013 18:04:32 +0000 (19:04 +0100)]
fstab-generator: place initrd /sysroot mounts in

also do not overwrite /sysroot*.mount units already generated from fstab

8 years agounits/initrd-*: require rather than
Harald Hoyer [Mon, 4 Mar 2013 18:03:05 +0000 (19:03 +0100)]
units/initrd-*: require rather than

8 years agoadd and
Harald Hoyer [Mon, 4 Mar 2013 18:01:05 +0000 (19:01 +0100)]
add and

8 years agobuild-sys: do not install pam_systemd(8) without PAM
Zbigniew Jędrzejewski-Szmek [Mon, 4 Mar 2013 18:16:38 +0000 (13:16 -0500)]
build-sys: do not install pam_systemd(8) without PAM

8 years agobuild-sys: do not install logind manpages when disabled
Zbigniew Jędrzejewski-Szmek [Mon, 4 Mar 2013 17:57:12 +0000 (12:57 -0500)]
build-sys: do not install logind manpages when disabled

The condition was wrong: HAVE_PAM -> ENABLE_LOGIND.

8 years agoProFUSION got bought by Intel
Kay Sievers [Mon, 4 Mar 2013 15:13:19 +0000 (16:13 +0100)]
ProFUSION got bought by Intel

8 years agojournal: split journal uid only when audit uid data is valid
Kay Sievers [Mon, 4 Mar 2013 14:17:45 +0000 (15:17 +0100)]
journal: split journal uid only when audit uid data is valid

8 years agocore/manager: fix conditions to start and stop watching running jobs
Michal Schmidt [Mon, 4 Mar 2013 13:38:51 +0000 (14:38 +0100)]
core/manager: fix conditions to start and stop watching running jobs

Harald encountered division by zero in manager_print_jobs_in_progress.
Clearly we had the watch enabled when we shouldn't - there were no
running jobs in m->jobs, only waiting ones. This is either a deadlock,
or maybe some of them would be detected as runnable in the next dispatch
of the run queue. In any case we mustn't crash.

Fix it by starting and stopping the watch based on n_running_jobs
instead of the number of all jobs.

8 years agotmpfiles: use cleanup func. to save a few lines
Zbigniew Jędrzejewski-Szmek [Sun, 3 Mar 2013 23:42:52 +0000 (18:42 -0500)]
tmpfiles: use cleanup func. to save a few lines

8 years agotmpfiles: move exclamation mark into right place
Lukas Nykryn [Fri, 1 Mar 2013 17:29:59 +0000 (18:29 +0100)]
tmpfiles: move exclamation mark into right place

Unary not has higher precedence than comparisons,
so the condition was bogus.

8 years agocore/path: install inotify watches top-down instead of bottom-up
Zbigniew Jędrzejewski-Szmek [Sun, 3 Mar 2013 06:32:34 +0000 (01:32 -0500)]
core/path: install inotify watches top-down instead of bottom-up

When watches are installed from the bottom, it is always possible
to race, and miss a file creation event. The race can be avoided
if a watch is first established for a parent directory, and then for
the file in the directory. If the file is created in the time between,
the watch on the parent directory will fire.

Some messages (mostly at debug level) are added to help diagnose
pidfile issues.

Should fix

8 years agobuild-sys: be more tolerant if dbus directories do not exist
Michael Biebl [Mon, 4 Mar 2013 01:13:34 +0000 (02:13 +0100)]
build-sys: be more tolerant if dbus directories do not exist

use readlink -m instead of -f since we might be building in a minimal
chroot where those directories do not actually exist and readlink -f
would return an empty string.

8 years agobuild-sys: resolve absolute path for the dbus directories
Michael Biebl [Mon, 4 Mar 2013 00:39:22 +0000 (01:39 +0100)]
build-sys: resolve absolute path for the dbus directories

/usr/share/dbus-1/system-services simply looks a lot nicer then

8 years agobuild-sys: replace backticks `` with $()
Michael Biebl [Mon, 4 Mar 2013 00:38:16 +0000 (01:38 +0100)]
build-sys: replace backticks `` with $()

for consistencies sake use $() everywhere

8 years agobuild-sys: don't hard code bash-completion directory
Michael Biebl [Sun, 3 Mar 2013 20:32:49 +0000 (21:32 +0100)]
build-sys: don't hard code bash-completion directory

8 years agobuild-sys: use $PKG_CONFIG instead of calling the pkg-config binary directly
Michael Biebl [Sun, 3 Mar 2013 20:27:44 +0000 (21:27 +0100)]
build-sys: use $PKG_CONFIG instead of calling the pkg-config binary directly

8 years agoudev: fix segfault with android rndis
Rob Clark [Sun, 3 Mar 2013 17:55:08 +0000 (12:55 -0500)]
udev: fix segfault with android rndis

The android gadget driver for network tethering over rndis somehow has a
parent device with a null subsystem.  Probably this is bug in android driver,
but it is easy enough to make systemd/udev behave gracefully and not
segfault.  And this will help for making linux distros with systemd
(like fedora) work on android devices.

8 years agoudev: remove database conversion code
Kay Sievers [Sun, 3 Mar 2013 17:35:22 +0000 (18:35 +0100)]
udev: remove database conversion code

8 years agoudev: firmware - do not created /run/udev/firmware-missing/
Kay Sievers [Sun, 3 Mar 2013 17:20:09 +0000 (18:20 +0100)]
udev: firmware - do not created /run/udev/firmware-missing/

The userspace firmware loader is deprecated now, and will be entirely
removed when we depend on a kernel version with the built-in firmware
loader available.

8 years agojournald: do not barf when setting RateLimitInterval=0
Zbigniew Jędrzejewski-Szmek [Sun, 3 Mar 2013 01:14:21 +0000 (20:14 -0500)]
journald: do not barf when setting RateLimitInterval=0

Assertion 'interval > 0 || burst == 0' failed at src/journal/journald-rate-limit.c:78, function journal_rate_limit_new(). Aborting.

8 years agocore/service: use cleanup functions, wrap lines
Zbigniew Jędrzejewski-Szmek [Sat, 2 Mar 2013 13:28:58 +0000 (08:28 -0500)]
core/service: use cleanup functions, wrap lines

8 years agocore/path: catch errors when adding watches
Zbigniew Jędrzejewski-Szmek [Sun, 3 Mar 2013 06:49:11 +0000 (01:49 -0500)]
core/path: catch errors when adding watches

Errors because of oom conditions or descriptor exhaustion should not
be ignored. We probably cannot recover from those conditions.

Current behaviour wrt. insufficient permissions is described in the
man page. It might make sense in case of user sessions, so I left
it as is.

8 years agocore/path: modernize style
Zbigniew Jędrzejewski-Szmek [Fri, 1 Mar 2013 23:04:36 +0000 (18:04 -0500)]
core/path: modernize style

8 years agocore/path: use automatic cleanup
Zbigniew Jędrzejewski-Szmek [Fri, 1 Mar 2013 22:58:56 +0000 (17:58 -0500)]
core/path: use automatic cleanup

... and fix bogus return code on malloc failure.

8 years agocore/path: fix a leak in success path
Zbigniew Jędrzejewski-Szmek [Fri, 1 Mar 2013 22:44:25 +0000 (17:44 -0500)]
core/path: fix a leak in success path

... and use automatic cleanup.

8 years agoUpdate TODO
Michael Biebl [Sun, 3 Mar 2013 13:40:49 +0000 (14:40 +0100)]
Update TODO

8 years agobash-completion: split completions and move to new location
Michael Biebl [Sat, 2 Mar 2013 21:34:01 +0000 (22:34 +0100)]
bash-completion: split completions and move to new location

Split the large bash completion script into separate, smaller files each
named after the binary it is used for and move the files to
/usr/share/bash-completion/completions. This way the completions can be
loaded on demand and we only install the completions for the tools we
actually build. The old path /etc/bash_completion.d/ is deprecated and
will disappear in the future.

8 years agojob: print the "OK" status messages in normal green
Michal Schmidt [Sat, 2 Mar 2013 12:16:27 +0000 (13:16 +0100)]
job: print the "OK" status messages in normal green

The "OK" status messages should not draw attention to themselves.
It's better if they're not printed in bright/bold. Leave that
to errors and warnings.

Use a plain inconspicuous enterprisey green.

8 years agomanager: turn a superfluous check into assert
Michal Schmidt [Sat, 2 Mar 2013 11:44:41 +0000 (12:44 +0100)]
manager: turn a superfluous check into assert

The crash that the check prevented has been fixed by commit 9e9e2b7.

8 years agounit: count deserialized job only after it's definitely installed
Michal Schmidt [Sat, 2 Mar 2013 11:29:04 +0000 (12:29 +0100)]
unit: count deserialized job only after it's definitely installed

Installation of a deserialized job may fail (though purely in theory),
so increase the running job counter only when succeeding.

8 years agoinitrd: add unit files needed for basic systemd-in-initrd support
Tom Gundersen [Sun, 24 Feb 2013 16:40:36 +0000 (17:40 +0100)]
initrd: add unit files needed for basic systemd-in-initrd support

This will:
 * mount all configured filesystems (typically the rootfs on /sysroot)
 * reload the configuration to pick up anything from the mounted fs (typically
 * mount any newly configured filesystems (typically /usr on /sysroot/usr, if
 * shut-down and clean-up any daemons running in the initramfs (typically udevd)
 * switch-root to /sysroot and start the real init

For an example of what files should be included in an initramfs based on this

Cc: Harald Hoyer <>
Cc: Dave Reisner <>
8 years agofstab-generator: initrd - mount selected entries from /sysroot/etc/fstab
Tom Gundersen [Fri, 22 Feb 2013 10:52:36 +0000 (11:52 +0100)]
fstab-generator: initrd - mount selected entries from /sysroot/etc/fstab

We only mount "/usr" and entries marked with "x-initrd.mount".

This (together with the right unit files) is needed in the initramfs in order to
natively support mounting /usr (and friends) from the initramfs.

The way it is meant to work is:
 * wait for sysroot.mount to be mounted
 * do a daemon-reload to generate sysroot-usr.mount (++) from /sysroot/etc/fstab
 * wait for sysroot-usr.mount to be mounted
 * switch-root

Cc: Harald Hoyer <>
Cc: Dave Reisner <>
8 years agosystemctl: check if iterator was initialized succesfully
Lukas Nykryn [Fri, 1 Mar 2013 17:29:58 +0000 (18:29 +0100)]
systemctl: check if iterator was initialized succesfully

8 years agomanager: print p and then free it
Lukas Nykryn [Fri, 1 Mar 2013 17:30:01 +0000 (18:30 +0100)]
manager: print p and then free it

8 years agosystemd-analyze: free unit_times only if it is not NULL
Lukas Nykryn [Fri, 1 Mar 2013 17:30:00 +0000 (18:30 +0100)]
systemd-analyze: free unit_times only if it is not NULL

8 years agosystemd-python: add missing check for return of PyDict_SetItem in _reader.c
Lukas Nykryn [Fri, 1 Mar 2013 17:29:57 +0000 (18:29 +0100)]
systemd-python: add missing check for return of PyDict_SetItem in _reader.c

8 years agofstab-generator: drop rootwait support
Tom Gundersen [Fri, 1 Mar 2013 20:15:51 +0000 (21:15 +0100)]
fstab-generator: drop rootwait support

I originally added this to stay as compatible as possible with the kernel, but
as Lennart argued it is not really useful in the initramfs, so let's drop it (we
already don't support 'rootdealy').

8 years agoupdate TODO
Lennart Poettering [Fri, 1 Mar 2013 18:21:47 +0000 (19:21 +0100)]
update TODO

8 years agoinhibit: make the output more readable
Mantas Mikulėnas [Sun, 17 Feb 2013 19:00:34 +0000 (21:00 +0200)]
inhibit: make the output more readable

The columnar output can become pretty horrible. When GNOME inhibits
power/suspend/hibernate keys, the "WHAT" column's text extends to "WHO"
and even "WHY". At the same time, all texts in "WHY" are of the form

    GNOME handlin...sses
    Receiving sle...ions
    GNOME needs t...reen

This patch splits each inhibit entry into four lines, allowing the full
text to fit in a normal-width terminal.

8 years agocoredump: bump coredump truncation size from 24M to 768M
Lennart Poettering [Fri, 1 Mar 2013 14:19:00 +0000 (15:19 +0100)]
coredump: bump coredump truncation size from 24M to 768M

In the long run we really should make this runtime configurable.

8 years agocore: fix running jobs counters after reload/reexec
Michal Schmidt [Fri, 1 Mar 2013 13:47:46 +0000 (14:47 +0100)]
core: fix running jobs counters after reload/reexec

All active units will call unit_notify() during coldplug, so we just
make sure we're counting from zero again and get the correct result for

For n_running_jobs we likewise reset it to zero and then count
the running jobs as we encounter them in deserialization.

8 years agofstab-generator: set "ro" as default for sysroot.mount
Harald Hoyer [Fri, 1 Mar 2013 16:49:06 +0000 (17:49 +0100)]
fstab-generator: set "ro" as default for sysroot.mount

8 years agofstab-generator: fix commit 92094b7
Harald Hoyer [Fri, 1 Mar 2013 16:05:58 +0000 (17:05 +0100)]
fstab-generator: fix commit 92094b7

8 years agounit: fix the race in deserialization.
Oleksii Shevchuk [Wed, 13 Feb 2013 22:49:26 +0000 (00:49 +0200)]
unit: fix the race in deserialization.

unit_notify is fired in deserelization code (particulary in
service_set_state). Units passed in random order, and there is possibility,
that unit with StopWhenUnneeded=yes passed before it actual dependecies. In
that case unit will be stopped as unneeded, because deps in UNIT_INACTIVE state

So, reuse similar logic (unit.c:1421) to avoid this race