chiark / gitweb /
8 years agodhcp-network: remove TODO
Michal Sekletar [Wed, 18 Jun 2014 16:14:51 +0000 (18:14 +0200)]
dhcp-network: remove TODO

There is no need to explicitly check version of L3 protocol in the
ethernet header because we bind socket with .sll_protocol set to
ETH_P_IP, thus we only receive IPv4 packets on the socket.

8 years agohwdb: Update database of Bluetooth company identifiers
Marcel Holtmann [Wed, 18 Jun 2014 11:55:32 +0000 (13:55 +0200)]
hwdb: Update database of Bluetooth company identifiers

8 years agoTODO: update
Kay Sievers [Wed, 18 Jun 2014 01:46:44 +0000 (03:46 +0200)]
TODO: update

8 years agorules: add loop-control and btrfs-control to "disk" group
Kay Sievers [Wed, 18 Jun 2014 01:37:32 +0000 (03:37 +0200)]
rules: add loop-control and btrfs-control to "disk" group

8 years agocryptsetup: introduce new cryptsetup-pre.traget unit so that services can make sure...
Lennart Poettering [Tue, 17 Jun 2014 22:07:56 +0000 (00:07 +0200)]
cryptsetup: introduce new cryptsetup-pre.traget unit so that services can make sure they are started before and stopped after any LUKS setup

8 years agotmpfiles: create directories already with the right label, instead of creating them...
Lennart Poettering [Tue, 17 Jun 2014 22:02:08 +0000 (00:02 +0200)]
tmpfiles: create directories already with the right label, instead of creating them first, and relabeling them afterwards

8 years agotmpfiles: w lines should allow following symlinks
Lennart Poettering [Tue, 17 Jun 2014 22:01:39 +0000 (00:01 +0200)]
tmpfiles: w lines should allow following symlinks

8 years agoupdate TODO
Lennart Poettering [Tue, 17 Jun 2014 22:01:07 +0000 (00:01 +0200)]
update TODO

8 years agonamespace: properly label device nodes we create
Lennart Poettering [Tue, 17 Jun 2014 21:51:21 +0000 (23:51 +0200)]
namespace: properly label device nodes we create

8 years agotmpfiles: add "+" modifier support to b, c, p lines in addition to L
Lennart Poettering [Tue, 17 Jun 2014 21:50:22 +0000 (23:50 +0200)]
tmpfiles: add "+" modifier support to b, c, p lines in addition to L

8 years agoman: fix typo
Zbigniew Jędrzejewski-Szmek [Sat, 7 Jun 2014 20:37:50 +0000 (16:37 -0400)]
man: fix typo

8 years agobuild-sys: add missing backslash
Ronny Chevalier [Tue, 17 Jun 2014 17:26:14 +0000 (19:26 +0200)]
build-sys: add missing backslash

8 years agonetworkd: veth - fix parsing verification
Tom Gundersen [Tue, 17 Jun 2014 17:42:30 +0000 (19:42 +0200)]
networkd: veth - fix parsing verification

8 years agonetworkd: vxlan - fix parsing verification
Tom Gundersen [Tue, 17 Jun 2014 17:40:40 +0000 (19:40 +0200)]
networkd: vxlan - fix parsing verification

8 years agonetworkd: veth - fix memleak
Tom Gundersen [Tue, 17 Jun 2014 17:40:12 +0000 (19:40 +0200)]
networkd: veth - fix memleak

8 years agoinstall: remove unused variable
Thomas Hindoe Paaboel Andersen [Tue, 17 Jun 2014 19:22:01 +0000 (21:22 +0200)]
install: remove unused variable

8 years agotmpfiles: remove line for automatic clean-ups for /var/cache/man/
Lennart Poettering [Tue, 17 Jun 2014 10:58:32 +0000 (12:58 +0200)]
tmpfiles: remove line for automatic clean-ups for /var/cache/man/

Management of /var/cache/man should move to the distribution package
owning the directory (for example, man-db). As man pages are a
non-essential part of the system and unnecessary for minimal setups,
there's no point in having systemd ship these lines.

Distribution packages should make sure the appropriate package for their
distribution adopts this line. Ideally, the line is adopted by the
upstream package.

For Fedora I have filed this bug:

8 years agobootchart: set white background
Frederic Crozat [Mon, 16 Jun 2014 16:49:12 +0000 (18:49 +0200)]
bootchart: set white background

 In programs like eog and gimp the transparant background did not
look very good.

Similar fix from the one done in systemd-analyze (418e3750)

8 years agonetworkd: link - fix carrier check on new link
Tom Gundersen [Tue, 17 Jun 2014 06:54:44 +0000 (08:54 +0200)]
networkd: link - fix carrier check on new link

We were comparing against our own internal enum rather than the kernel exposed one.

Found by Thomas Ritter.

8 years agosd-dhcp: checksum - make endianess-neutral
Tom Gundersen [Mon, 16 Jun 2014 13:24:28 +0000 (15:24 +0200)]
sd-dhcp: checksum - make endianess-neutral

For efficiency, we group bytes together before adding them up. This
is guaranteed to always work (regardless of the byte order) as long
as the i-th byte in each group lign up with the i-th byte in each
other group.

On big-endian machines this broke when handling the trailing few bytes
which did not make up a full group of 4 bytes. This patch fixes the
problem by explicitly creating a 4 byte zero-padded group out of the
trailing bytes.

Reported and tested by Thomas Ritter <>.

8 years agosystemctl: reverse order of args when verbosely creating symlinks
Dave Reisner [Tue, 17 Jun 2014 03:29:27 +0000 (23:29 -0400)]
systemctl: reverse order of args when verbosely creating symlinks

This was backwards. The symlink itself points to the source unit, not
the other way around.

8 years agotimesyncd: do not start in virtualized environments
Kay Sievers [Tue, 17 Jun 2014 01:34:09 +0000 (03:34 +0200)]
timesyncd: do not start in virtualized environments

8 years agoupdate TODO
Lennart Poettering [Tue, 17 Jun 2014 01:30:11 +0000 (03:30 +0200)]
update TODO

8 years agocore: populate unit file set with preset data if we boot with empty /etc
Lennart Poettering [Tue, 17 Jun 2014 01:25:34 +0000 (03:25 +0200)]
core: populate unit file set with preset data if we boot with empty /etc

8 years agomachine-id-setup: allow passing NULL as function argument, for simplicity
Lennart Poettering [Tue, 17 Jun 2014 01:25:02 +0000 (03:25 +0200)]
machine-id-setup: allow passing NULL as function argument, for simplicity

8 years agokmod: conditionalize kmod setup on CAP_SYS_MODULE, not whether we run in a container
Lennart Poettering [Tue, 17 Jun 2014 01:23:23 +0000 (03:23 +0200)]
kmod: conditionalize kmod setup on CAP_SYS_MODULE, not whether we run in a container

It's generally preferrable to conditionalize on the actual ability to do
something then the context we run in.

8 years agobuild-sys: touch /usr on "make install"
Lennart Poettering [Tue, 17 Jun 2014 01:09:27 +0000 (03:09 +0200)]
build-sys: touch /usr on "make install"

this way, the "make install" will be detected as offline update on next

8 years agounits: minor cleanups
Lennart Poettering [Tue, 17 Jun 2014 00:18:33 +0000 (02:18 +0200)]
units: minor cleanups

8 years agoinstall: improve paths we show the user when enabling/disabling
Lennart Poettering [Tue, 17 Jun 2014 00:15:03 +0000 (02:15 +0200)]
install: improve paths we show the user when enabling/disabling

8 years agonetworkd: don't pull in systemd-networkd-wait-online service from systemd-networkd...
Lennart Poettering [Tue, 17 Jun 2014 00:13:08 +0000 (02:13 +0200)]
networkd: don't pull in systemd-networkd-wait-online service from systemd-networkd when enabling

networkd-wait-online should never exist in the default transaction,
unless explicitly enable or pulled in via things like NFS. However, just
enabling networkd shouldn't enable networkd-wait-online, since it's
common to use the former without the latter.

8 years agoconf-files: fix when for --root= logic
Lennart Poettering [Mon, 16 Jun 2014 23:56:44 +0000 (01:56 +0200)]
conf-files: fix when for --root= logic

This is based on parts of similar patches from Michael Marineau and
Lukas Nykrin, but simply uses strappenda3().

8 years agosystemctl: output human readable strings in "systemctl enable" and "systemctl disable"
Lennart Poettering [Mon, 16 Jun 2014 23:38:07 +0000 (01:38 +0200)]
systemctl: output human readable strings in "systemctl enable" and "systemctl disable"

8 years agoinstall: simplify symlink --root= logic
Lennart Poettering [Mon, 16 Jun 2014 23:37:54 +0000 (01:37 +0200)]
install: simplify symlink --root= logic

8 years agoinstall: "systemctl enable" should be a nop for template units lacking a DefaultInsta...
Lennart Poettering [Mon, 16 Jun 2014 23:22:55 +0000 (01:22 +0200)]
install: "systemctl enable" should be a nop for template units lacking a DefaultInstance= setting

8 years agopreset: ship a minimal preset file upstream
Lennart Poettering [Mon, 16 Jun 2014 23:14:44 +0000 (01:14 +0200)]
preset: ship a minimal preset file upstream

This is useful so that distros have something to base their own policy
of. It also useful to make sure that minimal installs always get useful
configuration in place.

8 years agolog: don't downgrade log level in non-PID 1 if "quiet" is passed on kernel cmdline
Lennart Poettering [Mon, 16 Jun 2014 23:05:39 +0000 (01:05 +0200)]
log: don't downgrade log level in non-PID 1 if "quiet" is passed on kernel cmdline

"debug" should apply to all tools, but "quiet" only to PID1.

8 years agoinstall: make sure that --root= mode doesn't make us consider all units outside of...
Lennart Poettering [Mon, 16 Jun 2014 22:53:49 +0000 (00:53 +0200)]
install: make sure that --root= mode doesn't make us consider all units outside of search path

8 years agoinstall: make sure "systemctl disable foobar@.service" actually removes all instances
Lennart Poettering [Mon, 16 Jun 2014 22:33:39 +0000 (00:33 +0200)]
install: make sure "systemctl disable foobar@.service" actually removes all instances

8 years agoinstall: introduce new DefaultInstance= field for [Install] sections
Lennart Poettering [Mon, 16 Jun 2014 22:15:31 +0000 (00:15 +0200)]
install: introduce new DefaultInstance= field for [Install] sections

The DefaultInstance= name is used when enabling template units when only
specifying the template name, but no instance.

Add DefaultInstance=tty1 to getty@.service, so that when the template
itself is enabled an instance for tty1 is created.

This is useful so that we "systemctl preset-all" can work properly,
because we can operate on getty@.service after finding it, and the right
instance is created.

8 years agoinstall: when looking for a unit file for enabling, search for templates only after...
Lennart Poettering [Mon, 16 Jun 2014 22:13:48 +0000 (00:13 +0200)]
install: when looking for a unit file for enabling, search for templates only after traversing all search directories

Let's always make sure to look in all search directories for the full
unit names first, before looking for templates for them.

8 years agoinstall: use symlink_atomic() instead of unlink()+symlink() when force creating a...
Lennart Poettering [Mon, 16 Jun 2014 22:11:47 +0000 (00:11 +0200)]
install: use symlink_atomic() instead of unlink()+symlink() when force creating a symlink

8 years agoinstall: various modernizations
Lennart Poettering [Mon, 16 Jun 2014 22:10:54 +0000 (00:10 +0200)]
install: various modernizations

8 years agoinstall: teach preset query logic --root= support
Lennart Poettering [Mon, 16 Jun 2014 18:33:29 +0000 (20:33 +0200)]
install: teach preset query logic --root= support

8 years agoinstall: beef up preset logic to limit to only enable or only disable, and do all...
Lennart Poettering [Mon, 16 Jun 2014 17:49:31 +0000 (19:49 +0200)]
install: beef up preset logic to limit to only enable or only disable, and do all-unit preset operations

The new "systemctl preset-all" command may now be used to put all
installed units back into the enable/disable state the vendor/admin
encoded in preset files.

Also, introduce "systemctl --preset-mode=enable-only" and "systemctl
--preset-mode=disable-only" to only apply the enable or only the disable
operations of a "systemctl preset" or "systemctl preset-all" operation.

"systemctl preset-all" implements this RFE:

8 years agoinstall: simplify and clarify disabling logic for instanced units
Lennart Poettering [Mon, 16 Jun 2014 17:48:31 +0000 (19:48 +0200)]
install: simplify and clarify disabling logic for instanced units

8 years agoinstall: various modernizations
Lennart Poettering [Mon, 16 Jun 2014 15:19:30 +0000 (17:19 +0200)]
install: various modernizations

8 years agoupdate TODO
Lennart Poettering [Mon, 16 Jun 2014 15:04:49 +0000 (17:04 +0200)]
update TODO

8 years agounit-name: various modernizations
Lennart Poettering [Mon, 16 Jun 2014 15:04:30 +0000 (17:04 +0200)]
unit-name: various modernizations

8 years agounit-name: fix detection of unit templates/instances
Lennart Poettering [Mon, 16 Jun 2014 15:01:26 +0000 (17:01 +0200)]
unit-name: fix detection of unit templates/instances

We need to check for the last dot, not the first one in a unit name, for
the suffix. Correct that.

8 years agojournal-remote: fix memleak
Thomas Hindoe Paaboel Andersen [Mon, 16 Jun 2014 21:49:10 +0000 (23:49 +0200)]
journal-remote: fix memleak

8 years agotests: unlink temp file used in test
Ronny Chevalier [Sun, 15 Jun 2014 20:47:49 +0000 (22:47 +0200)]
tests: unlink temp file used in test

8 years agotests: add tests to test-hashmap
Ronny Chevalier [Sun, 15 Jun 2014 20:46:05 +0000 (22:46 +0200)]
tests: add tests to test-hashmap

add tests for:
  - hashmap_remove_and_put
  - hashmap_first_key
  - hashmap_last
  - hashmap_steal_first_key
  - hashmap_clear_free_free

8 years agotests: add test-fdset
Ronny Chevalier [Sat, 14 Jun 2014 20:10:45 +0000 (22:10 +0200)]
tests: add test-fdset

8 years agotests: add test-socket-util
Ronny Chevalier [Sat, 14 Jun 2014 20:10:44 +0000 (22:10 +0200)]
tests: add test-socket-util

8 years agonetworkd: unref tunnel
Susant Sahani [Mon, 16 Jun 2014 06:24:34 +0000 (11:54 +0530)]
networkd: unref tunnel

Unref tunnel while shutting down

8 years agonetworkd: introduce vxlan
Susant Sahani [Mon, 16 Jun 2014 06:24:33 +0000 (11:54 +0530)]
networkd: introduce vxlan

This patch enables netwokd to create vxlan

1. File networkd networkd-vxlan.c
2. to netdev
    bool learning
    struct in_addr group
    uint64_t vxlanid;
3. VXLAN subsection and config

8 years agonetworkd: rename netdev variables
Susant Sahani [Mon, 16 Jun 2014 06:24:32 +0000 (11:54 +0530)]
networkd: rename netdev variables

Rename the netdev variables. Remove tunnel_
so that it can be reused .

8 years agosd-rtnl: add support for vxlan rtnl attributes
Susant Sahani [Mon, 16 Jun 2014 06:24:31 +0000 (11:54 +0530)]
sd-rtnl: add support for vxlan rtnl attributes

This patch adds vxlan rtnl attributes to sd-rtnl

8 years agobus-proxy: policy - ignore unsupported tags and attributes
Kay Sievers [Mon, 16 Jun 2014 14:03:30 +0000 (16:03 +0200)]
bus-proxy: policy - ignore unsupported tags and attributes

8 years agoReset signal-mask on re-exec to init=..
Ruediger Oertel [Fri, 13 Jun 2014 14:41:06 +0000 (16:41 +0200)]
Reset signal-mask on re-exec to init=..

Process 1 (aka init) needs to be started with an empty signal mask.
That includes the process 1 that's started after the initrd is finished.
When the initrd is using systemd (as it does with dracut based initrds)
then it is systemd that calls the real init.  Normally this is systemd
again, except when the user uses for instance "init=/bin/bash" on the
kernel command line.

8 years agoutil: add realloc_multiply() helper
David Herrmann [Fri, 13 Jun 2014 16:43:22 +0000 (18:43 +0200)]
util: add realloc_multiply() helper

This is similar to malloc_multiply() and friends. It is realloc() with a
multiplication-overflow check.

8 years agoutil: fix multiply-alloc helpers with size==0
David Herrmann [Fri, 13 Jun 2014 16:38:15 +0000 (18:38 +0200)]
util: fix multiply-alloc helpers with size==0

Passing 0 to malloc() is not required to return NULL. Therefore, don't
bail out if "b" is 0. This is not of importance to the existing helpers,
but the upcoming realloc_multiply() requires this. To keep consistence, we
keep the same behavior for the other helpers.

8 years agomacro: add DISABLE_WARNING_SHADOW
David Herrmann [Thu, 12 Jun 2014 15:54:48 +0000 (17:54 +0200)]

As it turns out, we cannot use _Pragma in compound-statements. Therefore,
constructs like MIN(MAX(a, b), x) will warn due to shadowed variable
declarations. The DISABLE_WARNING_SHADOW macro can be used to suppress

Note that using UNIQUE(_var) does not work either as GCC uses the last
line of a macro-expansion for __LINE__, therefore, still causing both
macros to have the same variables. We could use different variable-names
for MIN and MAX, but that just hides the problem and still fails for
MIN(something(MIN(a, b)), c).

The only working solution is to use __COUNTER__ and pass it pre-evaluated
as extra argument to a macro to use as name-prefix. This, however, makes
all these macros much more complicated so I'll go with manual

8 years agotmpfiles: add new "L+" command as stronger version of "L", that removes the destinati...
Lennart Poettering [Mon, 16 Jun 2014 11:21:07 +0000 (13:21 +0200)]
tmpfiles: add new "L+" command as stronger version of "L", that removes the destination before creating a symlink

Also, make use of this for mtab as long as mount insists on creating it
even if we invoke it with "-n".

8 years agotmpfiles: set up selinux label proeprly when creating fifos
Lennart Poettering [Mon, 16 Jun 2014 11:20:38 +0000 (13:20 +0200)]
tmpfiles: set up selinux label proeprly when creating fifos

8 years agoupdate TODO
Lennart Poettering [Mon, 16 Jun 2014 10:29:51 +0000 (12:29 +0200)]
update TODO

8 years agobuild-sys: add missing Makefile link
Lennart Poettering [Mon, 16 Jun 2014 10:29:35 +0000 (12:29 +0200)]
build-sys: add missing Makefile link

8 years agounits: add a service to invoke ldconfig on system updates at boot
Lennart Poettering [Mon, 16 Jun 2014 10:28:44 +0000 (12:28 +0200)]
units: add a service to invoke ldconfig on system updates at boot

8 years agounits: drop RefuseManualStart= from a couple of update services
Lennart Poettering [Mon, 16 Jun 2014 10:25:49 +0000 (12:25 +0200)]
units: drop RefuseManualStart= from a couple of update services

The only update service we really need to guard like this is
systemd-tmpfiles-setup.service since if invoked manually might create
/var/run/nologin and thus blocking the user from login. The other
services are pretty much idempotent and don't suffer by this problem,
hence let's simplify them.

8 years agoupdate TODO
Lennart Poettering [Sun, 15 Jun 2014 23:03:38 +0000 (01:03 +0200)]
update TODO

8 years agomount: add new SloppyOptions= setting for mount units, mapping to mount(8)'s "-s...
Lennart Poettering [Sun, 15 Jun 2014 23:02:27 +0000 (01:02 +0200)]
mount: add new SloppyOptions= setting for mount units, mapping to mount(8)'s "-s" switch

8 years agomount: tell /bin/mount to never touch /etc/mtab
Lennart Poettering [Sun, 15 Jun 2014 22:53:02 +0000 (00:53 +0200)]
mount: tell /bin/mount to never touch /etc/mtab

/etc/mtab should die die die. It's sad enough util-linux still contains
support for it, but we don't have to partake in that charade, so let's
turn this off.

This is in-line with the fact that since years we already have been
"tainting" systemd if we detect /etc/mtab not being a symlink...

Of course, util-linux is currently broken, and still touches /etc/mtab,
weven if we pass "--no-mtab" to it:

But hey, let's hope that gets fixed quickly, even if total removal of
/etc/mtab support from util-linux might not happen so quickly...

8 years agounits: bring systemd-tmpfiles-setup-dev.service closer to systemd-tmpfiles-setup...
Lennart Poettering [Sun, 15 Jun 2014 21:42:53 +0000 (23:42 +0200)]
units: bring systemd-tmpfiles-setup-dev.service closer to systemd-tmpfiles-setup.service

Among other things, order both services relative to
systemd-sysusers.service in the same direction.

8 years agotmpfiles: create /etc/resolv.conf as link to networkd's version, if it doesn't exist
Lennart Poettering [Sun, 15 Jun 2014 21:39:00 +0000 (23:39 +0200)]
tmpfiles: create /etc/resolv.conf as link to networkd's version, if it doesn't exist

If /etc/resolv.conf doesn't exist it's better than nothing to make it
point to networkd's version.

8 years agosysusers: order before tmpfiles which need the ids
Kay Sievers [Sat, 14 Jun 2014 20:16:46 +0000 (22:16 +0200)]
sysusers: order before tmpfiles which need the ids

8 years agonetworkd: link - flush all pending NEWLINK events before trying to match
Tom Gundersen [Sat, 14 Jun 2014 16:52:46 +0000 (18:52 +0200)]
networkd: link - flush all pending NEWLINK events before trying to match

We could still have an old interface name and/or mac address when libudev
tells us that the device is initialized, as the up-to-date info could still
be on its way from the kernel.

8 years agoRevert "Revert "networkd: netdev - set predictable mac address when creating netdev""
Tom Gundersen [Sat, 14 Jun 2014 13:48:16 +0000 (15:48 +0200)]
Revert "Revert "networkd: netdev - set predictable mac address when creating netdev""

This reverts (and rewrites) commit 7d95c772cba1836545459760273b13f2e01dd2a8.

The issue blocking this feature has now been fixed in the kernel, and backported
to the various stable kernels.

Our netdevs will now have stable MAC addresses, even if one is not specified.

8 years agonetworkd: netdev - allow setting MACAddress in .netdev files
Tom Gundersen [Sat, 14 Jun 2014 13:38:35 +0000 (15:38 +0200)]
networkd: netdev - allow setting MACAddress in .netdev files

It may sometimes be necessary to specify the MAC address of a netdev.
Let us set the correct one from the get-go, rather than having the
kernel generate a random one, and then change it after.

8 years agonetworkd: add assert
Tom Gundersen [Sat, 14 Jun 2014 13:03:56 +0000 (15:03 +0200)]
networkd: add assert

It should not be possible to have a DHCP lease on a link without also having
an associated network. Add assert() to avoid compiler warnings.

Reported by Thomas H. P. Andersen

8 years agonetworkd: link - check returned value from set_lease_pool
Thomas Hindoe Paaboel Andersen [Fri, 13 Jun 2014 20:00:55 +0000 (22:00 +0200)]
networkd: link - check returned value from set_lease_pool

8 years agoFix spelling mistake, scirpt --> script
Colin Ian King [Thu, 12 Jun 2014 15:41:41 +0000 (16:41 +0100)]
Fix spelling mistake, scirpt --> script

8 years agocore: don't complain at early boot if /etc/mtab is not the right symlink
Lennart Poettering [Fri, 13 Jun 2014 18:04:31 +0000 (20:04 +0200)]
core: don't complain at early boot if /etc/mtab is not the right symlink

When we boot up with an empty /etc it's ok if the symlink doesn't exist.
We will create it later with tmpfiles.

8 years agotmpfiles: always use relative symlinks from tmpfiles snippets
Lennart Poettering [Fri, 13 Jun 2014 17:56:12 +0000 (19:56 +0200)]
tmpfiles: always use relative symlinks from tmpfiles snippets

8 years agoos-release: define /usr/lib/os-release as fallback for /etc/os-release
Lennart Poettering [Fri, 13 Jun 2014 17:45:52 +0000 (19:45 +0200)]
os-release: define /usr/lib/os-release as fallback for /etc/os-release

The file should have been in /usr/lib/ in the first place, since it
describes the OS container in /usr (and not the configuration in /etc),
hence, let's support os-release files in /usr/lib as fallback if no
version in /etc exists, following the usual override logic.

A prior commit already enabled tmpfiles to create /etc/os-release as a
symlink to /usr/lib/os-release should it be missing, thus providing nice
compatibility with applications only checking in /etc.

While it's probably a good idea if all apps check both locations via a
fallback logic, it is only necessary in the early boot process, as long
as the /etc/os-release symlink has not been restored, in case we boot
with an empty /etc.

8 years agosysusers: always treat ENOENT as entry-not-found when doing NSS calls
Lennart Poettering [Fri, 13 Jun 2014 17:24:11 +0000 (19:24 +0200)]
sysusers: always treat ENOENT as entry-not-found when doing NSS calls

For most NSS calls it is documented that they return NULL + errno=0 when
an entry is not found. However, in reality it appears to be common to
return NULL + errno=ENOENT, instead. Handle that correctly, and don't
consider ENOENT a systematic error.

8 years agorpm: add RPM macros to apply sysusers, sysctl, and binfmt drop-ins
Lennart Poettering [Fri, 13 Jun 2014 17:18:55 +0000 (19:18 +0200)]
rpm: add RPM macros to apply sysusers, sysctl, and binfmt drop-ins

With this in place RPMs can make sure that whatever they drop in is
immeidately applied, and not delayed until next reboot.

This also moves systemd-sysusers back to /usr/bin, since hardcoding the
path to /usr/lib in the macros would mean compatibility breaks in
future, should we turn sysusers into a command that is actually OK for
people to call directly. And given that that is quite likely to happen
(since it is useful to prepare images with its --root= switch), let's
just prepare for it.

8 years agorpm: don't hardcode the binary paths in the macros, rely on $PATH
Lennart Poettering [Fri, 13 Jun 2014 17:05:22 +0000 (19:05 +0200)]
rpm: don't hardcode the binary paths in the macros, rely on $PATH

this gives us a little bit more freedom to move things around later on,
as we don't hardcode the systemd paths in old RPMs that shall work with
new systemds.

8 years agosd-dhcp-server: test - skip when lacking perms
Tom Gundersen [Fri, 13 Jun 2014 17:11:31 +0000 (19:11 +0200)]
sd-dhcp-server: test - skip when lacking perms

8 years agoinstall: fix invalid free() in unit_file_mask()
Andreas Henriksson [Fri, 13 Jun 2014 16:48:18 +0000 (18:48 +0200)]
install: fix invalid free() in unit_file_mask()

int unit_file_mask(...) in ./src/shared/install.c calls
get_config_path(...) which can in 4 error cases return without setting
"ret", and thus "prefix" can be uninitialized when unit_file_mask(...)
finishes (which it does directly after the error is returned from

8 years agoudev: fix invalid free() in enable_name_policy()
Andreas Henriksson [Fri, 13 Jun 2014 16:48:21 +0000 (18:48 +0200)]
udev: fix invalid free() in enable_name_policy()

static bool enable_name_policy(...) in ./src/udev/net/link-config.c
calls proc_cmdline(...) to get "line" initialized, but
proc_cmdline(...) does not guarantee that atleast when both
conditions (detect_container(NULL) > 0) and
read_full_file(...) returned < 0.

8 years agocore: fix invalid free() in killall()
Andreas Henriksson [Fri, 13 Jun 2014 16:48:19 +0000 (18:48 +0200)]
core: fix invalid free() in killall()

static int killall(....) in ./src/core/killall.c tries to get "s"
initialized by calling get_process_comm(...) which calls
read_one_line_file(...) which if it fails will mean it is left
It is then used in argument to strna(s) call where it is
dereferenced(!), in addition to nothing else initializing it before
the scope it is in finishes.

8 years agosd-dhcp-client: fix invalid free() in client_send_request()
Andreas Henriksson [Fri, 13 Jun 2014 16:48:20 +0000 (18:48 +0200)]
sd-dhcp-client: fix invalid free() in client_send_request()

static int client_send_request(...) in
./src/libsystemd-network/sd-dhcp-client.c tries to initialize
"request" by calling client_message_init(...), which has atleast
5 error cases where it can return without that happening.
This leads to the function finishing without "request" being initialized.

8 years agonetworkd: link - left-align debug messages
Tom Gundersen [Fri, 13 Jun 2014 16:34:34 +0000 (18:34 +0200)]
networkd: link - left-align debug messages

Still add some whitespace betwen ifname and the message to get the
messages aligned (as I find it easier to spot specific messages this way).

8 years agonetworkd: add dhcp server support
Tom Gundersen [Wed, 5 Mar 2014 07:13:30 +0000 (08:13 +0100)]
networkd: add dhcp server support

When enabled in [Network] it will set up a dhcp server on the interface, listening
on one of its statically configured IPv4 addresses and with a fixed size pool of
leases determined from it.





In this case we will configure ve-arch-tree with the address and
hand out addresses in the range -

In the future, we should (as suggested by Lennart) introduce a syntax to pick the
server address automatically.

8 years agosd-dhcp-server: add RELEASE support
Tom Gundersen [Mon, 26 May 2014 13:18:47 +0000 (15:18 +0200)]
sd-dhcp-server: add RELEASE support

8 years agosd-dhcp-server: add dummy DECLINE support
Tom Gundersen [Mon, 26 May 2014 13:06:42 +0000 (15:06 +0200)]
sd-dhcp-server: add dummy DECLINE support

8 years agosd-dhcp-server: track bound leases
Tom Gundersen [Sun, 25 May 2014 20:07:53 +0000 (22:07 +0200)]
sd-dhcp-server: track bound leases

Make sure we don't hand out the same IP twice. We still don't
handle lease expiry.

8 years agosd-dhcp-server: add support for clients requesting lease lifetime
Tom Gundersen [Sun, 25 May 2014 19:47:38 +0000 (21:47 +0200)]
sd-dhcp-server: add support for clients requesting lease lifetime

8 years agosd-dhcp-server: add basic NAK support
Tom Gundersen [Sun, 25 May 2014 18:39:02 +0000 (20:39 +0200)]
sd-dhcp-server: add basic NAK support

8 years agosd-dhcp-server: add basic REQUEST/ACK support
Tom Gundersen [Sun, 25 May 2014 16:28:03 +0000 (18:28 +0200)]
sd-dhcp-server: add basic REQUEST/ACK support