From: Daniel Mack <zonque@gmail.com>
Date: Tue, 19 Aug 2014 20:08:54 +0000 (+0200)
Subject: memfd: skip utf-8 escaping if we use a name that was passed in
X-Git-Tag: v216~16
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=ea47ff669723739e62a9bce6599b0346e464c08f

memfd: skip utf-8 escaping if we use a name that was passed in

If a name was passed in as function argument, trust it, and don't do utf-8
encoding for them. Callers are obliged to check the names themselves, and
escape them in case they use anything they got from the outside world.
---

diff --git a/src/shared/memfd.c b/src/shared/memfd.c
index e335c0c18..c21642f49 100644
--- a/src/shared/memfd.c
+++ b/src/shared/memfd.c
@@ -54,13 +54,7 @@ int memfd_new(const char *name) {
                 if (isempty(pr))
                         name = "sd";
                 else {
-                        _cleanup_free_ char *e = NULL;
-
-                        e = utf8_escape_invalid(pr);
-                        if (!e)
-                                return -ENOMEM;
-
-                        g = strappend("sd-", e);
+                        g = strappend("sd-", pr);
                         if (!g)
                                 return -ENOMEM;