From: Michal Schmidt Date: Sat, 2 Mar 2013 11:44:41 +0000 (+0100) Subject: manager: turn a superfluous check into assert X-Git-Tag: v198~113 X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=e970a72e94413d9011d510c97eadfdc85c96ccc0 manager: turn a superfluous check into assert The crash that the check prevented has been fixed by commit 9e9e2b7. --- diff --git a/src/core/manager.c b/src/core/manager.c index d976581c9..91d773c2f 100644 --- a/src/core/manager.c +++ b/src/core/manager.c @@ -269,8 +269,9 @@ static void manager_print_jobs_in_progress(Manager *m) { if (j->state == JOB_RUNNING && counter++ == print_nr) break; - if (!j) - return; + /* m->n_running_jobs must be consistent with the contents of m->jobs, + * so the above loop must have succeeded in finding j. */ + assert(counter == print_nr + 1); cylon_pos = m->jobs_in_progress_iteration % 14; if (cylon_pos >= 8)