From: Tom Gundersen <teg@jklm.no>
Date: Sun, 13 Apr 2014 20:10:34 +0000 (+0200)
Subject: networkd: link - ignore missing MAC address from NEWLINK message
X-Git-Tag: v213~406
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=e9189a1f56e5dd418d13dfcf3a7f5a701884858e

networkd: link - ignore missing MAC address from NEWLINK message

The kernel may broadcast such messages, simply discard them.
---

diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index 7f81538..927dbb1 100644
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
@@ -1490,10 +1490,10 @@ int link_update(Link *link, sd_rtnl_message *m) {
                                        PRIu16, link->original_mtu);
         }
 
+        /* The kernel may broadcast NEWLINK messages without the MAC address
+           set, simply ignore them. */
         r = sd_rtnl_message_read_ether_addr(m, IFLA_ADDRESS, &mac);
-        if (r < 0)
-                log_debug_link(link, "Could not get MAC address: %s", strerror(-r));
-        else {
+        if (r >= 0) {
                 if (memcmp(link->mac.ether_addr_octet, mac.ether_addr_octet, ETH_ALEN)) {
 
                         memcpy(link->mac.ether_addr_octet, mac.ether_addr_octet, ETH_ALEN);