From: Andreas Henriksson <andreas@fatal.se>
Date: Tue, 16 Sep 2014 19:36:26 +0000 (+0200)
Subject: shared: fix resource leak in config_parse_default_instance
X-Git-Tag: v217~550
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=d9ab174bd7ec1dd5b382d3d84737d1c9ed1f4481

shared: fix resource leak in config_parse_default_instance

The recently allocated "printed" is not freed on error path.

Found by coverity. Fixes: CID#1237745
---

diff --git a/src/shared/install.c b/src/shared/install.c
index 5d3fcf5e3..61e572bdf 100644
--- a/src/shared/install.c
+++ b/src/shared/install.c
@@ -1025,8 +1025,10 @@ static int config_parse_default_instance(
         if (r < 0)
                 return r;
 
-        if (!unit_instance_is_valid(printed))
+        if (!unit_instance_is_valid(printed)) {
+                free(printed);
                 return -EINVAL;
+        }
 
         free(i->default_instance);
         i->default_instance = printed;