From: Lennart Poettering <lennart@poettering.net>
Date: Sun, 22 Apr 2012 00:03:08 +0000 (+0200)
Subject: loginctl: avoid segfault for kill-session and kill-user commands
X-Git-Tag: v183~223
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=cc1368e3b3585ab822d76e00945ed4c064047530;ds=sidebyside

loginctl: avoid segfault for kill-session and kill-user commands

As reported by Mantas Mikulėnas.

http://lists.freedesktop.org/archives/systemd-devel/2012-April/004993.html
---

diff --git a/src/login/loginctl.c b/src/login/loginctl.c
index 3ec8057d3..18f56f012 100644
--- a/src/login/loginctl.c
+++ b/src/login/loginctl.c
@@ -1260,7 +1260,7 @@ static int kill_session(DBusConnection *bus, char **args, unsigned n) {
                 if (!dbus_message_append_args(m,
                                               DBUS_TYPE_STRING, &args[i],
                                               DBUS_TYPE_STRING, &arg_kill_who,
-                                              DBUS_TYPE_INT32, arg_signal,
+                                              DBUS_TYPE_INT32, &arg_signal,
                                               DBUS_TYPE_INVALID)) {
                         log_error("Could not append arguments to message.");
                         ret = -ENOMEM;
@@ -1464,7 +1464,7 @@ static int kill_user(DBusConnection *bus, char **args, unsigned n) {
                 u = (uint32_t) uid;
                 if (!dbus_message_append_args(m,
                                               DBUS_TYPE_UINT32, &u,
-                                              DBUS_TYPE_INT32, arg_signal,
+                                              DBUS_TYPE_INT32, &arg_signal,
                                               DBUS_TYPE_INVALID)) {
                         log_error("Could not append arguments to message.");
                         ret = -ENOMEM;