From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 9 Jul 2010 22:55:44 +0000 (+0200)
Subject: systemctl: show connection counters only for Accept=yes sockets
X-Git-Tag: v3~67
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=b8131a87ccdd9376882ca0a8dd3cfe45172e4c46

systemctl: show connection counters only for Accept=yes sockets
---

diff --git a/fixme b/fixme
index 37c6288d7..cd5a23f98 100644
--- a/fixme
+++ b/fixme
@@ -39,8 +39,6 @@
 
 * pull in umount.target and shutdown.target from emergency.service (?)
 
-* Don't show Accepted/Connected for non-Accept sockets
-
 * Show exit status auf auxiliary programs in systemctl status
 
 External:
diff --git a/src/systemctl.c b/src/systemctl.c
index 031433790..dc6fb5ea4 100644
--- a/src/systemctl.c
+++ b/src/systemctl.c
@@ -947,6 +947,7 @@ typedef struct UnitStatusInfo {
         /* Socket */
         unsigned n_accepted;
         unsigned n_connections;
+        bool accept;
 
         /* Device */
         const char *sysfs_path;
@@ -997,7 +998,7 @@ static void print_status_info(UnitStatusInfo *i) {
         if (i->status_text)
                 printf("\t  Status: \"%s\"\n", i->status_text);
 
-        if (i->id && endswith(i->id, ".socket"))
+        if (i->accept)
                 printf("\tAccepted: %u; Connected: %u\n", i->n_accepted, i->n_connections);
 
         if (i->main_pid > 0 || i->control_pid > 0) {
@@ -1093,6 +1094,17 @@ static int status_property(const char *name, DBusMessageIter *iter, UnitStatusIn
                 break;
         }
 
+        case DBUS_TYPE_BOOLEAN: {
+                dbus_bool_t b;
+
+                dbus_message_iter_get_basic(iter, &b);
+
+                if (streq(name, "Accept"))
+                        i->accept = b;
+
+                break;
+        }
+
         case DBUS_TYPE_UINT32: {
                 uint32_t u;