From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 21 Aug 2014 14:17:02 +0000 (+0200)
Subject: service: asynchronous_close() already checks for negative parameters, no need to... 
X-Git-Tag: v217~805
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=abb4c1cc0161cc6b371ee7ea2550df17a3bfc21e

service: asynchronous_close() already checks for negative parameters, no need to duplicate that
---

diff --git a/src/core/service.c b/src/core/service.c
index 887b1c851..008e81437 100644
--- a/src/core/service.c
+++ b/src/core/service.c
@@ -180,9 +180,6 @@ static int service_set_main_pid(Service *s, pid_t pid) {
 static void service_close_socket_fd(Service *s) {
         assert(s);
 
-        if (s->socket_fd < 0)
-                return;
-
         s->socket_fd = asynchronous_close(s->socket_fd);
 }