From: Florian Zumbiehl <florz@florz.de>
Date: Sun, 6 Sep 2009 15:28:26 +0000 (+0200)
Subject: udev_queue_get_seqnum_sequence_is_finished(): fix possible file handle leak
X-Git-Tag: 174~787
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=9e6273c713c5a4b4317decca33d2fba830562ff2

udev_queue_get_seqnum_sequence_is_finished(): fix possible file handle leak
---

diff --git a/libudev/libudev-queue.c b/libudev/libudev-queue.c
index 68efba0ee..f06c9e8a7 100644
--- a/libudev/libudev-queue.c
+++ b/libudev/libudev-queue.c
@@ -360,10 +360,14 @@ int udev_queue_get_seqnum_sequence_is_finished(struct udev_queue *udev_queue,
 		return 1;
 	if (start < seqnum)
 		start = seqnum;
-	if (start > end)
+	if (start > end) {
+		fclose(queue_file);
 		return 1;
-	if (end - start > INT_MAX - 1)
+	}
+	if (end - start > INT_MAX - 1) {
+		fclose(queue_file);
 		return -EOVERFLOW;
+	}
 	unfinished = (end - start) + 1;
 
 	while (unfinished > 0) {