From: Michal Sekletar <msekleta@redhat.com>
Date: Thu, 25 Jun 2015 14:06:40 +0000 (+0200)
Subject: install: explicitly return 0 on success
X-Git-Tag: v226.4~1^2~245
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=9481673651515ab231e64e3c0417b75a804f476e;hp=4201e24c816faa2ad7aad6ae06e9b8b69a84fdec

install: explicitly return 0 on success

Maybe there is some left-over value stored in r from previous function
call. Let's make sure we always return consistent error code when we reach end of
the function body.

Fixes following crash of test-install,

Assertion 'r == 0' failed at src/test/test-install.c:52, function main(). Aborting.
[1]    11703 abort (core dumped)  ./test-install
---

diff --git a/src/shared/install.c b/src/shared/install.c
index 559fda211..c37cf1948 100644
--- a/src/shared/install.c
+++ b/src/shared/install.c
@@ -2263,7 +2263,7 @@ int unit_file_get_list(
                 }
         }
 
-        return r;
+        return 0;
 }
 
 static const char* const unit_file_state_table[_UNIT_FILE_STATE_MAX] = {