From: Kay Sievers Date: Tue, 3 Aug 2010 13:09:46 +0000 (+0200) Subject: udev-acl: properly handle CK change events for root user X-Git-Tag: 174~394 X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=939cc18afc49ee8479572c14c7fa777646fd4add udev-acl: properly handle CK change events for root user mschmidt@redhat.com writes: > since root is treated specially, it does not do anything! > udev-acl may want to prevent removing ACLs from root, but > it must not stop the ACLs being granted to the user of the > new session. https://bugzilla.redhat.com/show_bug.cgi?id=608712 --- diff --git a/extras/udev-acl/udev-acl.c b/extras/udev-acl/udev-acl.c index ff04ec6be..f2b50051c 100644 --- a/extras/udev-acl/udev-acl.c +++ b/extras/udev-acl/udev-acl.c @@ -224,14 +224,10 @@ static int consolekit_called(const char *ck_action, uid_t *uid, uid_t *uid2, con if (s == NULL) return -1; u = strtoul(s, NULL, 10); - if (u == 0) - return 0; s = getenv("CK_SEAT_SESSION_USER_UID"); if (s == NULL) return -1; u2 = strtoul(s, NULL, 10); - if (u2 == 0) - return 0; s = getenv("CK_SEAT_OLD_SESSION_IS_LOCAL"); s2 = getenv("CK_SEAT_SESSION_IS_LOCAL"); @@ -263,12 +259,11 @@ static int consolekit_called(const char *ck_action, uid_t *uid, uid_t *uid2, con a = ACTION_ADD; u = u2; } - break; case ACTION_NONE: break; default: - g_assert_not_reached (); + g_assert_not_reached(); break; }