From: Lennart Poettering Date: Wed, 27 Jan 2010 01:15:54 +0000 (+0100) Subject: properly terminate strings with NUL byte X-Git-Tag: v1~807 X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=9164977dc65aa6396cb49611f38f2d423e120bc7;hp=f04fa1d5aa4ae76c6e95b986834b4223f51527b3 properly terminate strings with NUL byte --- diff --git a/execute.c b/execute.c index bcaa4e959..518d7a6b0 100644 --- a/execute.c +++ b/execute.c @@ -250,7 +250,6 @@ void exec_command_free_array(ExecCommand **c, unsigned n) { } } - void exec_context_dump(ExecContext *c, FILE* f, const char *prefix) { assert(c); assert(f); @@ -286,7 +285,7 @@ char *exec_command_line(ExecCommand *c) { assert(c); assert(c->argv); - k = 0; + k = 1; STRV_FOREACH(a, c->argv) k += strlen(*a)+3; @@ -310,6 +309,8 @@ char *exec_command_line(ExecCommand *c) { } + *p = 0; + /* FIXME: this doesn't really handle arguments that have * spaces and ticks in them */