From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 18 Feb 2015 18:39:40 +0000 (+0100)
Subject: run: if we fail to set a property assignment then really fail
X-Git-Tag: v219.0~635
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=8962620e5e7d6a8ffde1fe363f13dd82b1a15661

run: if we fail to set a property assignment then really fail
---

diff --git a/src/run/run.c b/src/run/run.c
index 0661b3bee..32191a6ac 100644
--- a/src/run/run.c
+++ b/src/run/run.c
@@ -241,14 +241,12 @@ static int parse_argv(int argc, char *argv[]) {
                         break;
 
                 case ARG_SETENV:
-
                         if (strv_extend(&arg_environment, optarg) < 0)
                                 return log_oom();
 
                         break;
 
                 case 'p':
-
                         if (strv_extend(&arg_property, optarg) < 0)
                                 return log_oom();
 
@@ -389,11 +387,8 @@ static int transient_unit_set_properties(sd_bus_message *m, char **properties) {
                         return r;
 
                 r = bus_append_unit_property_assignment(m, *i);
-                if (r < 0) {
-                        r = sd_bus_message_append(m, "sv", 0);
-                        if (r < 0)
-                                return r;
-                }
+                if (r < 0)
+                        return r;
 
                 r = sd_bus_message_close_container(m);
                 if (r < 0)