From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 27 Oct 2014 17:09:07 +0000 (+0100)
Subject: CODING_STYLE: don't clobber arguments on failure
X-Git-Tag: v217~45
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=7f8bf08f9036de419ad14c55b61eda74c6659d3a

CODING_STYLE: don't clobber arguments on failure
---

diff --git a/CODING_STYLE b/CODING_STYLE
index 598d241b2..4439ee609 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -182,7 +182,11 @@
   is_main_thread() to detect whether the calling thread is the main
   thread.
 
-- Option parsing:
+- Command line option parsing:
   - Do not print full help() on error, be specific about the error.
   - Do not print messages to stdout on error.
   - Do not POSIX_ME_HARDER unless necessary, i.e. avoid "+" in option string.
+
+- Do not write functions that clobber call-by-reference variables on
+  failure. Use temporary variables for these cases and change the
+  passed in variables only on success.