From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 17 Jun 2010 21:26:20 +0000 (+0200)
Subject: sd-daemon: add gcc format string attribute to sd_notifyf
X-Git-Tag: v1~172
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=706243a2d250a53fadf3a0e5ab85d458a79e50c8

sd-daemon: add gcc format string attribute to sd_notifyf
---

diff --git a/fixme b/fixme
index 055fac488..1f42b7b7b 100644
--- a/fixme
+++ b/fixme
@@ -69,8 +69,6 @@
 
 * docdir für sd-daemon.[ch]
 
-* __attribute__ for sd_notifyf
-
 * convenience library
 
 Regularly:
diff --git a/src/sd-daemon.h b/src/sd-daemon.h
index 2d79082aa..20c260c40 100644
--- a/src/sd-daemon.h
+++ b/src/sd-daemon.h
@@ -41,6 +41,12 @@ extern "C" {
  * algorithms described here, if they do not want to include these two
  * source files. */
 
+#ifdef __GNUC__
+#define _sd_printf_attr_(a,b) __attribute__ ((format (printf, a, b)))
+#else
+#define _sd_printf_attr_(a,b)
+#endif
+
 /*
   Log levels for usage on stderr:
 
@@ -170,7 +176,7 @@ int sd_notify(int unset_environment, const char *state);
  *               strerror(errno),
  *               errno);
  */
-int sd_notifyf(int unset_environment, const char *format, ...);
+int sd_notifyf(int unset_environment, const char *format, ...) _sd_printf_attr_(2,3);
 
 #ifdef __cplusplus
 }