From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Tue, 30 Oct 2012 08:35:53 +0000 (+0100)
Subject: coredumpctl: add guard to options table
X-Git-Tag: v196~170
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=57ce4bd4ea3c54317490ad719fad17bc6413c3f6

coredumpctl: add guard to options table

It is not nice to segfault on unknown options :(
---

diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c
index 311c18b6a..3560534bf 100644
--- a/src/journal/coredumpctl.c
+++ b/src/journal/coredumpctl.c
@@ -143,10 +143,11 @@ static int parse_argv(int argc, char *argv[]) {
         int r, c;
 
         static const struct option options[] = {
-                { "help",         no_argument,       NULL, 'h'              },
-                { "version" ,     no_argument,       NULL, ARG_VERSION      },
-                { "no-pager",     no_argument,       NULL, ARG_NO_PAGER     },
-                { "output",       required_argument, NULL, 'o'              },
+                { "help",         no_argument,       NULL, 'h'           },
+                { "version" ,     no_argument,       NULL, ARG_VERSION   },
+                { "no-pager",     no_argument,       NULL, ARG_NO_PAGER  },
+                { "output",       required_argument, NULL, 'o'           },
+                { NULL,           0,                 NULL, 0             }
         };
 
         assert(argc >= 0);
@@ -183,6 +184,10 @@ static int parse_argv(int argc, char *argv[]) {
                         }
 
                         break;
+
+                case '?':
+                        return -EINVAL;
+
                 default:
                         log_error("Unknown option code %c", c);
                         return -EINVAL;