From: Lennart Poettering Date: Fri, 1 Jul 2011 23:44:49 +0000 (+0200) Subject: tmpfiles: don't exit with an error code if we cannot access all files X-Git-Tag: v30~66 X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=21bdae12e11ae20460715475d8a0c991f15464ac tmpfiles: don't exit with an error code if we cannot access all files This is just to avoid confusion if people use stuff like FUSE file systems or SELinux which might disallow access to files even if tmpfiles is running as root. We still log away if we cannot access a file, but we do not return a failure exit code in the end. --- diff --git a/TODO b/TODO index 92c90eec4..b999ce165 100644 --- a/TODO +++ b/TODO @@ -71,6 +71,8 @@ Features: * support notifications for services being enabled/disabled +* add support for /bin/mount -s + * GC unreferenced jobs (such as .device jobs) * add JoinControllers= to system.conf to mount certain cgroup @@ -180,6 +182,8 @@ Features: * detect LXC environment +* investigate whether the gnome pty helper should be moved into systemd, to provide cgroup support. + * Maybe store in unit files whether a service should be enabled by default on package installation (belongs into a distro pattern though, not in an upstream package's service file) diff --git a/src/tmpfiles.c b/src/tmpfiles.c index 954c3b7cf..4394f0dd5 100644 --- a/src/tmpfiles.c +++ b/src/tmpfiles.c @@ -983,15 +983,11 @@ int main(int argc, char *argv[]) { strv_free(files); } - - HASHMAP_FOREACH(i, globs, iterator) - if (process_item(i) < 0) - r = EXIT_FAILURE; + process_item(i); HASHMAP_FOREACH(i, items, iterator) - if (process_item(i) < 0) - r = EXIT_FAILURE; + process_item(i); finish: while ((i = hashmap_steal_first(items)))