From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 19 Sep 2011 23:33:48 +0000 (+0200)
Subject: service: drop broken support for X-Interactive fields in LSB headers
X-Git-Tag: v36~54
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=commitdiff_plain;h=00ca7f07825dd3d0a8820eafdd8fcdbd2c7809d9;hp=34a2dc4bfce222a6eb858bc5effab0091bf0db2e

service: drop broken support for X-Interactive fields in LSB headers

The logic never worked since reading from the boot console is useless
when a service is started after boot. Hence drop this half-baked code,
since we now have a place document incompatibilities like this.

http://www.freedesktop.org/wiki/Software/systemd/Incompatibilities
---

diff --git a/src/service.c b/src/service.c
index abd8f36bd..6f1a85e94 100644
--- a/src/service.c
+++ b/src/service.c
@@ -783,19 +783,6 @@ static int service_load_sysv_path(Service *s, const char *path) {
                                 free(short_description);
                                 short_description = d;
 
-                        } else if (startswith_no_case(t, "X-Interactive:")) {
-                                int b;
-
-                                if ((b = parse_boolean(strstrip(t+14))) < 0) {
-                                        log_warning("[%s:%u] Couldn't parse interactive flag. Ignoring.", path, line);
-                                        continue;
-                                }
-
-                                if (b)
-                                        s->exec_context.std_input = EXEC_INPUT_TTY;
-                                else
-                                        s->exec_context.std_input = EXEC_INPUT_NULL;
-
                         } else if (state == LSB_DESCRIPTION) {
 
                                 if (startswith(l, "#\t") || startswith(l, "#  ")) {