util: introduce join() to speed up simple string concatenations

diff --git a/src/load-dropin.c b/src/load-dropin.c
index d30865cbc53789a5442d9fa76e2efab49c1ce893..984a47a297da5cfe521fb36a6e9fd03028886623 100644 (file)
--- a/src/load-dropin.c
+++ b/src/load-dropin.c
@@ -78,7 +78,8 @@ static int process_dir(Unit *u, const char *unit_path, const char *name, const c
         assert(name);
         assert(suffix);
 
         assert(name);
         assert(suffix);
 

-        if (asprintf(&path, "%s/%s%s", unit_path, name, suffix) < 0)
+        path = join(unit_path, "/", name, suffix, NULL);
+        if (!path)

                 return -ENOMEM;
 
         if (u->meta.manager->unit_path_cache &&
                 return -ENOMEM;
 
         if (u->meta.manager->unit_path_cache &&

diff --git a/src/strv.c b/src/strv.c
index f15aa8736a0339a241245f01c71845f93d24d7a5..066dd09276e7aa77672b9bb98a2491657bc4abc0 100644 (file)
--- a/src/strv.c
+++ b/src/strv.c
@@ -105,7 +105,6 @@ char **strv_new_ap(const char *x, va_list ap) {
         unsigned n = 0, i = 0;
         va_list aq;
 
         unsigned n = 0, i = 0;
         va_list aq;
 

-

         if (x) {
                 n = 1;
 
         if (x) {
                 n = 1;
 

diff --git a/src/util.c b/src/util.c
index 1a61a26046b8413abb4028906c9becc441feb58d..b533b26dafc543a50abba861ef07c9f89c8cde9b 100644 (file)
--- a/src/util.c
+++ b/src/util.c
@@ -5493,6 +5493,54 @@ finish:
         return r;
 }
 
         return r;
 }
 

+char *join(const char *x, ...) {
+        va_list ap;
+        size_t l;
+        char *r, *p;
+
+        va_start(ap, x);
+
+        if (x) {
+                l = strlen(x);
+
+                for (;;) {
+                        const char *t;
+
+                        t = va_arg(ap, const char *);
+                        if (!t)
+                                break;
+
+                        l += strlen(t);
+                }
+        } else
+                l = 0;
+
+        va_end(ap);
+
+        r = new(char, l+1);
+        if (!r)
+                return NULL;
+
+        if (x) {
+                p = stpcpy(r, x);
+
+                va_start(ap, x);
+
+                for (;;) {
+                        const char *t;
+
+                        t = va_arg(ap, const char *);
+                        if (!t)
+                                break;
+
+                        p = stpcpy(p, t);
+                }
+        } else
+                r[0] = 0;
+
+        return r;
+}
+

 static const char *const ioprio_class_table[] = {
         [IOPRIO_CLASS_NONE] = "none",
         [IOPRIO_CLASS_RT] = "realtime",
 static const char *const ioprio_class_table[] = {
         [IOPRIO_CLASS_NONE] = "none",
         [IOPRIO_CLASS_RT] = "realtime",

diff --git a/src/util.h b/src/util.h
index bf5703c5aa310290199704eda0ed50f1dbc00463..eb0061cdb5dee6e5913565fa836363921d6ebea6 100644 (file)
--- a/src/util.h
+++ b/src/util.h
@@ -458,6 +458,8 @@ int dirent_ensure_type(DIR *d, struct dirent *de);
 int in_search_path(const char *path, char **search);
 int get_files_in_directory(const char *path, char ***list);
 
 int in_search_path(const char *path, char **search);
 int get_files_in_directory(const char *path, char ***list);
 

+char *join(const char *x, ...) _sentinel_;
+

 #define NULSTR_FOREACH(i, l)                                    \
         for ((i) = (l); (i) && *(i); (i) = strchr((i), 0)+1)
 
 #define NULSTR_FOREACH(i, l)                                    \
         for ((i) = (l); (i) && *(i); (i) = strchr((i), 0)+1)