chiark / gitweb /
unit: never retroactively start requisites
authorLennart Poettering <lennart@poettering.net>
Sat, 23 Mar 2013 02:16:17 +0000 (03:16 +0100)
committerLennart Poettering <lennart@poettering.net>
Sat, 23 Mar 2013 02:16:17 +0000 (03:16 +0100)
Requesites are not supposed to be auto-started afterall, they are just
checks, so don't try to be smarter here than appropriate.

Based on a patch from Michal Schmidt.

src/core/unit.c

index d43558e6df2838fcb9b7e073b0c1a96002e1cdab..711167994a89175ef1f0275a6a9dc499d5d06852 100644 (file)
@@ -1241,11 +1241,6 @@ static void retroactively_start_dependencies(Unit *u) {
                     !UNIT_IS_ACTIVE_OR_ACTIVATING(unit_active_state(other)))
                         manager_add_job(u->manager, JOB_START, other, JOB_FAIL, false, NULL, NULL);
 
-        SET_FOREACH(other, u->dependencies[UNIT_REQUISITE], i)
-                if (!set_get(u->dependencies[UNIT_AFTER], other) &&
-                    !UNIT_IS_ACTIVE_OR_ACTIVATING(unit_active_state(other)))
-                        manager_add_job(u->manager, JOB_START, other, JOB_REPLACE, true, NULL, NULL);
-
         SET_FOREACH(other, u->dependencies[UNIT_WANTS], i)
                 if (!set_get(u->dependencies[UNIT_AFTER], other) &&
                     !UNIT_IS_ACTIVE_OR_ACTIVATING(unit_active_state(other)))