chiark / gitweb /
journal: Fix syslog forwarding without CAP_SYS_ADMIN
authorChristian Seiler <christian@iwakd.de>
Tue, 13 Jan 2015 10:53:25 +0000 (11:53 +0100)
committerMartin Pitt <martin.pitt@ubuntu.com>
Wed, 21 Jan 2015 11:36:58 +0000 (12:36 +0100)
commitccf23ad5faf228d450d263d7291156a948b61af2
tree1b89e0503ce1ae597b330471bba3ae12f899d8a5
parente37b56c7355a9b84ac1e1893ab828b19aa1dc217
journal: Fix syslog forwarding without CAP_SYS_ADMIN

In case CAP_SYS_ADMIN is missing (like in containers), one cannot fake pid in
struct ucred (uid/gid are fine if CAP_SETUID/CAP_SETGID are present).

Ensure that journald will try again to forward the messages to syslog without
faking the SCM_CREDENTIALS pid (which isn't guaranteed to succeed anyway, since
it also does the same thing if the process has already exited).

With this patch, journald will no longer silently discard messages
that are supposed to be sent to syslog in these situations.

https://bugs.debian.org/775067
src/journal/journald-syslog.c