X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=udev%2Fudev-event.c;h=e10d48e13be467f267ab46bc5710a36073edb9f3;hp=a8dfff48bf0a3ce646bf1a3419f7a70552ff44b2;hb=c2e63452dda721bb7f127adefdfe444153a9bdca;hpb=dff107dc1a12538d351798d43191ae5d07d3c6d6

diff --git a/udev/udev-event.c b/udev/udev-event.c
index a8dfff48b..e10d48e13 100644
--- a/udev/udev-event.c
+++ b/udev/udev-event.c
@@ -38,18 +38,18 @@
 
 struct udev_event *udev_event_new(struct udev_device *dev)
 {
+	struct udev *udev = udev_device_get_udev(dev);
 	struct udev_event *event;
 
 	event = calloc(1, sizeof(struct udev_event));
 	if (event == NULL)
 		return NULL;
-	event->mode = 0600;
 	event->dev = dev;
-	event->udev = udev_device_get_udev(dev);
-	udev_list_init(&event->run_list);
+	event->udev = udev;
+	udev_list_init(udev, &event->run_list, false);
 	event->fd_signal = -1;
 	event->birth_usec = now_usec();
-	event->timeout_usec = 120 * 1000 * 1000;
+	event->timeout_usec = 60 * 1000 * 1000;
 	dbg(event->udev, "allocated event %p\n", event);
 	return event;
 }
@@ -58,7 +58,7 @@ void udev_event_unref(struct udev_event *event)
 {
 	if (event == NULL)
 		return;
-	udev_list_cleanup_entries(event->udev, &event->run_list);
+	udev_list_cleanup(&event->run_list);
 	free(event->tmp_node);
 	free(event->program_result);
 	free(event->name);
@@ -318,7 +318,7 @@ subst:
 			len = strlen(vbuf);
 			while (len > 0 && isspace(vbuf[--len]))
 				vbuf[len] = '\0';
-			count = udev_util_replace_chars(vbuf, UDEV_ALLOWED_CHARS_INPUT);
+			count = util_replace_chars(vbuf, UDEV_ALLOWED_CHARS_INPUT);
 			if (count > 0)
 				info(event->udev, "%i character(s) replaced\n" , count);
 			l = util_strpcpy(&s, l, vbuf);
@@ -489,11 +489,11 @@ static int spawn_exec(struct udev_event *event,
 
 	/* exec failed */
 	err = -errno;
-	err(udev, "exec of program '%s' failed\n", cmd);
+	err(udev, "failed to execute '%s' '%s': %m\n", argv[0], cmd);
 	return err;
 }
 
-static int spawn_read(struct udev_event *event,
+static void spawn_read(struct udev_event *event,
 		      const char *cmd,
 		      int fd_stdout, int fd_stderr,
 		      char *result, size_t ressize)
@@ -502,15 +502,13 @@ static int spawn_read(struct udev_event *event,
 	size_t respos = 0;
 	int fd_ep = -1;
 	struct epoll_event ep_outpipe, ep_errpipe;
-	int err = 0;
 
 	/* read from child if requested */
 	if (fd_stdout < 0 && fd_stderr < 0)
-		return 0;
+		return;
 
 	fd_ep = epoll_create1(EPOLL_CLOEXEC);
 	if (fd_ep < 0) {
-		err = -errno;
 		err(udev, "error creating epoll fd: %m\n");
 		goto out;
 	}
@@ -547,7 +545,6 @@ static int spawn_read(struct udev_event *event,
 
 			age_usec = now_usec() - event->birth_usec;
 			if (age_usec >= event->timeout_usec) {
-				err = -ETIMEDOUT;
 				err(udev, "timeout '%s'\n", cmd);
 				goto out;
 			}
@@ -560,12 +557,10 @@ static int spawn_read(struct udev_event *event,
 		if (fdcount < 0) {
 			if (errno == EINTR)
 				continue;
-			err = -errno;
 			err(udev, "failed to poll: %m\n");
 			goto out;
 		}
 		if (fdcount == 0) {
-			err  = -ETIMEDOUT;
 			err(udev, "timeout '%s'\n", cmd);
 			goto out;
 		}
@@ -589,7 +584,6 @@ static int spawn_read(struct udev_event *event,
 						respos += count;
 					} else {
 						err(udev, "'%s' ressize %zd too short\n", cmd, ressize);
-						err = -ENOBUFS;
 					}
 				}
 
@@ -606,7 +600,6 @@ static int spawn_read(struct udev_event *event,
 				}
 			} else if (ev[i].events & EPOLLHUP) {
 				if (epoll_ctl(fd_ep, EPOLL_CTL_DEL, *fd, NULL) < 0) {
-					err = -errno;
 					err(udev, "failed to remove fd from epoll: %m\n");
 					goto out;
 				}
@@ -623,7 +616,6 @@ static int spawn_read(struct udev_event *event,
 out:
 	if (fd_ep >= 0)
 		close(fd_ep);
-	return err;
 }
 
 static int spawn_wait(struct udev_event *event, const char *cmd, pid_t pid)
@@ -660,7 +652,7 @@ static int spawn_wait(struct udev_event *event, const char *cmd, pid_t pid)
 			goto out;
 		}
 		if (fdcount == 0) {
-			err(udev, "timeout: killing '%s'[%u]\n", cmd, pid);
+			err(udev, "timeout: killing '%s' [%u]\n", cmd, pid);
 			kill(pid, SIGKILL);
 		}
 
@@ -681,11 +673,20 @@ static int spawn_wait(struct udev_event *event, const char *cmd, pid_t pid)
 				if (waitpid(pid, &status, WNOHANG) < 0)
 					break;
 				if (WIFEXITED(status)) {
-					info(udev, "'%s'[%u] returned with exitcode %i\n", cmd, pid, WEXITSTATUS(status));
+					info(udev, "'%s' [%u] exit with return code %i\n", cmd, pid, WEXITSTATUS(status));
 					if (WEXITSTATUS(status) != 0)
 						err = -1;
+				} else if (WIFSIGNALED(status)) {
+					err(udev, "'%s' [%u] terminated by signal %i (%s)\n", cmd, pid, WTERMSIG(status), strsignal(WTERMSIG(status)));
+					err = -1;
+				} else if (WIFSTOPPED(status)) {
+					err(udev, "'%s' [%u] stopped\n", cmd, pid);
+					err = -1;
+				} else if (WIFCONTINUED(status)) {
+					err(udev, "'%s' [%u] continued\n", cmd, pid);
+					err = -1;
 				} else {
-					err(udev, "'%s'[%u] unexpected exit with status 0x%04x\n", cmd, pid, status);
+					err(udev, "'%s' [%u] exit with status 0x%04x\n", cmd, pid, status);
 					err = -1;
 				}
 				pid = 0;
@@ -697,6 +698,41 @@ out:
 	return err;
 }
 
+int udev_build_argv(struct udev *udev, char *cmd, int *argc, char *argv[])
+{
+	int i = 0;
+	char *pos;
+
+	if (strchr(cmd, ' ') == NULL) {
+		argv[i++] = cmd;
+		goto out;
+	}
+
+	pos = cmd;
+	while (pos != NULL && pos[0] != '\0') {
+		if (pos[0] == '\'') {
+			/* do not separate quotes */
+			pos++;
+			argv[i] = strsep(&pos, "\'");
+			if (pos != NULL)
+				while (pos[0] == ' ')
+					pos++;
+		} else {
+			argv[i] = strsep(&pos, " ");
+			if (pos != NULL)
+				while (pos[0] == ' ')
+					pos++;
+		}
+		dbg(udev, "argv[%i] '%s'\n", i, argv[i]);
+		i++;
+	}
+out:
+	argv[i] = NULL;
+	if (argc)
+		*argc = i;
+	return 0;
+}
+
 int udev_event_spawn(struct udev_event *event,
 		     const char *cmd, char **envp, const sigset_t *sigmask,
 		     char *result, size_t ressize)
@@ -706,39 +742,12 @@ int udev_event_spawn(struct udev_event *event,
 	int errpipe[2] = {-1, -1};
 	pid_t pid;
 	char arg[UTIL_PATH_SIZE];
+	char *argv[128];
 	char program[UTIL_PATH_SIZE];
-	char *argv[((sizeof(arg) + 1) / 2) + 1];
-	int i;
 	int err = 0;
 
-	/* build argv from command */
 	util_strscpy(arg, sizeof(arg), cmd);
-	i = 0;
-	if (strchr(arg, ' ') != NULL) {
-		char *pos = arg;
-
-		while (pos != NULL && pos[0] != '\0') {
-			if (pos[0] == '\'') {
-				/* do not separate quotes */
-				pos++;
-				argv[i] = strsep(&pos, "\'");
-				if (pos != NULL)
-					while (pos[0] == ' ')
-						pos++;
-			} else {
-				argv[i] = strsep(&pos, " ");
-				if (pos != NULL)
-					while (pos[0] == ' ')
-						pos++;
-			}
-			dbg(udev, "arg[%i] '%s'\n", i, argv[i]);
-			i++;
-		}
-		argv[i] = NULL;
-	} else {
-		argv[0] = arg;
-		argv[1] = NULL;
-	}
+	udev_build_argv(event->udev, arg, NULL, argv);
 
 	/* pipes from child to parent */
 	if (result != NULL || udev_get_log_priority(udev) >= LOG_INFO) {
@@ -756,7 +765,7 @@ int udev_event_spawn(struct udev_event *event,
 		}
 	}
 
-	/* allow programs in /lib/udev/ to be called without the path */
+	/* allow programs in /usr/lib/udev/ to be called without the path */
 	if (argv[0][0] != '/') {
 		util_strscpyl(program, sizeof(program), LIBEXECDIR "/", argv[0], NULL);
 		argv[0] = program;
@@ -796,9 +805,9 @@ int udev_event_spawn(struct udev_event *event,
 			errpipe[WRITE_END] = -1;
 		}
 
-		err = spawn_read(event, cmd,
-				 outpipe[READ_END], errpipe[READ_END],
-				 result, ressize);
+		spawn_read(event, cmd,
+			 outpipe[READ_END], errpipe[READ_END],
+			 result, ressize);
 
 		err = spawn_wait(event, cmd, pid);
 	}
@@ -949,10 +958,6 @@ int udev_event_execute_rules(struct udev_event *event, struct udev_rules *rules,
 			if (err == 0) {
 				info(event->udev, "renamed netif to '%s'\n", event->name);
 
-				/* delete stale db file */
-				udev_device_delete_db(dev);
-				udev_device_tag_index(dev, NULL, false);
-
 				/* remember old name */
 				udev_device_add_property(dev, "INTERFACE_OLD", udev_device_get_sysname(dev));
 
@@ -1012,9 +1017,22 @@ int udev_event_execute_rules(struct udev_event *event, struct udev_rules *rules,
 			if (event->dev_db != NULL)
 				udev_node_update_old_links(dev, event->dev_db);
 
-			/* change default 0600 to 0660 if a group is assigned */
-			if (event->mode == 0600 && event->gid > 0)
-				event->mode = 0660;
+			if (!event->mode_set) {
+				if (udev_device_get_devnode_mode(dev) > 0) {
+					/* kernel supplied value */
+					event->mode = udev_device_get_devnode_mode(dev);
+				} else if (event->gid > 0) {
+					/* default 0660 if a group is assigned */
+					event->mode = 0660;
+				} else {
+					/* default 0600 */
+					event->mode = 0600;
+				}
+			}
+
+			/* set sticky bit, so we do not remove the node on module unload */
+			if (event->static_node)
+				event->mode |= 01000;
 
 			err = udev_node_add(dev, event->mode, event->uid, event->gid);
 		}
@@ -1022,7 +1040,7 @@ int udev_event_execute_rules(struct udev_event *event, struct udev_rules *rules,
 		/* preserve old, or get new initialization timestamp */
 		if (event->dev_db != NULL && udev_device_get_usec_initialized(event->dev_db) > 0)
 			udev_device_set_usec_initialized(event->dev, udev_device_get_usec_initialized(event->dev_db));
-		else
+		else if (udev_device_get_usec_initialized(event->dev) == 0)
 			udev_device_set_usec_initialized(event->dev, now_usec());
 
 		/* (re)write database file */
@@ -1066,7 +1084,7 @@ int udev_event_execute_run(struct udev_event *event, const sigset_t *sigmask)
 			udev_event_apply_format(event, cmd, program, sizeof(program));
 			envp = udev_device_get_properties_envp(event->dev);
 			if (udev_event_spawn(event, program, envp, sigmask, NULL, 0) < 0) {
-				if (udev_list_entry_get_flags(list_entry))
+				if (udev_list_entry_get_num(list_entry))
 					err = -1;
 			}
 		}