X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=udev%2Flib%2Flibudev-monitor.c;h=b2f76c3129bf2216b333566fb53b9f12723b184a;hp=fc5b176be09f28745472e0c9aa9ffb05be114ce7;hb=116254097ad3c07d9f7ed06042dbec7ba4f0f4fd;hpb=be7de4097af70515783cd0030f5e7a7a89bbadc8

diff --git a/udev/lib/libudev-monitor.c b/udev/lib/libudev-monitor.c
index fc5b176be..b2f76c312 100644
--- a/udev/lib/libudev-monitor.c
+++ b/udev/lib/libudev-monitor.c
@@ -3,18 +3,10 @@
  *
  * Copyright (C) 2008 Kay Sievers <kay.sievers@vrfy.org>
  *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
  */
 
 #include <stdio.h>
@@ -37,6 +29,7 @@ struct udev_monitor {
 	int refcount;
 	int sock;
 	struct sockaddr_nl snl;
+	struct sockaddr_nl snl_peer;
 	struct sockaddr_un sun;
 	socklen_t addrlen;
 };
@@ -94,11 +87,11 @@ struct udev_monitor *udev_monitor_new_from_socket(struct udev *udev, const char
 		free(udev_monitor);
 		return NULL;
 	}
-	info(udev, "monitor %p created with '%s'\n", udev_monitor, socket_path);
+	dbg(udev, "monitor %p created with '%s'\n", udev_monitor, socket_path);
 	return udev_monitor;
 }
 
-struct udev_monitor *udev_monitor_new_from_netlink(struct udev *udev)
+struct udev_monitor *udev_monitor_new_from_netlink(struct udev *udev, unsigned int group)
 {
 	struct udev_monitor *udev_monitor;
 
@@ -118,10 +111,11 @@ struct udev_monitor *udev_monitor_new_from_netlink(struct udev *udev)
 	}
 
 	udev_monitor->snl.nl_family = AF_NETLINK;
-	udev_monitor->snl.nl_pid = getpid();
-	udev_monitor->snl.nl_groups = 1;
+	udev_monitor->snl.nl_groups = group;
+	udev_monitor->snl_peer.nl_family = AF_NETLINK;
+	udev_monitor->snl_peer.nl_groups = UDEV_MONITOR_UDEV;
 
-	info(udev, "monitor %p created with NETLINK_KOBJECT_UEVENT\n", udev_monitor);
+	dbg(udev, "monitor %p created with NETLINK_KOBJECT_UEVENT (%u)\n", udev_monitor, group);
 	return udev_monitor;
 }
 
@@ -131,21 +125,23 @@ int udev_monitor_enable_receiving(struct udev_monitor *udev_monitor)
 	const int on = 1;
 
 	if (udev_monitor->snl.nl_family != 0) {
-		err = bind(udev_monitor->sock, (struct sockaddr *)&udev_monitor->snl, sizeof(struct sockaddr_nl));
+		err = bind(udev_monitor->sock,
+			   (struct sockaddr *)&udev_monitor->snl, sizeof(struct sockaddr_nl));
 		if (err < 0) {
 			err(udev_monitor->udev, "bind failed: %m\n");
 			return err;
 		}
-		info(udev_monitor->udev, "monitor %p listening on netlink\n", udev_monitor);
+		dbg(udev_monitor->udev, "monitor %p listening on netlink\n", udev_monitor);
 	} else if (udev_monitor->sun.sun_family != 0) {
-		err = bind(udev_monitor->sock, (struct sockaddr *)&udev_monitor->sun, udev_monitor->addrlen);
+		err = bind(udev_monitor->sock,
+			   (struct sockaddr *)&udev_monitor->sun, udev_monitor->addrlen);
 		if (err < 0) {
 			err(udev_monitor->udev, "bind failed: %m\n");
 			return err;
 		}
 		/* enable receiving of the sender credentials */
 		setsockopt(udev_monitor->sock, SOL_SOCKET, SO_PASSCRED, &on, sizeof(on));
-		info(udev_monitor->udev, "monitor %p listening on socket\n", udev_monitor);
+		dbg(udev_monitor->udev, "monitor %p listening on socket\n", udev_monitor);
 	}
 	return 0;
 }
@@ -191,7 +187,7 @@ void udev_monitor_unref(struct udev_monitor *udev_monitor)
 		return;
 	if (udev_monitor->sock >= 0)
 		close(udev_monitor->sock);
-	info(udev_monitor->udev, "monitor %p released\n", udev_monitor);
+	dbg(udev_monitor->udev, "monitor %p released\n", udev_monitor);
 	free(udev_monitor);
 }
 
@@ -325,6 +321,8 @@ struct udev_device *udev_monitor_receive_device(struct udev_monitor *udev_monito
 		} else if (strncmp(key, "SUBSYSTEM=", 10) == 0) {
 			udev_device_set_subsystem(udev_device, &key[10]);
 			subsystem_set = 1;
+		} else if (strncmp(key, "DEVTYPE=", 8) == 0) {
+			udev_device_set_devtype(udev_device, &key[8]);
 		} else if (strncmp(key, "DEVNAME=", 8) == 0) {
 			udev_device_set_devnode(udev_device, &key[8]);
 		} else if (strncmp(key, "DEVLINKS=", 9) == 0) {
@@ -387,9 +385,18 @@ int udev_monitor_send_device(struct udev_monitor *udev_monitor, struct udev_devi
 	len = udev_device_get_properties_monitor_buf(udev_device, &buf);
 	if (len < 32)
 		return -1;
-	count = sendto(udev_monitor->sock,
-		       buf, len, 0,
-		       (struct sockaddr *)&udev_monitor->sun, udev_monitor->addrlen);
+	if (udev_monitor->sun.sun_family != 0) {
+		count = sendto(udev_monitor->sock,
+			       buf, len, 0,
+			       (struct sockaddr *)&udev_monitor->sun,
+			       udev_monitor->addrlen);
+	} else {
+		/* no destination besides the muticast group, we will always get -1 ECONNREFUSED */
+		count = sendto(udev_monitor->sock,
+			       buf, len, 0,
+			       (struct sockaddr *)&udev_monitor->snl_peer,
+			       sizeof(struct sockaddr_nl));
+	}
 	info(udev_monitor->udev, "passed %zi bytes to monitor %p, \n", count, udev_monitor);
 	return count;
 }