X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=test%2Fudev-test.pl;h=94cffeab07d9a2bb9dd77887812dcd5bae5afd55;hp=67c06727597614670f706932088fe3e384a12fcf;hb=bf375e3af65f0e9728516a3627613fb95288c1d1;hpb=b9a8c4821a98df33ba2cc5b18b15d7175709c376 diff --git a/test/udev-test.pl b/test/udev-test.pl old mode 100644 new mode 100755 index 67c067275..94cffeab0 --- a/test/udev-test.pl +++ b/test/udev-test.pl @@ -9,30 +9,24 @@ # Every test is driven by its own temporary config file. # This program prepares the environment, creates the config and calls udev. # -# udev reads the config, looks at the provided sysfs and +# udev parses the rules, looks at the provided sysfs and # first creates and then removes the device node. # After creation and removal the result is checked against the # expected value and the result is printed. # -# happy testing, # Kay Sievers , 2003 -# -# Modified April 9, 2004 by Leann Ogasawara -# - expanded @tests array to add more symlinks and permissions tests -# - some of the symlinks tests also test lack of node creation -# - added symlink_test() function -# - moved permissions and major_minor tests into their own functions +# Leann Ogasawara , 2004 use warnings; use strict; -my $PWD = $ENV{PWD}; -my $sysfs = "sys/"; -my $udev_bin = "../udev"; -my $udev_root = "udev-root/"; # !!! directory will be removed !!! -my $udev_db = ".udevdb"; -my $main_conf = "udev-test.conf"; -my $conf_tmp = "udev-test.rules"; +my $PWD = $ENV{PWD}; +my $sysfs = "sys/"; +my $udev_bin = "../udev"; +my $udev_root = "udev-root/"; # !!! directory will be removed !!! +my $udev_db = ".udevdb"; +my $udev_conf = "udev-test.conf"; +my $udev_rules = "udev-test.rules"; # uncomment following line to run udev with valgrind. # Should make this a runtime option to the script someday... @@ -44,9 +38,9 @@ my @tests = ( subsys => "block", devpath => "/block/sda", exp_name => "boot_disk" , - conf => < < "block", devpath => "/block/sda/sda1", exp_name => "boot_disk1" , - conf => < < "block", devpath => "/block/sda/sda1", exp_name => "boot_disk1" , - conf => < < "block", devpath => "/block/sda/sda1", exp_name => "boot_disk1" , - conf => < < "block", devpath => "/block/sda/sda1", exp_name => "boot_disk1" , - conf => < < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "visor/0" , - conf => < < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "visor/0" , - conf => < < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "visor/0" , - conf => < < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "visor/0" , - conf => < < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "visor" , - conf => < < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "visor" , - conf => < < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "visor" , - conf => < < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "whitespace" , - conf => < < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "visor" , - conf => < < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "visor" , - conf => < < "preserve backslashes, if they are not for a newline", + subsys => "tty", + devpath => "/class/tty/ttyUSB0", + exp_name => "aaa", + rules => < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "visor" , - conf => < < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "sub/direct/ory/visor" , - conf => < < "block", devpath => "/block/sda/sda3", exp_name => "first_disk3" , - conf => < < "test NAME substitution chars", + desc => "test substitution chars", subsys => "block", devpath => "/block/sda/sda3", exp_name => "Major:8:minor:3:kernelnumber:3:bus:0:0:0:0" , - conf => < < "test NAME substitution chars (with length limit)", + desc => "test substitution chars (with length limit)", subsys => "block", devpath => "/block/sda/sda3", exp_name => "M8-m3-n3-b0:0-sIBM" , - conf => < < "old style SYSFS_ attribute", + desc => "import of shell-value file", subsys => "block", devpath => "/block/sda", - exp_name => "good" , - conf => < "subdir/sys/node" , + rules => < "import of shell-value returned from program", + subsys => "block", + devpath => "/block/sda", + exp_name => "node12345678", + rules => < "block", devpath => "/block/sda", exp_name => "disk-IBM-ESXS-sda" , - conf => < < "block", devpath => "/block/sda/sda3", exp_name => "special-device-3" , - conf => < < "block", devpath => "/block/sda/sda3", exp_name => "subsys_block" , - conf => < < "block", devpath => "/block/sda/sda3", exp_name => "newline_removed" , - conf => < < "block", devpath => "/block/sda/sda3", exp_name => "test-0:0:0:0" , - conf => < < "block", devpath => "/block/sda/sda3", exp_name => "escape-3" , - conf => < < "block", devpath => "/block/sda/sda3", exp_name => "foo9" , - conf => < < "block", devpath => "/block/sda/sda3", exp_name => "bar9" , - conf => < < "block", devpath => "/block/sda/sda3", exp_name => "foo7" , - conf => < < "block", devpath => "/block/sda/sda3", exp_name => "my-foo9" , - conf => < < "block", devpath => "/block/sda/sda3", exp_name => "my-foo8" , - conf => < < "test substitution by variable name", + subsys => "block", + devpath => "/block/sda/sda3", + exp_name => "Major:8-minor:3-kernelnumber:3-bus:0:0:0:0" , + rules => < "test substitution by variable name 2", + subsys => "block", + devpath => "/block/sda/sda3", + exp_name => "Major:8-minor:3-kernelnumber:3-bus:0:0:0:0" , + rules => < "test substitution by variable name 3", + subsys => "block", + devpath => "/block/sda/sda3", + exp_name => "830:0:0:03" , + rules => < "test substitution by variable name 4", + subsys => "block", + devpath => "/block/sda/sda3", + exp_name => "833" , + rules => < "test substitution by variable name 5", + subsys => "block", + devpath => "/block/sda/sda3", + exp_name => "8330:0:0:0" , + rules => < "tty", devpath => "/class/tty/console", exp_name => "TTY" , - conf => < < "tty", devpath => "/class/tty/console", exp_name => "foo" , - conf => < < "tty", devpath => "/class/tty/console", exp_name => "TTY" , - conf => < < "tty", devpath => "/class/tty/console", exp_name => "foo" , - conf => < < "block", devpath => "/block/sda", exp_name => "scsi-0:0:0:0" , - conf => < < "block", devpath => "/block/sda", exp_name => "boot_disk15" , - conf => < "8:15", + rules => < "tty", devpath => "/class/tty/ttyUSB0", exp_name => "visor" , - conf => < < "block", devpath => "/block/rd!c0d0", exp_name => "rd/c0d0" , - conf => < < "block", devpath => "/block/rd!c0d0", exp_name => "rd/c0d0" , - conf => < < "block", devpath => "/block/cciss!c0d0/cciss!c0d0p1", exp_name => "cciss/c0d0p1" , - conf => < < "block", devpath => "/block/sda", exp_name => "scsi-0:0:0:0", - conf => < < "block", devpath => "/block/sda", exp_name => "scsi-0:0:0:0", - conf => < < "block", devpath => "/block/sda", exp_name => "scsi-0:0:0:0", - conf => < < "block", devpath => "/block/sda", exp_name => "scsi-0:0:0:0", - conf => < < "block", devpath => "/block/sda", exp_name => "ignored", - conf => < < "block", devpath => "/block/sda", exp_name => "matched-with-space", - conf => < < "/class/tty/tty33", exp_name => "tty33", exp_perms => "0:0:0660", - conf => < < "/block/sda", exp_name => "node", exp_perms => "5000::0660", - conf => < < "/block/sda", exp_name => "node", exp_perms => ":100:0660", - conf => < < "textual user id", + subsys => "block", + devpath => "/block/sda", + exp_name => "node", + exp_perms => "nobody::0660", + rules => < "textual group id", + subsys => "block", + devpath => "/block/sda", + exp_name => "node", + exp_perms => ":daemon:0660", + rules => < "textual user/group id", + subsys => "block", + devpath => "/block/sda", + exp_name => "node", + exp_perms => "root:mail:0660", + rules => < "/block/sda", exp_name => "node", exp_perms => "::0777", - conf => < < "/block/sda", exp_name => "node", exp_perms => "5000:100:0777", - conf => < < "/class/tty/ttyUSB0", exp_name => "ttyUSB0", exp_perms => "5000::", - conf => < < "/class/tty/ttyUSB0", exp_name => "ttyUSB0", exp_perms => ":100:0660", - conf => < < "/class/tty/ttyUSB0", exp_name => "ttyUSB0", exp_perms => "::0060", - conf => < < "/class/tty/ttyUSB0", exp_name => "ttyUSB0", exp_perms => "5000:100:0777", - conf => < < "/class/tty/ttyUSB0", exp_name => "ttyUSB0", exp_perms => "5000:100:0777", - conf => < < "/class/tty/ttyUSB0", exp_name => "ttyUSB0", exp_perms => "3000:4000:0777", - conf => < < "/class/tty/ttyUSB0", exp_name => "ttyUSB0", exp_perms => "3000:8000:0777", - conf => < < "/block/sda", exp_name => "node", exp_majorminor => "8:0", - conf => < < "/class/i2c-dev/i2c-300", exp_name => "node", exp_majorminor => "89:300", - conf => < < "/class/i2c-dev/i2c-fake1", exp_name => "node", exp_majorminor => "4095:1", - conf => < < "/class/i2c-dev/i2c-fake2", exp_name => "node", exp_majorminor => "4094:89999", - conf => < < "/class/tty/ttyUSB0", exp_name => "symlink2-ttyUSB0", exp_target => "ttyUSB0", - conf => < < "multiple symlinks with a lot of s p a c e s", + subsys => "tty", + devpath => "/class/tty/ttyUSB0", + exp_name => "one", + not_exp_name => " ", + exp_target => "ttyUSB0", + rules => < "/class/tty/ttyUSB0", exp_name => "visor0", exp_target => "ttyUSB0", - conf => < < "/block/sda/sda2", exp_name => "1/2/symlink" , exp_target => "a/b/node", - conf => < < "/block/sda/sda2", exp_name => "1/2/c/d/symlink" , exp_target => "../../a/b/node", - conf => < < "/class/tty/ttyUSB0", exp_name => "second-0" , exp_target => "visor" , - conf => < < "/block/sda", exp_name => "symlink-only2", exp_target => "link", - conf => < "symlink name empty", - subsys => "block", - devpath => "/block/sda", - exp_name => "", - exp_target => "link", - exp_error => "yes", - conf => < < "/block/sda", exp_name => ".", exp_target => "link", - exp_error => "yes", - conf => < "symlink to empty name", - subsys => "block", - devpath => "/block/sda", - exp_name => "symlink", - exp_target => "", - exp_error => "yes", - conf => < "symlink and name empty", - subsys => "block", - devpath => "/block/sda", - exp_name => "", - exp_target => "", - exp_error => "yes", - conf => < "yes", + exp_rem_error => "yes", + rules => < "/class/tty/tty0", exp_name => "link", exp_target => "link", - conf => < "yes", + option => "clean", + rules => < "/class/tty/ttyUSB0", exp_name => "symlink0", exp_target => "ttyUSB0", - conf => < < "/class/tty/ttyUSB0", exp_name => "symlink-ttyUSB0", exp_target => "ttyUSB0", - conf => < < "/class/tty/ttyUSB0", exp_name => "major-188:0", exp_target => "ttyUSB0", - conf => < < "/block/sda", exp_name => "symlink-0:0:0:0", exp_target => "node", - conf => < < "/class/tty/ttyUSB0", exp_name => "test", exp_target => "ttyUSB0", - conf => < < "/class/tty/ttyUSB0", exp_name => "test", exp_target => "ttyUSB0", - conf => < < "/class/tty/ttyUSB0", exp_name => "this", exp_target => "ttyUSB0", - conf => < < "/block/sda", exp_name => "test", exp_target => "link", - conf => < < "/class/tty/ttyUSB0", exp_name => "188:0", exp_target => "ttyUSB0", - conf => < < "/class/tty/ttyUSB0", exp_name => "188", exp_target => "ttyUSB0", - conf => < < "/class/tty/ttyUSB0", exp_name => "percent%sign", exp_target => "ttyUSB0", - conf => < < "/class/tty/ttyUSB0", exp_name => "%ttyUSB0_name", exp_target => "ttyUSB0", - conf => < < "/block/sda/sda3", exp_name => "link1", exp_target => "node", - conf => < < "/block/sda/sda3", exp_name => "link4", exp_target => "node", - conf => < < "block", devpath => "/block/sda", exp_name => "cdrom", - conf => < < "enumeration char test sequence (1/5 keep)", + desc => "enumeration char test sequence 1/5 (keep)", subsys => "block", devpath => "/block/sda", exp_name => "cdrom", option => "keep", - conf => < < "/block/sda/sda1", exp_name => "enum", option => "keep", - conf => < < "/block/sda/sda2", exp_name => "cdrom1", option => "keep", - conf => < < "/block/sda/sda3", exp_name => "enum1", option => "keep", - conf => < < "block", devpath => "/block/sda/sda4", exp_name => "cdrom2", - option => "clear", - conf => < "clean", + rules => < "block", devpath => "/block/sda", exp_name => "cdrom", - conf => < < "ignore rule test", + subsys => "block", + devpath => "/block/sda", + exp_name => "nothing", + not_exp_name => "node", + exp_add_error => "yes", + rules => < "all_partitions, option-only rule", + subsys => "block", + devpath => "/block/sda", + exp_name => "node6", + rules => < "all_partitions, option-only rule (fail on partition)", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "node6", + exp_add_error => "yes", + rules => < "block", devpath => "/block/sda", exp_name => "node", - exp_error => "yes", - conf => < "yes", + rules => < "block", devpath => "/block/sda", exp_name => "node14", - exp_error => "yes", - option => "clear", - conf => < "yes", + option => "clean", + rules => < "block", devpath => "/block/sda", exp_name => "node", - conf => < < "block", devpath => "/block/sda", exp_name => "node", - conf => < < "temporary node creation test", + subsys => "block", + devpath => "/block/sda", + exp_name => "node", + rules => < "devpath substitution test", + subsys => "block", + devpath => "/block/sda", + exp_name => "sda", + rules => < "parent node name substitution test sequence 1/2 (keep)", + subsys => "block", + devpath => "/block/sda", + exp_name => "main_device", + option => "keep", + rules => < "parent node name substitution test sequence 2/2 (clean)", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "main_device-part-1", + option => "clean", + rules => < "udev_root substitution", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "start-udev-root-end", + rules => < "last_rule option", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "last", + rules => < "negation KERNEL!=", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "match", + rules => < "negation SUBSYSTEM!=", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "not-anything", + rules => < "negation PROGRAM!= exit code", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "nonzero-program", + rules => < "test for whitespace between the operator", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "true", + rules => < "ENV{} test", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "true", + rules => < "ENV{} test", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "true", + rules => < "untrusted string sanitize", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "sane", + rules => < "read sysfs value from device down in the chain", + subsys => "block", + devpath => "/class/tty/ttyUSB0", + exp_name => "serial-0000:00:09.0", + rules => < "match against empty key string", + subsys => "block", + devpath => "/block/sda", + exp_name => "ok", + rules => < "check ACTION value", + subsys => "block", + devpath => "/block/sda", + exp_name => "ok", + rules => < "apply NAME only once", + subsys => "block", + devpath => "/block/sda", + exp_name => "link", + exp_target => "ok", + rules => < "test RUN key", + subsys => "block", + devpath => "/block/sda", + exp_name => "testsymlink", + exp_target => "ok", + exp_rem_error => "yes", + option => "clean", + rules => < "test RUN key and DEVNAME", + subsys => "block", + devpath => "/block/sda", + exp_name => "testsymlink", + exp_target => "ok", + exp_rem_error => "yes", + option => "clean", + rules => < "test RUN key remove", + subsys => "block", + devpath => "/block/sda", + exp_name => "testsymlink2", + exp_target => "ok2", + rules => < "final assignment", + subsys => "block", + devpath => "/block/sda", + exp_name => "ok", + exp_perms => "root:nobody:0640", + rules => < "final assignment", + subsys => "block", + devpath => "/block/sda", + exp_name => "ok", + exp_perms => "root:nobody:0640", + rules => < "env substitution", + subsys => "block", + devpath => "/block/sda", + exp_name => "node-add-me", + rules => < "reset list to current value", + subsys => "tty", + devpath => "/class/tty/ttyUSB0", + exp_name => "three", + not_exp_name => "two", + exp_target => "node", + rules => < "test empty NAME", + subsys => "tty", + devpath => "/class/tty/ttyUSB0", + exp_name => "node", + not_exp_name => "wrong", + exp_add_error => "yes", + rules => < "test empty NAME 2", + subsys => "tty", + devpath => "/class/tty/ttyUSB0", + exp_name => "right", + rules => < "test multi matches", + subsys => "tty", + devpath => "/class/tty/ttyUSB0", + exp_name => "right", + rules => < "test multi matches 2", + subsys => "tty", + devpath => "/class/tty/ttyUSB0", + exp_name => "right", + rules => < "IMPORT parent test sequence 1/2 (keep)", + subsys => "block", + devpath => "/block/sda", + exp_name => "parent", + option => "keep", + rules => < "IMPORT parent test sequence 2/2 (keep)", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "parentenv-parent_right", + option => "clean", + rules => < "GOTO test", + subsys => "block", + devpath => "/block/sda/sda1", + exp_name => "right", + rules => <$conf_tmp" || die "unable to create config file: $conf_tmp"; - print CONF $$config; + # create temporary rules + open CONF, ">$udev_rules" || die "unable to create rules file: $udev_rules"; + print CONF $$rules; close CONF; $ENV{ACTION} = $action; @@ -1095,36 +1534,50 @@ sub udev { my $error = 0; sub permissions_test { - my($config, $uid, $gid, $mode) = @_; + my($rules, $uid, $gid, $mode) = @_; my $wrong = 0; - $config->{exp_perms} =~ m/^(.*):(.*):(.*)$/; + my $userid; + my $groupid; + + $rules->{exp_perms} =~ m/^(.*):(.*):(.*)$/; if ($1 ne "") { - if ($uid != $1) { $wrong = 1; }; + if (defined(getpwnam($1))) { + $userid = int(getpwnam($1)); + } else { + $userid = $1; + } + if ($uid != $userid) { $wrong = 1; } } if ($2 ne "") { - if ($gid != $2) { $wrong = 1; }; + if (defined(getgrnam($2))) { + $groupid = int(getgrnam($2)); + } else { + $groupid = $2; + } + if ($gid != $groupid) { $wrong = 1; } } if ($3 ne "") { if (($mode & 07777) != oct($3)) { $wrong = 1; }; } if ($wrong == 0) { - print "permissions: ok "; + print "permissions: ok\n"; } else { - printf "expected permissions are: %i:%i:%#o\n", $1, $2, oct($3); - printf "created permissions are : %i:%i:%#o\n", $uid, $gid, $mode & 07777; + printf " expected permissions are: %s:%s:%#o\n", $1, $2, oct($3); + printf " created permissions are : %i:%i:%#o\n", $uid, $gid, $mode & 07777; + print "permissions: error\n"; $error++; } } sub major_minor_test { - my($config, $rdev) = @_; + my($rules, $rdev) = @_; my $major = ($rdev >> 8) & 0xfff; my $minor = ($rdev & 0xff) | (($rdev >> 12) & 0xfff00); my $wrong = 0; - $config->{exp_majorminor} =~ m/^(.*):(.*)$/; + $rules->{exp_majorminor} =~ m/^(.*):(.*)$/; if ($1 ne "") { if ($major != $1) { $wrong = 1; }; } @@ -1132,106 +1585,118 @@ sub major_minor_test { if ($minor != $2) { $wrong = 1; }; } if ($wrong == 0) { - print "major:minor: ok "; + print "major:minor: ok\n"; } else { - printf "expected major:minor is: %i:%i\n", $1, $2; - printf "created major:minor is : %i:%i\n", $major, $minor; - print "major:minor: error "; + printf " expected major:minor is: %i:%i\n", $1, $2; + printf " created major:minor is : %i:%i\n", $major, $minor; + print "major:minor: error\n"; $error++; } } sub symlink_test { - my ($config) = @_; + my ($rules) = @_; - my $output = `ls -l $PWD/$udev_root$config->{exp_name}`; + my $output = `ls -l $PWD/$udev_root$rules->{exp_name}`; if ($output =~ m/(.*)-> (.*)/) { - if ($2 eq $config->{exp_target}) { - print "symlink: ok "; + if ($2 eq $rules->{exp_target}) { + print "symlink: ok\n"; } else { - print "expected symlink from: \'$config->{exp_name}\' to \'$config->{exp_target}\'\n"; - print "created symlink from: \'$config->{exp_name}\' to \'$2\'\n"; - if ($config->{exp_error}) { - print "as expected "; + print " expected symlink from: \'$rules->{exp_name}\' to \'$rules->{exp_target}\'\n"; + print " created symlink from: \'$rules->{exp_name}\' to \'$2\'\n"; + print "symlink: error"; + if ($rules->{exp_add_error}) { + print " as expected\n"; } else { + print "\n"; $error++; } } } else { - print "expected symlink from: \'$config->{exp_name}\' to \'$config->{exp_target}\'\n"; - print "symlink: not created "; - if ($config->{exp_error}) { - print "as expected "; + print " expected symlink from: \'$rules->{exp_name}\' to \'$rules->{exp_target}\'\n"; + print "symlink: not created"; + if ($rules->{exp_add_error}) { + print " as expected\n"; } else { + print "\n"; $error++; } } } sub run_test { - my ($config, $number) = @_; + my ($rules, $number) = @_; - print "TEST $number: $config->{desc}\n"; + print "TEST $number: $rules->{desc}\n"; - if ($config->{exp_target}) { - print "device \'$config->{devpath}\' expecting symlink '$config->{exp_name}' to node \'$config->{exp_target}\'\n"; + if ($rules->{exp_target}) { + print "device \'$rules->{devpath}\' expecting symlink '$rules->{exp_name}' to node \'$rules->{exp_target}\'\n"; } else { - print "device \'$config->{devpath}\' expecting node \'$config->{exp_name}\'\n"; + print "device \'$rules->{devpath}\' expecting node \'$rules->{exp_name}\'\n"; } - udev("add", $config->{subsys}, $config->{devpath}, \$config->{conf}); - if ((-e "$PWD/$udev_root$config->{exp_name}") || - (-l "$PWD/$udev_root$config->{exp_name}")) { + udev("add", $rules->{subsys}, $rules->{devpath}, \$rules->{rules}); + if ((-e "$PWD/$udev_root$rules->{exp_name}") || + (-l "$PWD/$udev_root$rules->{exp_name}")) { my ($dev, $ino, $mode, $nlink, $uid, $gid, $rdev, $size, - $atime, $mtime, $ctime, $blksize, $blocks) = stat("$PWD/$udev_root$config->{exp_name}"); + $atime, $mtime, $ctime, $blksize, $blocks) = stat("$PWD/$udev_root$rules->{exp_name}"); - if (defined($config->{exp_perms})) { - permissions_test($config, $uid, $gid, $mode); + if (defined($rules->{not_exp_name})) { + if ((-e "$PWD/$udev_root$rules->{not_exp_name}") || + (-l "$PWD/$udev_root$rules->{not_exp_name}")) { + print "nonexistent: error \'$rules->{not_exp_name}\' not expected to be there\n"; + $error++ + } } - if (defined($config->{exp_majorminor})) { - major_minor_test($config, $rdev); + if (defined($rules->{exp_perms})) { + permissions_test($rules, $uid, $gid, $mode); } - if (defined($config->{exp_target})) { - symlink_test($config); + if (defined($rules->{exp_majorminor})) { + major_minor_test($rules, $rdev); } - print "add: ok "; + if (defined($rules->{exp_target})) { + symlink_test($rules); + } + print "add: ok\n"; } else { - print "add: error "; - if ($config->{exp_error}) { - print "as expected "; + print "add: error"; + if ($rules->{exp_add_error}) { + print " as expected\n"; } else { - print "\n\n"; + print "\n"; system("tree $udev_root"); print "\n"; $error++; } } - if (defined($config->{option}) && $config->{option} eq "keep") { + if (defined($rules->{option}) && $rules->{option} eq "keep") { print "\n\n"; return; } - udev("remove", $config->{subsys}, $config->{devpath}, \$config->{conf}); - if ((-e "$PWD/$udev_root$config->{exp_name}") || - (-l "$PWD/$udev_root$config->{exp_name}")) { - print "remove: error "; - if ($config->{exp_error}) { - print "as expected\n\n"; + udev("remove", $rules->{subsys}, $rules->{devpath}, \$rules->{rules}); + if ((-e "$PWD/$udev_root$rules->{exp_name}") || + (-l "$PWD/$udev_root$rules->{exp_name}")) { + print "remove: error"; + if ($rules->{exp_rem_error}) { + print " as expected\n"; } else { - print "\n\n"; + print "\n"; system("tree $udev_root"); print "\n"; $error++; } } else { - print "remove: ok\n\n"; + print "remove: ok\n"; } - if (defined($config->{option}) && $config->{option} eq "clear") { + print "\n"; + + if (defined($rules->{option}) && $rules->{option} eq "clean") { system("rm -rf $udev_db"); system("rm -rf $udev_root"); mkdir($udev_root) || die "unable to create udev_root: $udev_root\n"; @@ -1250,11 +1715,11 @@ if (!($<==0)) { system("rm -rf $udev_root"); mkdir($udev_root) || die "unable to create udev_root: $udev_root\n"; -# create initial config file -open CONF, ">$main_conf" || die "unable to create config file: $main_conf"; +# create config file +open CONF, ">$udev_conf" || die "unable to create config file: $udev_conf"; print CONF "udev_root=\"$udev_root\"\n"; print CONF "udev_db=\"$udev_db\"\n"; -print CONF "udev_rules=\"$conf_tmp\"\n"; +print CONF "udev_rules=\"$udev_rules\"\n"; close CONF; my $test_num = 1; @@ -1273,8 +1738,8 @@ if ($ARGV[0]) { # test all print "\nudev-test will run ".($#tests + 1)." tests:\n\n"; - foreach my $config (@tests) { - run_test($config, $test_num); + foreach my $rules (@tests) { + run_test($rules, $test_num); $test_num++; } } @@ -1284,6 +1749,6 @@ print "$error errors occured\n\n"; # cleanup system("rm -rf $udev_db"); system("rm -rf $udev_root"); -unlink($conf_tmp); -unlink($main_conf); +unlink($udev_rules); +unlink($udev_conf);