X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fupdate-utmp.c;h=b06f5a06cb6be57a19de2838a6bc4cbb480c8836;hp=336594fc7a25d25319b54d835aa3458d7cab2549;hb=9841e8e3d305e6f4173c9aedbe8d57adfe10d145;hpb=ee2083d5cacd8b6065b6a38d284f3e28961775a4 diff --git a/src/update-utmp.c b/src/update-utmp.c index 336594fc7..b06f5a06c 100644 --- a/src/update-utmp.c +++ b/src/update-utmp.c @@ -77,7 +77,7 @@ static usec_t get_startup_time(Context *c) { } if (!(reply = dbus_connection_send_with_reply_and_block(c->bus, m, -1, &error))) { - log_error("Failed to send command: %s", error.message); + log_error("Failed to send command: %s", bus_error_message(&error)); goto finish; } @@ -167,7 +167,7 @@ static int get_current_runlevel(Context *c) { if (!dbus_message_get_args(reply, &error, DBUS_TYPE_OBJECT_PATH, &path, DBUS_TYPE_INVALID)) { - log_error("Failed to parse reply: %s", error.message); + log_error("Failed to parse reply: %s", bus_error_message(&error)); r = -EIO; goto finish; } @@ -194,7 +194,7 @@ static int get_current_runlevel(Context *c) { dbus_message_unref(reply); if (!(reply = dbus_connection_send_with_reply_and_block(c->bus, m, -1, &error))) { - log_error("Failed to send command: %s", error.message); + log_error("Failed to send command: %s", bus_error_message(&error)); r = -EIO; goto finish; } @@ -361,12 +361,12 @@ int main(int argc, char *argv[]) { if (getppid() != 1) { log_error("This program should be invoked by init only."); - return 1; + return EXIT_FAILURE; } if (argc != 2) { log_error("This program requires one argument."); - return 1; + return EXIT_FAILURE; } log_set_target(LOG_TARGET_SYSLOG_OR_KMSG); @@ -379,7 +379,7 @@ int main(int argc, char *argv[]) { #endif if (bus_connect(DBUS_BUS_SYSTEM, &c.bus, NULL, &error) < 0) { - log_error("Failed to get D-Bus connection: %s", error.message); + log_error("Failed to get D-Bus connection: %s", bus_error_message(&error)); r = -EIO; goto finish; } @@ -406,12 +406,13 @@ finish: #endif if (c.bus) { - dbus_connection_close(c.bus); - dbus_connection_unref(c.bus); + dbus_connection_flush(c.bus); + dbus_connection_close(c.bus); + dbus_connection_unref(c.bus); } dbus_error_free(&error); dbus_shutdown(); - return r < 0 ? 1 : 0; + return r < 0 ? EXIT_FAILURE : EXIT_SUCCESS; }