X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fsystemctl.c;h=2efc85635d8f3bd0e270d3baa03f24a312c49f39;hp=850efe2dd44be04e3abf109ebb3f792b31ebfb1a;hb=b1fc29fb70de560fe9a7a744a20a67aaa4b68b5f;hpb=e4b613402deb901741d910fc9442d6d4c1763951 diff --git a/src/systemctl.c b/src/systemctl.c index 850efe2dd..2efc85635 100644 --- a/src/systemctl.c +++ b/src/systemctl.c @@ -28,6 +28,8 @@ #include #include #include +#include +#include #include @@ -36,6 +38,9 @@ #include "macro.h" #include "set.h" #include "utmp-wtmp.h" +#include "special.h" +#include "initreq.h" +#include "strv.h" static const char *arg_type = NULL; static bool arg_all = false; @@ -45,6 +50,7 @@ static bool arg_block = false; static bool arg_immediate = false; static bool arg_no_wtmp = false; static bool arg_no_sync = false; +static bool arg_no_wall = false; static bool arg_dry = false; static char **arg_wall = NULL; enum action { @@ -53,12 +59,13 @@ enum action { ACTION_HALT, ACTION_POWEROFF, ACTION_REBOOT, - ACTION_RUNLEVEL1, ACTION_RUNLEVEL2, ACTION_RUNLEVEL3, ACTION_RUNLEVEL4, ACTION_RUNLEVEL5, ACTION_RESCUE, + ACTION_EMERGENCY, + ACTION_DEFAULT, ACTION_RELOAD, ACTION_REEXEC, ACTION_RUNLEVEL, @@ -67,6 +74,8 @@ enum action { static bool error_is_no_service(DBusError *error) { + assert(error); + if (!dbus_error_is_set(error)) return false; @@ -81,6 +90,9 @@ static bool error_is_no_service(DBusError *error) { static int bus_iter_get_basic_and_next(DBusMessageIter *iter, int type, void *data, bool next) { + assert(iter); + assert(data); + if (dbus_message_iter_get_arg_type(iter) != type) return -EIO; @@ -92,6 +104,32 @@ static int bus_iter_get_basic_and_next(DBusMessageIter *iter, int type, void *da return 0; } +static int bus_check_peercred(DBusConnection *c) { + int fd; + struct ucred ucred; + socklen_t l; + + assert(c); + + assert_se(dbus_connection_get_unix_fd(c, &fd)); + + l = sizeof(struct ucred); + if (getsockopt(fd, SOL_SOCKET, SO_PEERCRED, &ucred, &l) < 0) { + log_error("SO_PEERCRED failed: %m"); + return -errno; + } + + if (l != sizeof(struct ucred)) { + log_error("SO_PEERCRED returned wrong size."); + return -E2BIG; + } + + if (ucred.uid != 0) + return -EPERM; + + return 1; +} + static int columns(void) { static int parsed_columns = 0; const char *e; @@ -117,6 +155,41 @@ static int columns(void) { } +static void warn_wall(enum action action) { + static const char *table[_ACTION_MAX] = { + [ACTION_HALT] = "The system is going down for system halt NOW!", + [ACTION_REBOOT] = "The system is going down for reboot NOW!", + [ACTION_POWEROFF] = "The system is going down for power-off NOW!", + [ACTION_RESCUE] = "The system is going down to rescue mode NOW!", + [ACTION_EMERGENCY] = "The system is going down to emergency mode NOW!" + }; + + if (arg_no_wall) + return; + + if (arg_wall) { + char *p; + + if (!(p = strv_join(arg_wall, " "))) { + log_error("Failed to join strings."); + return; + } + + if (*p) { + utmp_wall(p); + free(p); + return; + } + + free(p); + } + + if (!table[action]) + return; + + utmp_wall(table[action]); +} + static int list_units(DBusConnection *bus, char **args, unsigned n) { DBusMessage *m = NULL, *reply = NULL; DBusError error; @@ -126,6 +199,8 @@ static int list_units(DBusConnection *bus, char **args, unsigned n) { dbus_error_init(&error); + assert(bus); + if (!(m = dbus_message_new_method_call( "org.freedesktop.systemd1", "/org/freedesktop/systemd1", @@ -234,6 +309,8 @@ static int list_jobs(DBusConnection *bus, char **args, unsigned n) { dbus_error_init(&error); + assert(bus); + if (!(m = dbus_message_new_method_call( "org.freedesktop.systemd1", "/org/freedesktop/systemd1", @@ -313,6 +390,9 @@ static int load_unit(DBusConnection *bus, char **args, unsigned n) { dbus_error_init(&error); + assert(bus); + assert(args); + for (i = 1; i < n; i++) { if (!(m = dbus_message_new_method_call( @@ -367,6 +447,9 @@ static int cancel_job(DBusConnection *bus, char **args, unsigned n) { dbus_error_init(&error); + assert(bus); + assert(args); + for (i = 1; i < n; i++) { unsigned id; const char *path; @@ -656,73 +739,100 @@ finish: return r; } +static enum action verb_to_action(const char *verb) { + if (streq(verb, "halt")) + return ACTION_HALT; + else if (streq(verb, "poweroff")) + return ACTION_POWEROFF; + else if (streq(verb, "reboot")) + return ACTION_REBOOT; + else if (streq(verb, "rescue")) + return ACTION_RESCUE; + else if (streq(verb, "emergency")) + return ACTION_EMERGENCY; + else if (streq(verb, "default")) + return ACTION_DEFAULT; + else + return ACTION_INVALID; +} + static int start_unit(DBusConnection *bus, char **args, unsigned n) { static const char * const table[_ACTION_MAX] = { - [ACTION_HALT] = "halt.target", - [ACTION_POWEROFF] = "poweroff.target", - [ACTION_REBOOT] = "reboot.target", - [ACTION_RUNLEVEL1] = "runlevel1.target", - [ACTION_RUNLEVEL2] = "runlevel2.target", - [ACTION_RUNLEVEL3] = "runlevel3.target", - [ACTION_RUNLEVEL4] = "runlevel4.target", - [ACTION_RUNLEVEL5] = "runlevel5.target", - [ACTION_RESCUE] = "rescue.target" + [ACTION_HALT] = SPECIAL_HALT_TARGET, + [ACTION_POWEROFF] = SPECIAL_POWEROFF_TARGET, + [ACTION_REBOOT] = SPECIAL_REBOOT_TARGET, + [ACTION_RUNLEVEL2] = SPECIAL_RUNLEVEL2_TARGET, + [ACTION_RUNLEVEL3] = SPECIAL_RUNLEVEL3_TARGET, + [ACTION_RUNLEVEL4] = SPECIAL_RUNLEVEL4_TARGET, + [ACTION_RUNLEVEL5] = SPECIAL_RUNLEVEL5_TARGET, + [ACTION_RESCUE] = SPECIAL_RESCUE_TARGET, + [ACTION_EMERGENCY] = SPECIAL_EMERGENCY_SERVICE, + [ACTION_DEFAULT] = SPECIAL_DEFAULT_TARGET }; int r; unsigned i; - const char *method, *mode; + const char *method, *mode, *one_name; Set *s = NULL; + assert(bus); + if (arg_action == ACTION_SYSTEMCTL) { method = - streq(args[0], "start") ? "StartUnit" : streq(args[0], "stop") ? "StopUnit" : streq(args[0], "reload") ? "ReloadUnit" : streq(args[0], "restart") ? "RestartUnit" : - /* isolate */ "StartUnit"; + "StartUnit"; mode = - streq(args[0], "isolate") ? "isolate" : - arg_replace ? "replace" : - "fail"; + (streq(args[0], "isolate") || + streq(args[0], "rescue") || + streq(args[0], "emergency")) ? "isolate" : + arg_replace ? "replace" : + "fail"; - if (arg_block) { - if ((r = enable_wait_for_jobs(bus)) < 0) { - log_error("Could not watch jobs: %s", strerror(-r)); - goto finish; - } + one_name = table[verb_to_action(args[0])]; - if (!(s = set_new(string_hash_func, string_compare_func))) { - log_error("Failed to allocate set."); - r = -ENOMEM; - goto finish; - } - } } else { assert(arg_action < ELEMENTSOF(table)); assert(table[arg_action]); method = "StartUnit"; - mode = arg_action == ACTION_RESCUE ? "isolate" : "replace"; + + mode = (arg_action == ACTION_EMERGENCY || + arg_action == ACTION_RESCUE) ? "isolate" : "replace"; + + one_name = table[arg_action]; + } + + if (arg_block) { + if ((r = enable_wait_for_jobs(bus)) < 0) { + log_error("Could not watch jobs: %s", strerror(-r)); + goto finish; + } + + if (!(s = set_new(string_hash_func, string_compare_func))) { + log_error("Failed to allocate set."); + r = -ENOMEM; + goto finish; + } } r = 0; - if (arg_action == ACTION_SYSTEMCTL) { + if (one_name) { + if ((r = start_unit_one(bus, method, one_name, mode, s)) <= 0) + goto finish; + } else { for (i = 1; i < n; i++) if ((r = start_unit_one(bus, method, args[i], mode, s)) < 0) goto finish; - - if (arg_block) - r = wait_for_jobs(bus, s); - - } else { - if ((r = start_unit_one(bus, method, table[arg_action], mode, s)) <= 0) - goto finish; } + if (arg_block) + r = wait_for_jobs(bus, s); + finish: if (s) set_free_free(s); @@ -730,6 +840,15 @@ finish: return r; } +static int start_special(DBusConnection *bus, char **args, unsigned n) { + assert(bus); + assert(args); + + warn_wall(verb_to_action(args[0])); + + return start_unit(bus, args, n); +} + static DBusHandlerResult monitor_filter(DBusConnection *connection, DBusMessage *message, void *data) { DBusError error; DBusMessage *m = NULL, *reply = NULL; @@ -1310,14 +1429,15 @@ finish: static int systemctl_help(void) { printf("%s [options]\n\n" - "Send control commands to the init system.\n\n" + "Send control commands to the init daemon.\n\n" " -h --help Show this help\n" " -t --type=TYPE List only units of a particular type\n" " -a --all Show all units, including dead ones\n" " --replace When installing a new job, replace existing conflicting ones\n" " --system Connect to system bus\n" " --session Connect to session bus\n" - " --block Wait until operation finished\n\n" + " --block Wait until operation finished\n" + " --no-wall Don't send wall message before reboot/halt/power-off\n\n" "Commands:\n" " list-units List units\n" " list-jobs List jobs\n" @@ -1332,12 +1452,18 @@ static int systemctl_help(void) { " monitor Monitor unit/job changes\n" " dump Dump server status\n" " snapshot [NAME] Create a snapshot\n" - " daemon-reload Reload daemon configuration\n" - " daemon-reexecute Reexecute daemon\n" - " daemon-exit Ask the daemon to quit\n" + " daemon-reload Reload init daemon configuration\n" + " daemon-reexec Reexecute init daemon\n" + " daemon-exit Ask the init daemon to quit\n" " show-environment Dump environment\n" " set-environment [NAME=VALUE...] Set one or more environment variables\n" - " unset-environment [NAME...] Unset one or more environment variables\n", + " unset-environment [NAME...] Unset one or more environment variables\n" + " halt Shut down and halt the system\n" + " reboot Shut down and reboot the system\n" + " poweroff Shut down and power off the system\n" + " default Enter default mode\n" + " rescue Enter rescue mode\n" + " emergency Enter emergency mode\n", program_invocation_short_name); return 0; @@ -1354,7 +1480,8 @@ static int halt_help(void) { " -f --force Force immediate reboot/halt/power-off\n" " -w --wtmp-only Don't reboot/halt/power-off, just write wtmp record\n" " -d --no-wtmp Don't write wtmp record\n" - " -n --no-sync Don't sync before reboot/halt/power-off\n", + " -n --no-sync Don't sync before reboot/halt/power-off\n" + " --no-wall Don't send wall message before reboot/halt/power-off\n", program_invocation_short_name, arg_action == ACTION_REBOOT ? "Reboot" : arg_action == ACTION_POWEROFF ? "Power off" : @@ -1365,14 +1492,15 @@ static int halt_help(void) { static int shutdown_help(void) { - printf("%s [options] [TIME] [WALL...]\n\n" + printf("%s [options] [now] [WALL...]\n\n" "Shut down the system.\n\n" " --help Show this help\n" " -H --halt Halt the machine\n" " -P --poweroff Power-off the machine\n" " -r --reboot Reboot the machine\n" " -h Equivalent to --poweroff, overriden by --halt\n" - " -k Don't reboot/halt/power-off, just send warnings\n", + " -k Don't reboot/halt/power-off, just send warnings\n" + " --no-wall Don't send wall message before reboot/halt/power-off\n", program_invocation_short_name); return 0; @@ -1381,15 +1509,16 @@ static int shutdown_help(void) { static int telinit_help(void) { printf("%s [options]\n\n" - "Send control commands to the init system.\n\n" - " --help Show this help\n\n" + "Send control commands to the init daemon.\n\n" + " --help Show this help\n" + " --no-wall Don't send wall message before reboot/halt/power-off\n\n" "Commands:\n" " 0 Power-off the machine\n" " 6 Reboot the machine\n" - " 1, 2, 3, 4, 5 Start runlevelX.target unit\n" - " s, S Start the rescue.target unit\n" - " q, Q Ask systemd to reload its configuration\n" - " u, U Ask systemd to reexecute itself\n", + " 2, 3, 4, 5 Start runlevelX.target unit\n" + " 1, s, S Enter rescue mode\n" + " q, Q Reload init daemon configuration\n" + " u, U Reexecute init daemon\n", program_invocation_short_name); return 0; @@ -1411,7 +1540,8 @@ static int systemctl_parse_argv(int argc, char *argv[]) { ARG_REPLACE = 0x100, ARG_SESSION, ARG_SYSTEM, - ARG_BLOCK + ARG_BLOCK, + ARG_NO_WALL }; static const struct option options[] = { @@ -1422,6 +1552,7 @@ static int systemctl_parse_argv(int argc, char *argv[]) { { "session", no_argument, NULL, ARG_SESSION }, { "system", no_argument, NULL, ARG_SYSTEM }, { "block", no_argument, NULL, ARG_BLOCK }, + { "no-wall", no_argument, NULL, ARG_NO_WALL }, { NULL, 0, NULL, 0 } }; @@ -1462,6 +1593,10 @@ static int systemctl_parse_argv(int argc, char *argv[]) { arg_block = true; break; + case ARG_NO_WALL: + arg_no_wall = true; + break; + case '?': return -EINVAL; @@ -1479,7 +1614,8 @@ static int halt_parse_argv(int argc, char *argv[]) { enum { ARG_HELP = 0x100, ARG_HALT, - ARG_REBOOT + ARG_REBOOT, + ARG_NO_WALL }; static const struct option options[] = { @@ -1491,6 +1627,7 @@ static int halt_parse_argv(int argc, char *argv[]) { { "wtmp-only", no_argument, NULL, 'w' }, { "no-wtmp", no_argument, NULL, 'd' }, { "no-sync", no_argument, NULL, 'n' }, + { "no-wall", no_argument, NULL, ARG_NO_WALL }, { NULL, 0, NULL, 0 } }; @@ -1538,6 +1675,10 @@ static int halt_parse_argv(int argc, char *argv[]) { arg_no_sync = true; break; + case ARG_NO_WALL: + arg_no_wall = true; + break; + case 'i': case 'h': /* Compatibility nops */ @@ -1564,6 +1705,7 @@ static int shutdown_parse_argv(int argc, char *argv[]) { enum { ARG_HELP = 0x100, + ARG_NO_WALL }; static const struct option options[] = { @@ -1571,6 +1713,7 @@ static int shutdown_parse_argv(int argc, char *argv[]) { { "halt", no_argument, NULL, 'H' }, { "poweroff", no_argument, NULL, 'P' }, { "reboot", no_argument, NULL, 'r' }, + { "no-wall", no_argument, NULL, ARG_NO_WALL }, { NULL, 0, NULL, 0 } }; @@ -1607,6 +1750,10 @@ static int shutdown_parse_argv(int argc, char *argv[]) { arg_dry = true; break; + case ARG_NO_WALL: + arg_no_wall = true; + break; + case 't': case 'a': /* Compatibility nops */ @@ -1621,6 +1768,9 @@ static int shutdown_parse_argv(int argc, char *argv[]) { } } + if (argc > optind && !streq(argv[optind], "now")) + log_warning("First argument '%s' isn't 'now'. Ignoring.", argv[optind]); + /* We ignore the time argument */ if (argc > optind + 1) arg_wall = argv + optind + 1; @@ -1628,17 +1778,18 @@ static int shutdown_parse_argv(int argc, char *argv[]) { optind = argc; return 1; - } static int telinit_parse_argv(int argc, char *argv[]) { enum { ARG_HELP = 0x100, + ARG_NO_WALL }; static const struct option options[] = { { "help", no_argument, NULL, ARG_HELP }, + { "no-wall", no_argument, NULL, ARG_NO_WALL }, { NULL, 0, NULL, 0 } }; @@ -1648,7 +1799,7 @@ static int telinit_parse_argv(int argc, char *argv[]) { } table[] = { { '0', ACTION_POWEROFF }, { '6', ACTION_REBOOT }, - { '1', ACTION_RUNLEVEL1 }, + { '1', ACTION_RESCUE }, { '2', ACTION_RUNLEVEL2 }, { '3', ACTION_RUNLEVEL3 }, { '4', ACTION_RUNLEVEL4 }, @@ -1674,6 +1825,10 @@ static int telinit_parse_argv(int argc, char *argv[]) { telinit_help(); return 0; + case ARG_NO_WALL: + arg_no_wall = true; + break; + case '?': return -EINVAL; @@ -1785,14 +1940,150 @@ static int parse_argv(int argc, char *argv[]) { return systemctl_parse_argv(argc, argv); } -static int talk_upstart(DBusConnection *bus) { - log_error("Talking upstart"); - return 0; +static int action_to_runlevel(void) { + + static const char table[_ACTION_MAX] = { + [ACTION_HALT] = '0', + [ACTION_POWEROFF] = '0', + [ACTION_REBOOT] = '6', + [ACTION_RUNLEVEL2] = '2', + [ACTION_RUNLEVEL3] = '3', + [ACTION_RUNLEVEL4] = '4', + [ACTION_RUNLEVEL5] = '5', + [ACTION_RESCUE] = '1' + }; + + assert(arg_action < _ACTION_MAX); + + return table[arg_action]; +} + +static int talk_upstart(void) { + DBusMessage *m = NULL, *reply = NULL; + DBusError error; + int previous, rl, r; + char + env1_buf[] = "RUNLEVEL=X", + env2_buf[] = "PREVLEVEL=X"; + char *env1 = env1_buf, *env2 = env2_buf; + const char *emit = "runlevel"; + dbus_bool_t b_false = FALSE; + DBusMessageIter iter, sub; + DBusConnection *bus; + + dbus_error_init(&error); + + if (!(rl = action_to_runlevel())) + return 0; + + if (utmp_get_runlevel(&previous, NULL) < 0) + previous = 'N'; + + if (!(bus = dbus_connection_open("unix:abstract=/com/ubuntu/upstart", &error))) { + if (dbus_error_has_name(&error, DBUS_ERROR_NO_SERVER)) { + r = 0; + goto finish; + } + + log_error("Failed to connect to Upstart bus: %s", error.message); + r = -EIO; + goto finish; + } + + if ((r = bus_check_peercred(bus)) < 0) { + log_error("Failed to verify owner of bus."); + goto finish; + } + + if (!(m = dbus_message_new_method_call( + "com.ubuntu.Upstart", + "/com/ubuntu/Upstart", + "com.ubuntu.Upstart0_6", + "EmitEvent"))) { + + log_error("Could not allocate message."); + r = -ENOMEM; + goto finish; + } + + dbus_message_iter_init_append(m, &iter); + + env1_buf[sizeof(env1_buf)-2] = rl; + env2_buf[sizeof(env2_buf)-2] = previous; + + if (!dbus_message_iter_append_basic(&iter, DBUS_TYPE_STRING, &emit) || + !dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY, "s", &sub) || + !dbus_message_iter_append_basic(&sub, DBUS_TYPE_STRING, &env1) || + !dbus_message_iter_append_basic(&sub, DBUS_TYPE_STRING, &env2) || + !dbus_message_iter_close_container(&iter, &sub) || + !dbus_message_iter_append_basic(&iter, DBUS_TYPE_BOOLEAN, &b_false)) { + log_error("Could not append arguments to message."); + r = -ENOMEM; + goto finish; + } + + if (!(reply = dbus_connection_send_with_reply_and_block(bus, m, -1, &error))) { + + if (error_is_no_service(&error)) { + r = 0; + goto finish; + } + + log_error("Failed to issue method call: %s", error.message); + r = -EIO; + goto finish; + } + + r = 1; + +finish: + if (m) + dbus_message_unref(m); + + if (reply) + dbus_message_unref(reply); + + if (bus) + dbus_connection_unref(bus); + + dbus_error_free(&error); + + return r; } static int talk_initctl(void) { - log_error("Talking initctl"); - return 0; + struct init_request request; + int r, fd; + char rl; + + if (!(rl = action_to_runlevel())) + return 0; + + zero(request); + request.magic = INIT_MAGIC; + request.sleeptime = 0; + request.cmd = INIT_CMD_RUNLVL; + request.runlevel = rl; + + if ((fd = open(INIT_FIFO, O_WRONLY|O_NDELAY|O_CLOEXEC|O_NOCTTY)) < 0) { + + if (errno == ENOENT) + return 0; + + log_error("Failed to open "INIT_FIFO": %m"); + return -errno; + } + + errno = 0; + r = loop_write(fd, &request, sizeof(request), false) != sizeof(request); + close_nointr_nofail(fd); + + if (r < 0) { + log_error("Failed to write to "INIT_FIFO": %m"); + return errno ? -errno : -EIO; + } + + return 1; } static int systemctl_main(DBusConnection *bus, int argc, char *argv[]) { @@ -1826,6 +2117,12 @@ static int systemctl_main(DBusConnection *bus, int argc, char *argv[]) { { "show-environment", EQUAL, 1, show_enviroment }, { "set-environment", MORE, 2, set_environment }, { "unset-environment", MORE, 2, set_environment }, + { "halt", EQUAL, 1, start_special }, + { "poweroff", EQUAL, 1, start_special }, + { "reboot", EQUAL, 1, start_special }, + { "default", EQUAL, 1, start_special }, + { "rescue", EQUAL, 1, start_special }, + { "emergency", EQUAL, 1, start_special }, }; int left; @@ -1907,6 +2204,8 @@ static int reload_with_fallback(DBusConnection *bus) { static int start_with_fallback(DBusConnection *bus) { int r; + warn_wall(arg_action); + if (bus) { /* First, try systemd via D-Bus. */ if ((r = start_unit(bus, NULL, 0)) > 0) @@ -1914,13 +2213,17 @@ static int start_with_fallback(DBusConnection *bus) { /* Hmm, talking to systemd via D-Bus didn't work. Then * let's try to talk to Upstart via D-Bus. */ - if ((r = talk_upstart(bus)) > 0) + if ((r = talk_upstart()) > 0) return 0; } /* Nothing else worked, so let's try * /dev/initctl */ - return talk_initctl(); + if ((r = talk_initctl()) != 0) + return 0; + + log_error("Failed to talk to init daemon."); + return -EIO; } static int halt_main(DBusConnection *bus) { @@ -2006,7 +2309,18 @@ int main(int argc, char*argv[]) { goto finish; } - if ((bus = dbus_bus_get(arg_session ? DBUS_BUS_SESSION : DBUS_BUS_SYSTEM, &error))) + /* If we are root, then let's not go via the bus */ + if (geteuid() == 0 && !arg_session) { + bus = dbus_connection_open("unix:abstract=/org/freedesktop/systemd1/private", &error); + + if (bus && bus_check_peercred(bus) < 0) { + log_error("Failed to verify owner of bus."); + goto finish; + } + } else + bus = dbus_bus_get(arg_session ? DBUS_BUS_SESSION : DBUS_BUS_SYSTEM, &error); + + if (bus) dbus_connection_set_exit_on_disconnect(bus, FALSE); switch (arg_action) { @@ -2028,12 +2342,13 @@ int main(int argc, char*argv[]) { retval = halt_main(bus) < 0; break; - case ACTION_RUNLEVEL1: case ACTION_RUNLEVEL2: case ACTION_RUNLEVEL3: case ACTION_RUNLEVEL4: case ACTION_RUNLEVEL5: case ACTION_RESCUE: + case ACTION_EMERGENCY: + case ACTION_DEFAULT: retval = start_with_fallback(bus) < 0; break; @@ -2042,6 +2357,8 @@ int main(int argc, char*argv[]) { retval = reload_with_fallback(bus) < 0; break; + case ACTION_INVALID: + case ACTION_RUNLEVEL: default: assert_not_reached("Unknown action"); }