X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fpath.c;h=27c45447297882b3c44d522567fc1d7bfb915a90;hp=56936fd673fd76d427c18eb8fdce7f2105279be5;hb=398ef8ba0266cca453d90a90b3a2aa1caa44189f;hpb=2c966c038dc32ef39baa176371395cde4e541d01 diff --git a/src/path.c b/src/path.c index 56936fd67..27c454472 100644 --- a/src/path.c +++ b/src/path.c @@ -29,6 +29,8 @@ #include "unit-name.h" #include "path.h" #include "dbus-path.h" +#include "special.h" +#include "bus-errors.h" static const UnitActiveState state_translation_table[_PATH_STATE_MAX] = { [PATH_DEAD] = UNIT_INACTIVE, @@ -120,6 +122,11 @@ static int path_load(Unit *u) { if ((r = path_add_mount_links(p)) < 0) return r; + + /* Path units shouldn't stay around on shutdown */ + if (p->meta.default_dependencies) + if ((r = unit_add_two_dependencies_by_name(u, UNIT_BEFORE, UNIT_CONFLICTS, SPECIAL_SHUTDOWN_TARGET, NULL, true)) < 0) + return r; } return path_verify(p); @@ -292,17 +299,22 @@ static void path_enter_dead(Path *p, bool success) { static void path_enter_running(Path *p) { int r; + DBusError error; + assert(p); + dbus_error_init(&error); - if ((r = manager_add_job(p->meta.manager, JOB_START, p->unit, JOB_REPLACE, true, NULL)) < 0) + if ((r = manager_add_job(p->meta.manager, JOB_START, p->unit, JOB_REPLACE, true, &error, NULL)) < 0) goto fail; path_set_state(p, PATH_RUNNING); return; fail: - log_warning("%s failed to queue unit startup job: %s", p->meta.id, strerror(-r)); + log_warning("%s failed to queue unit startup job: %s", p->meta.id, bus_error(&error, r)); path_enter_dead(p, false); + + dbus_error_free(&error); }