X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fnetwork%2Fnetworkctl.c;h=43258bb942538be3568eb6efd59f4ae2bd77666d;hp=3df5e8e13a0c34b31f5e3fb2f89e675ee0c6f9fa;hb=373d9f173f910d547159917401c4b1f84af85736;hpb=ab1525bc2d92780b4dc64bc5b9cdb52594e2df7d diff --git a/src/network/networkctl.c b/src/network/networkctl.c index 3df5e8e13..43258bb94 100644 --- a/src/network/networkctl.c +++ b/src/network/networkctl.c @@ -33,6 +33,7 @@ #include "udev-util.h" #include "arphrd-list.h" #include "local-addresses.h" +#include "socket-util.h" static bool arg_no_pager = false; static bool arg_legend = true; @@ -140,7 +141,7 @@ static int decode_and_sort_links(sd_rtnl_message *m, LinkInfo **ret) { c++; } - qsort(links, c, sizeof(LinkInfo), link_info_compare); + qsort_safe(links, c, sizeof(LinkInfo), link_info_compare); *ret = links; links = NULL; @@ -148,6 +149,37 @@ static int decode_and_sort_links(sd_rtnl_message *m, LinkInfo **ret) { return (int) c; } +static void operational_state_to_color(const char *state, const char **on, const char **off) { + assert(on); + assert(off); + + if (streq_ptr(state, "routable")) { + *on = ansi_highlight_green(); + *off = ansi_highlight_off(); + } else if (streq_ptr(state, "degraded")) { + *on = ansi_highlight_yellow(); + *off = ansi_highlight_off(); + } else + *on = *off = ""; +} + +static void setup_state_to_color(const char *state, const char **on, const char **off) { + assert(on); + assert(off); + + if (streq_ptr(state, "configured")) { + *on = ansi_highlight_green(); + *off = ansi_highlight_off(); + } else if (streq_ptr(state, "configuring")) { + *on = ansi_highlight_yellow(); + *off = ansi_highlight_off(); + } else if (streq_ptr(state, "failed") || streq_ptr(state, "linger")) { + *on = ansi_highlight_red(); + *off = ansi_highlight_off(); + } else + *on = *off = ""; +} + static int list_links(char **args, unsigned n) { _cleanup_rtnl_message_unref_ sd_rtnl_message *req = NULL, *reply = NULL; _cleanup_udev_unref_ struct udev *udev = NULL; @@ -184,7 +216,7 @@ static int list_links(char **args, unsigned n) { } if (arg_legend) - printf("%3s %-16s %-10s %-11s %-10s\n", "IDX", "LINK", "TYPE", "SETUP", "OPERATIONAL"); + printf("%3s %-16s %-18s %-11s %-10s\n", "IDX", "LINK", "TYPE", "OPERATIONAL", "SETUP"); c = decode_and_sort_links(reply, &links); if (c < 0) @@ -193,42 +225,26 @@ static int list_links(char **args, unsigned n) { for (i = 0; i < c; i++) { _cleanup_free_ char *setup_state = NULL, *operational_state = NULL; _cleanup_udev_device_unref_ struct udev_device *d = NULL; - const char *on_color_oper = "", *off_color_oper = "", - *on_color = "", *off_color = ""; + const char *on_color_operational, *off_color_operational, + *on_color_setup, *off_color_setup; char devid[2 + DECIMAL_STR_MAX(int)]; _cleanup_free_ char *t = NULL; - sd_network_link_get_setup_state(links[i].ifindex, &setup_state); sd_network_link_get_operational_state(links[i].ifindex, &operational_state); + operational_state_to_color(operational_state, &on_color_operational, &off_color_operational); + + sd_network_link_get_setup_state(links[i].ifindex, &setup_state); + setup_state_to_color(setup_state, &on_color_setup, &off_color_setup); sprintf(devid, "n%i", links[i].ifindex); d = udev_device_new_from_device_id(udev, devid); link_get_type_string(links[i].iftype, d, &t); - if (streq_ptr(operational_state, "routable")) { - on_color_oper = ansi_highlight_green(); - off_color_oper = ansi_highlight_off(); - } else if (streq_ptr(operational_state, "degraded")) { - on_color_oper = ansi_highlight_yellow(); - off_color_oper = ansi_highlight_off(); - } - - if (streq_ptr(setup_state, "configured")) { - on_color = ansi_highlight_green(); - off_color = ansi_highlight_off(); - } else if (streq_ptr(setup_state, "configuring")) { - on_color = ansi_highlight_yellow(); - off_color = ansi_highlight_off(); - } else if (streq_ptr(setup_state, "failed") || - streq_ptr(setup_state, "linger")) { - on_color = ansi_highlight_red(); - off_color = ansi_highlight_off(); - } - - printf("%3i %-16s %-10s %s%-11s%s %s%-10s%s\n", links[i].ifindex, - links[i].name, strna(t), on_color, strna(setup_state), off_color, - on_color_oper, strna(operational_state), off_color_oper); + printf("%3i %-16s %-18s %s%-11s%s %s%-10s%s\n", + links[i].ifindex, links[i].name, strna(t), + on_color_operational, strna(operational_state), off_color_operational, + on_color_setup, strna(setup_state), off_color_setup); } if (arg_legend) @@ -273,14 +289,15 @@ static void dump_list(const char *prefix, char **l) { } static int link_status_one(sd_rtnl *rtnl, struct udev *udev, const char *name) { - _cleanup_strv_free_ char **dns = NULL, **ntp = NULL; + _cleanup_strv_free_ char **dns = NULL, **ntp = NULL, **domains = NULL; _cleanup_free_ char *setup_state = NULL, *operational_state = NULL; _cleanup_rtnl_message_unref_ sd_rtnl_message *req = NULL, *reply = NULL; _cleanup_udev_device_unref_ struct udev_device *d = NULL; char devid[2 + DECIMAL_STR_MAX(int)]; - _cleanup_free_ char *t = NULL; + _cleanup_free_ char *t = NULL, *network = NULL; const char *driver = NULL, *path = NULL, *vendor = NULL, *model = NULL; - const char *on_color = "", *off_color = ""; + const char *on_color_operational, *off_color_operational, + *on_color_setup, *off_color_setup; struct ether_addr e; unsigned iftype; int r, ifindex; @@ -340,11 +357,26 @@ static int link_status_one(sd_rtnl *rtnl, struct udev *udev, const char *name) { sd_rtnl_message_read_u32(reply, IFLA_MTU, &mtu); - sd_network_link_get_setup_state(ifindex, &setup_state); sd_network_link_get_operational_state(ifindex, &operational_state); + operational_state_to_color(operational_state, &on_color_operational, &off_color_operational); + + sd_network_link_get_setup_state(ifindex, &setup_state); + setup_state_to_color(setup_state, &on_color_setup, &off_color_setup); sd_network_link_get_dns(ifindex, &dns); sd_network_link_get_ntp(ifindex, &ntp); + sd_network_link_get_domains(ifindex, &domains); + r = sd_network_link_get_wildcard_domain(ifindex); + if (r > 0) { + char *wildcard; + + wildcard = strdup("*"); + if (!wildcard) + return log_oom(); + + if (strv_consume(&domains, wildcard) < 0) + return log_oom(); + } sprintf(devid, "n%i", ifindex); d = udev_device_new_from_device_id(udev, devid); @@ -364,21 +396,17 @@ static int link_status_one(sd_rtnl *rtnl, struct udev *udev, const char *name) { model = udev_device_get_property_value(d, "ID_MODEL"); } - if (streq_ptr(operational_state, "routable")) { - on_color = ansi_highlight_green(); - off_color = ansi_highlight_off(); - } else if (streq_ptr(operational_state, "degraded")) { - on_color = ansi_highlight_yellow(); - off_color = ansi_highlight_off(); - } + sd_network_link_get_network_file(ifindex, &network); - printf("%s%s%s %i: %s\n", on_color, draw_special_char(DRAW_BLACK_CIRCLE), off_color, ifindex, name); + printf("%s%s%s %i: %s\n", on_color_operational, draw_special_char(DRAW_BLACK_CIRCLE), off_color_operational, ifindex, name); - printf(" Type: %s\n" - " State: %s%s%s (%s)\n", + printf("Network File: %s\n" + " Type: %s\n" + " State: %s%s%s (%s%s%s)\n", + strna(network), strna(t), - on_color, strna(operational_state), off_color, - strna(setup_state)); + on_color_operational, strna(operational_state), off_color_operational, + on_color_setup, strna(setup_state), off_color_setup); if (path) printf(" Path: %s\n", path); @@ -389,8 +417,10 @@ static int link_status_one(sd_rtnl *rtnl, struct udev *udev, const char *name) { if (model) printf(" Model: %s\n", model); - if (have_mac) - printf(" HW Address: %s\n", ether_ntoa(&e)); + if (have_mac) { + char ea[ETHER_ADDR_TO_STRING_MAX]; + printf(" HW Address: %s\n", ether_addr_to_string(&e, ea)); + } if (mtu > 0) printf(" MTU: %u\n", mtu); @@ -399,6 +429,8 @@ static int link_status_one(sd_rtnl *rtnl, struct udev *udev, const char *name) { if (!strv_isempty(dns)) dump_list(" DNS: ", dns); + if (!strv_isempty(domains)) + dump_list(" Domain: ", domains); if (!strv_isempty(ntp)) dump_list(" NTP: ", ntp); @@ -425,21 +457,15 @@ static int link_status(char **args, unsigned n) { if (n <= 1 && !arg_all) { _cleanup_free_ char *operational_state = NULL; - _cleanup_strv_free_ char **dns = NULL, **ntp = NULL; + _cleanup_strv_free_ char **dns = NULL, **ntp = NULL, **domains = NULL; _cleanup_free_ struct local_address *addresses = NULL; - const char *on_color_oper = "", *off_color_oper = ""; + const char *on_color_operational, *off_color_operational; int i, c; sd_network_get_operational_state(&operational_state); - if (streq_ptr(operational_state, "routable")) { - on_color_oper = ansi_highlight_green(); - off_color_oper = ansi_highlight_off(); - } else if (streq_ptr(operational_state, "degraded")) { - on_color_oper = ansi_highlight_yellow(); - off_color_oper = ansi_highlight_off(); - } + operational_state_to_color(operational_state, &on_color_operational, &off_color_operational); - printf(" State: %s%s%s\n", on_color_oper, strna(operational_state), off_color_oper); + printf(" State: %s%s%s\n", on_color_operational, strna(operational_state), off_color_operational); c = local_addresses(rtnl, 0, &addresses); for (i = 0; i < c; i++) { @@ -457,7 +483,11 @@ static int link_status(char **args, unsigned n) { if (!strv_isempty(dns)) dump_list(" DNS: ", dns); - sd_network_get_dns(&ntp); + sd_network_get_domains(&domains); + if (!strv_isempty(domains)) + dump_list(" Domain: ", domains); + + sd_network_get_ntp(&ntp); if (!strv_isempty(ntp)) dump_list(" NTP: ", ntp);