X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fexecute.c;h=6b6c2855b48739c04febe6878c37d6370f3e3b11;hp=5483b6949eae57814eb14236e4a5f1104d1c69a5;hb=21d21ea42eadd742873c2bddfd474e3b34510431;hpb=fc9b2a84dcf70bdd3100cbcb84f2858dd5303d76 diff --git a/src/execute.c b/src/execute.c index 5483b6949..6b6c2855b 100644 --- a/src/execute.c +++ b/src/execute.c @@ -308,6 +308,10 @@ static int setup_output(const ExecContext *context, int socket_fd, const char *i case EXEC_OUTPUT_INHERIT: + /* If input got downgraded, inherit the original value */ + if (i == EXEC_INPUT_NULL && is_terminal_input(context->std_input)) + return open_terminal_as(tty_path(context), O_WRONLY, STDOUT_FILENO); + /* If the input is connected to anything that's not a /dev/null, inherit that... */ if (i != EXEC_INPUT_NULL) return dup2(STDIN_FILENO, STDOUT_FILENO) < 0 ? -errno : STDOUT_FILENO; @@ -360,10 +364,11 @@ static int setup_error(const ExecContext *context, int socket_fd, const char *id if (e == EXEC_OUTPUT_INHERIT && o == EXEC_OUTPUT_INHERIT && i == EXEC_INPUT_NULL && + !is_terminal_input(context->std_input) && getppid () != 1) return STDERR_FILENO; - /* Duplicate form stdout if possible */ + /* Duplicate from stdout if possible */ if (e == o || e == EXEC_OUTPUT_INHERIT) return dup2(STDOUT_FILENO, STDERR_FILENO) < 0 ? -errno : STDERR_FILENO; @@ -968,9 +973,9 @@ int exec_spawn(ExecCommand *command, goto fail; } - /* Close sockets very early to make sure we don' block - * init reexecution because it cannot bind its sockets - * or so */ + /* Close sockets very early to make sure we don't + * block init reexecution because it cannot bind its + * sockets */ if (close_all_fds(fds, n_fds) < 0) { r = EXIT_FDS; goto fail;